You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/07/24 15:54:44 UTC

[GitHub] [hive] vineetgarg02 commented on a change in pull request #1265: [DRAFT] Support for HS2 client metadata cache

vineetgarg02 commented on a change in pull request #1265:
URL: https://github.com/apache/hive/pull/1265#discussion_r460140912



##########
File path: standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientWithLocalCache.java
##########
@@ -214,4 +214,13 @@ protected PartitionsSpecByExprResult getPartitionsSpecByExprResult(PartitionsByE
 
     return r;
   }
+
+  private boolean isRequestCachable(Object request) {

Review comment:
       Add a comment explaining what sort of request we are trying to cache and avoid caching.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org