You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/23 08:09:57 UTC
[GitHub] [spark] gengliangwang opened a new pull request #34996: [SPARK-37724][SQL] ANSI mode: disable ANSI reserved keywords by default
gengliangwang opened a new pull request #34996:
URL: https://github.com/apache/spark/pull/34996
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Disable ANSI reserved keywords by default in ANSI mode
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
The reserved keywords thing is a big stopper for many users that want to try ANSI mode. They have to update the SQL queries to pass the parser, which is nothing about data quality but just trouble. Also, there could some existing table names conflict with the ANSI reserved keyword, e.g. `USER`.
By disabling the feature as default, I think we can get better adoption of the ANSI mode.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes, disable ANSI reserved keywords by default in ANSI mode
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
existing UT.
Doc preview:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34996: [SPARK-37724][SQL] ANSI mode: disable ANSI reserved keywords by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34996:
URL: https://github.com/apache/spark/pull/34996#issuecomment-1000616872
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/51017/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34996: [SPARK-37724][SQL] ANSI mode: disable ANSI reserved keywords by default
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34996:
URL: https://github.com/apache/spark/pull/34996#issuecomment-1000589482
**[Test build #146542 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146542/testReport)** for PR 34996 at commit [`a9742fa`](https://github.com/apache/spark/commit/a9742faefca1ca619151a17bc4970c58daa0ec9e).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34996: [SPARK-37724][SQL] ANSI mode: disable ANSI reserved keywords by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34996:
URL: https://github.com/apache/spark/pull/34996#issuecomment-1000333440
**[Test build #146520 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146520/testReport)** for PR 34996 at commit [`9666918`](https://github.com/apache/spark/commit/9666918510a49259bd4fcb3a71d4673397c9cb28).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34996: [SPARK-37724][SQL] ANSI mode: disable ANSI reserved keywords by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34996:
URL: https://github.com/apache/spark/pull/34996#issuecomment-1000283845
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50996/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34996: [SPARK-37724][SQL] ANSI mode: disable ANSI reserved keywords by default
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34996:
URL: https://github.com/apache/spark/pull/34996#issuecomment-1000121884
**[Test build #146510 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146510/testReport)** for PR 34996 at commit [`f5f62c7`](https://github.com/apache/spark/commit/f5f62c7b15ffd5e0d36a1ada526b12a200ccf4e7).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34996: [SPARK-37724][SQL] ANSI mode: disable ANSI reserved keywords by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34996:
URL: https://github.com/apache/spark/pull/34996#issuecomment-1000731949
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/51030/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34996: [SPARK-37724][SQL] ANSI mode: disable ANSI reserved keywords by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34996:
URL: https://github.com/apache/spark/pull/34996#issuecomment-1000731949
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/51030/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34996: [SPARK-37724][SQL] ANSI mode: disable ANSI reserved keywords by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34996:
URL: https://github.com/apache/spark/pull/34996#issuecomment-1000440464
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/51009/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34996: [SPARK-37724][SQL] ANSI mode: disable ANSI reserved keywords by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34996:
URL: https://github.com/apache/spark/pull/34996#issuecomment-1000454411
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146534/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34996: [SPARK-37724][SQL] ANSI mode: disable ANSI reserved keywords by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34996:
URL: https://github.com/apache/spark/pull/34996#issuecomment-1000704585
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/51030/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34996: [SPARK-37724][SQL] ANSI mode: disable ANSI reserved keywords by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34996:
URL: https://github.com/apache/spark/pull/34996#issuecomment-1000141783
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146510/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34996: [SPARK-37724][SQL] ANSI mode: disable ANSI reserved keywords by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34996:
URL: https://github.com/apache/spark/pull/34996#issuecomment-1000354779
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146520/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34996: [SPARK-37724][SQL] ANSI mode: disable ANSI reserved keywords by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34996:
URL: https://github.com/apache/spark/pull/34996#issuecomment-1000817542
**[Test build #146555 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146555/testReport)** for PR 34996 at commit [`5c3cb3a`](https://github.com/apache/spark/commit/5c3cb3aa7294b205f289dcf24010bfc9782e25a3).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34996: [SPARK-37724][SQL] ANSI mode: disable ANSI reserved keywords by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34996:
URL: https://github.com/apache/spark/pull/34996#issuecomment-1000319522
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50996/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34996: [SPARK-37724][SQL] ANSI mode: disable ANSI reserved keywords by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34996:
URL: https://github.com/apache/spark/pull/34996#issuecomment-1000414669
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/51009/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34996: [SPARK-37724][SQL] ANSI mode: disable ANSI reserved keywords by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34996:
URL: https://github.com/apache/spark/pull/34996#issuecomment-1000454239
**[Test build #146534 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146534/testReport)** for PR 34996 at commit [`358d8d8`](https://github.com/apache/spark/commit/358d8d8bcad34bcaa30c072bc81bd4a88fb39e77).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34996: [SPARK-37724][SQL] ANSI mode: disable ANSI reserved keywords by default
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34996:
URL: https://github.com/apache/spark/pull/34996#issuecomment-1000256425
**[Test build #146520 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146520/testReport)** for PR 34996 at commit [`9666918`](https://github.com/apache/spark/commit/9666918510a49259bd4fcb3a71d4673397c9cb28).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34996: [SPARK-37724][SQL] ANSI mode: disable ANSI reserved keywords by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34996:
URL: https://github.com/apache/spark/pull/34996#issuecomment-1000720135
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/51030/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34996: [SPARK-37724][SQL] ANSI mode: disable ANSI reserved keywords by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34996:
URL: https://github.com/apache/spark/pull/34996#issuecomment-1000135827
**[Test build #146510 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146510/testReport)** for PR 34996 at commit [`f5f62c7`](https://github.com/apache/spark/commit/f5f62c7b15ffd5e0d36a1ada526b12a200ccf4e7).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34996: [SPARK-37724][SQL] ANSI mode: disable ANSI reserved keywords by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34996:
URL: https://github.com/apache/spark/pull/34996#issuecomment-1000319522
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50996/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34996: [SPARK-37724][SQL] ANSI mode: disable ANSI reserved keywords by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34996:
URL: https://github.com/apache/spark/pull/34996#issuecomment-1000669033
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146542/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34996: [SPARK-37724][SQL] ANSI mode: disable ANSI reserved keywords by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34996:
URL: https://github.com/apache/spark/pull/34996#issuecomment-1000669033
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146542/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34996: [SPARK-37724][SQL] ANSI mode: disable ANSI reserved keywords by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34996:
URL: https://github.com/apache/spark/pull/34996#issuecomment-1000828828
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146555/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34996: [SPARK-37724][SQL] ANSI mode: disable ANSI reserved keywords by default
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34996:
URL: https://github.com/apache/spark/pull/34996#issuecomment-1000687380
**[Test build #146555 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146555/testReport)** for PR 34996 at commit [`5c3cb3a`](https://github.com/apache/spark/commit/5c3cb3aa7294b205f289dcf24010bfc9782e25a3).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34996: [SPARK-37724][SQL] ANSI mode: disable ANSI reserved keywords by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34996:
URL: https://github.com/apache/spark/pull/34996#issuecomment-1000317493
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50996/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34996: [SPARK-37724][SQL] ANSI mode: disable ANSI reserved keywords by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34996:
URL: https://github.com/apache/spark/pull/34996#issuecomment-1000602003
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/51017/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34996: [SPARK-37724][SQL] ANSI mode: disable ANSI reserved keywords by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34996:
URL: https://github.com/apache/spark/pull/34996#issuecomment-1000141783
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146510/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34996: [SPARK-37724][SQL] ANSI mode: disable ANSI reserved keywords by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34996:
URL: https://github.com/apache/spark/pull/34996#issuecomment-1000621804
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/51017/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34996: [SPARK-37724][SQL] ANSI mode: disable ANSI reserved keywords by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34996:
URL: https://github.com/apache/spark/pull/34996#issuecomment-1000621804
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/51017/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34996: [SPARK-37724][SQL] ANSI mode: disable ANSI reserved keywords by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34996:
URL: https://github.com/apache/spark/pull/34996#issuecomment-1000186742
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50986/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34996: [SPARK-37724][SQL] ANSI mode: disable ANSI reserved keywords by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34996:
URL: https://github.com/apache/spark/pull/34996#issuecomment-1000186716
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50986/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34996: [SPARK-37724][SQL] ANSI mode: disable ANSI reserved keywords by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34996:
URL: https://github.com/apache/spark/pull/34996#issuecomment-1000390863
**[Test build #146534 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146534/testReport)** for PR 34996 at commit [`358d8d8`](https://github.com/apache/spark/commit/358d8d8bcad34bcaa30c072bc81bd4a88fb39e77).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34996: [SPARK-37724][SQL] ANSI mode: disable ANSI reserved keywords by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34996:
URL: https://github.com/apache/spark/pull/34996#issuecomment-1000454411
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146534/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34996: [SPARK-37724][SQL] ANSI mode: disable ANSI reserved keywords by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34996:
URL: https://github.com/apache/spark/pull/34996#issuecomment-1000256425
**[Test build #146520 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146520/testReport)** for PR 34996 at commit [`9666918`](https://github.com/apache/spark/commit/9666918510a49259bd4fcb3a71d4673397c9cb28).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34996: [SPARK-37724][SQL] ANSI mode: disable ANSI reserved keywords by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34996:
URL: https://github.com/apache/spark/pull/34996#issuecomment-1000589482
**[Test build #146542 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146542/testReport)** for PR 34996 at commit [`a9742fa`](https://github.com/apache/spark/commit/a9742faefca1ca619151a17bc4970c58daa0ec9e).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #34996: [SPARK-37724][SQL] ANSI mode: disable ANSI reserved keywords by default
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #34996:
URL: https://github.com/apache/spark/pull/34996#issuecomment-1000901725
@cloud-fan @dongjoon-hyun thanks for the review.
Merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang closed pull request #34996: [SPARK-37724][SQL] ANSI mode: disable ANSI reserved keywords by default
Posted by GitBox <gi...@apache.org>.
gengliangwang closed pull request #34996:
URL: https://github.com/apache/spark/pull/34996
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34996: [SPARK-37724][SQL] ANSI mode: disable ANSI reserved keywords by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34996:
URL: https://github.com/apache/spark/pull/34996#issuecomment-1000449886
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/51009/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34996: [SPARK-37724][SQL] ANSI mode: disable ANSI reserved keywords by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34996:
URL: https://github.com/apache/spark/pull/34996#issuecomment-1000667551
**[Test build #146542 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146542/testReport)** for PR 34996 at commit [`a9742fa`](https://github.com/apache/spark/commit/a9742faefca1ca619151a17bc4970c58daa0ec9e).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34996: [SPARK-37724][SQL] ANSI mode: disable ANSI reserved keywords by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34996:
URL: https://github.com/apache/spark/pull/34996#issuecomment-1000186742
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50986/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34996: [SPARK-37724][SQL] ANSI mode: disable ANSI reserved keywords by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34996:
URL: https://github.com/apache/spark/pull/34996#issuecomment-1000121884
**[Test build #146510 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146510/testReport)** for PR 34996 at commit [`f5f62c7`](https://github.com/apache/spark/commit/f5f62c7b15ffd5e0d36a1ada526b12a200ccf4e7).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34996: [SPARK-37724][SQL] ANSI mode: disable ANSI reserved keywords by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34996:
URL: https://github.com/apache/spark/pull/34996#issuecomment-1000144637
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50986/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34996: [SPARK-37724][SQL] ANSI mode: disable ANSI reserved keywords by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34996:
URL: https://github.com/apache/spark/pull/34996#issuecomment-1000687380
**[Test build #146555 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146555/testReport)** for PR 34996 at commit [`5c3cb3a`](https://github.com/apache/spark/commit/5c3cb3aa7294b205f289dcf24010bfc9782e25a3).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34996: [SPARK-37724][SQL] ANSI mode: disable ANSI reserved keywords by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34996:
URL: https://github.com/apache/spark/pull/34996#issuecomment-1000828828
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146555/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34996: [SPARK-37724][SQL] ANSI mode: disable ANSI reserved keywords by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34996:
URL: https://github.com/apache/spark/pull/34996#issuecomment-1000354779
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146520/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34996: [SPARK-37724][SQL] ANSI mode: disable ANSI reserved keywords by default
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34996:
URL: https://github.com/apache/spark/pull/34996#issuecomment-1000390863
**[Test build #146534 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146534/testReport)** for PR 34996 at commit [`358d8d8`](https://github.com/apache/spark/commit/358d8d8bcad34bcaa30c072bc81bd4a88fb39e77).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34996: [SPARK-37724][SQL] ANSI mode: disable ANSI reserved keywords by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34996:
URL: https://github.com/apache/spark/pull/34996#issuecomment-1000449886
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/51009/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org