You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/04/08 08:46:42 UTC
[GitHub] [apisix] juzhiyuan opened a new issue, #6809: docs: picture with Chinese in English Documentation
juzhiyuan opened a new issue, #6809:
URL: https://github.com/apache/apisix/issues/6809
### Current State
1. Visit https://apisix.apache.org/docs/apisix/2.12/external-plugin/ in the English version.
2. The architecture diagram is in Chinese.
3. Note: If you're Chinese as the browser's default language, the website will redirect to the Chinese version. You could click on Top-Right Language Switcher to change the language.
### Desired State
The architecture diagram should be in English, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on issue #6809: docs: picture with Chinese in English Documentation
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #6809:
URL: https://github.com/apache/apisix/issues/6809#issuecomment-1092614365
Just found that the latest unreleased from the master branch is using the English version.
https://apisix.apache.org/docs/apisix/next/external-plugin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Ajay-singh1 commented on issue #6809: docs: picture with Chinese in English Documentation
Posted by "Ajay-singh1 (via GitHub)" <gi...@apache.org>.
Ajay-singh1 commented on issue #6809:
URL: https://github.com/apache/apisix/issues/6809#issuecomment-1454357745
I can't see any Chinese text!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] kayx23 commented on issue #6809: docs: picture with Chinese in English Documentation
Posted by "kayx23 (via GitHub)" <gi...@apache.org>.
kayx23 commented on issue #6809:
URL: https://github.com/apache/apisix/issues/6809#issuecomment-1722482891
Seems to be addressed. Both docs used the English version now 😂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on issue #6809: docs: picture with Chinese in English Documentation
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #6809:
URL: https://github.com/apache/apisix/issues/6809#issuecomment-1092622216
It is V2.13's Documentation site https://apisix.apache.org/docs/apisix/external-plugin/. Also, it's the default documentation for visitors when they read the `apache/apisix` project docs.
Because people will read the Chinese doc until we release 2.14 in the future, I would prefer to invite contributors to fix this issue for v2.13.
But the confusing point is that we have to update the `release/2.13` branch if we fix this issue. Then do we need to release a new version by following the ASF's policy?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] SkyeYoung commented on issue #6809: docs: picture with Chinese in English Documentation
Posted by GitBox <gi...@apache.org>.
SkyeYoung commented on issue #6809:
URL: https://github.com/apache/apisix/issues/6809#issuecomment-1092652052
@juzhiyuan One question I've been thinking about is why not have the latest release branch be the default branch for the current document?
However, this creates a problem. When an APISIX version is released, the documentation work that was on master needs to be moved to the branch of the latest release. And the documentation work for the next release should be done on the master branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] kayx23 closed issue #6809: docs: picture with Chinese in English Documentation
Posted by "kayx23 (via GitHub)" <gi...@apache.org>.
kayx23 closed issue #6809: docs: picture with Chinese in English Documentation
URL: https://github.com/apache/apisix/issues/6809
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on issue #6809: docs: picture with Chinese in English Documentation
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #6809:
URL: https://github.com/apache/apisix/issues/6809#issuecomment-1096268187
> Only a new tag is concerned from the foundation perspective.
Much clearer, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #6809: docs: picture with Chinese in English Documentation
Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #6809:
URL: https://github.com/apache/apisix/issues/6809#issuecomment-1092775184
> It is V2.13's Documentation site [apisix.apache.org/docs/apisix/external-plugin](https://apisix.apache.org/docs/apisix/external-plugin/). Also, it's the default documentation for visitors when they read the `apache/apisix` project docs.
>
> Because people will read the English doc with Chinese content until we release 2.14 in the future, I would prefer to invite contributors to fix this issue for v2.13. But the confusing point is that we have to update the `release/2.13` branch if we fix this issue. Then do we need to release a new version by following the ASF's policy? cc @spacewander @wu-sheng
You can simply backport it. We have done this before: https://github.com/apache/apisix/pull/4671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on issue #6809: docs: picture with Chinese in English Documentation
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #6809:
URL: https://github.com/apache/apisix/issues/6809#issuecomment-1092634051
Hi, it is due to the Apache APISIX Website's building logic. Currently, the Apache APISIX Website will do those things:
1. Run a script to clone projects' repo in CI;
2. Read markdown files by switching each repo's branch;
3. Generate web pages for each branch.
4. Use Cron to run CI daily.
I noticed Apache SkyWalking is using commit id https://github.com/apache/skywalking-website/blob/master/data/docs.yml#L36. We could update the website's configuration files when we needed to build docs. Also, cc @SkyeYoung @bzp2010
Back to this issue, what confused me is if we update the `release/2.13` branch, do we need to have an official release by voting?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] wu-sheng commented on issue #6809: docs: picture with Chinese in English Documentation
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6809:
URL: https://github.com/apache/apisix/issues/6809#issuecomment-1092636842
> Back to this issue, what confused me is if we update the release/2.13 branch, do we need to have an official release by voting?
It is just a branch. How APISIX community wants to manage it, or what is branch creation rule, that is PMC decision only. Only a new tag is concerned from the foundation perspective.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] wu-sheng commented on issue #6809: docs: picture with Chinese in English Documentation
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6809:
URL: https://github.com/apache/apisix/issues/6809#issuecomment-1092625386
Why do you have to run a release for a doc page? The commit ID is an option to avoid tag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] SkyeYoung commented on issue #6809: docs: picture with Chinese in English Documentation
Posted by "SkyeYoung (via GitHub)" <gi...@apache.org>.
SkyeYoung commented on issue #6809:
URL: https://github.com/apache/apisix/issues/6809#issuecomment-1457430301
@Ajay-singh1 Hi, you can help the community improve this document 😸
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org