You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Apoorv Naik <na...@gmail.com> on 2017/09/06 18:45:18 UTC

Review Request 62129: ATLAS-2117: Basic search issues due to Titan Solr schema

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62129/
-----------------------------------------------------------

Review request for atlas and Madhan Neethiraj.


Bugs: ATLAS-2117
    https://issues.apache.org/jira/browse/ATLAS-2117


Repository: atlas


Description
-------

See JIRA


Diffs
-----

  repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java 0daab030 
  repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java d5e39236 
  repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java fc973e6f 


Diff: https://reviews.apache.org/r/62129/diff/1/


Testing
-------

UI and REST calls working as expected now.


Thanks,

Apoorv Naik


Re: Review Request 62129: ATLAS-2117: Basic search issues due to Titan Solr schema

Posted by Apoorv Naik <na...@gmail.com>.

> On Sept. 6, 2017, 10:36 p.m., Madhan Neethiraj wrote:
> > repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java
> > Lines 228 (patched)
> > <https://reviews.apache.org/r/62129/diff/1/?file=1816577#file1816577line236>
> >
> >     This is needed only for String type attributes, right?

Yes that's correct, I'll modify the check to take the type into consideration as well.


- Apoorv


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62129/#review184749
-----------------------------------------------------------


On Sept. 6, 2017, 11:38 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62129/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2017, 11:38 p.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2117
>     https://issues.apache.org/jira/browse/ATLAS-2117
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> See JIRA
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java 0daab030 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java d5e39236 
>   repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java fc973e6f 
> 
> 
> Diff: https://reviews.apache.org/r/62129/diff/2/
> 
> 
> Testing
> -------
> 
> UI and REST calls working as expected now.
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>


Re: Review Request 62129: ATLAS-2117: Basic search issues due to Titan Solr schema

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62129/#review184749
-----------------------------------------------------------




repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java
Lines 228 (patched)
<https://reviews.apache.org/r/62129/#comment260951>

    This is needed only for String type attributes, right?



repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java
Lines 239 (patched)
<https://reviews.apache.org/r/62129/#comment260949>

    This was necessary only for NEQ cases, right? For comparators like EQ, I think it will be efficient to apply index filter first and apply in-memory filter to get rid of incorrect matches.



repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java
Line 325 (original), 326 (patched)
<https://reviews.apache.org/r/62129/#comment260950>

    Can attrVal be other type of collection, like Set? If yes, use Collection, instead of list here.


- Madhan Neethiraj


On Sept. 6, 2017, 6:45 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62129/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2017, 6:45 p.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2117
>     https://issues.apache.org/jira/browse/ATLAS-2117
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> See JIRA
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java 0daab030 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java d5e39236 
>   repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java fc973e6f 
> 
> 
> Diff: https://reviews.apache.org/r/62129/diff/1/
> 
> 
> Testing
> -------
> 
> UI and REST calls working as expected now.
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>


Re: Review Request 62129: ATLAS-2117: Basic search issues due to Titan Solr schema

Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62129/#review184755
-----------------------------------------------------------




repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java
Lines 239 (patched)
<https://reviews.apache.org/r/62129/#comment260960>

    Let me double check my notes, I think you're correct though.



repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java
Line 325 (original), 326 (patched)
<https://reviews.apache.org/r/62129/#comment260962>

    Will do.


- Apoorv Naik


On Sept. 6, 2017, 11:38 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62129/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2017, 11:38 p.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2117
>     https://issues.apache.org/jira/browse/ATLAS-2117
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> See JIRA
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java 0daab030 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java d5e39236 
>   repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java fc973e6f 
> 
> 
> Diff: https://reviews.apache.org/r/62129/diff/2/
> 
> 
> Testing
> -------
> 
> UI and REST calls working as expected now.
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>


Re: Review Request 62129: ATLAS-2117: Basic search issues due to Titan Solr schema

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62129/#review185373
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On Sept. 14, 2017, 5:15 a.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62129/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2017, 5:15 a.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2117
>     https://issues.apache.org/jira/browse/ATLAS-2117
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> See JIRA
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java ddf117fa 
> 
> 
> Diff: https://reviews.apache.org/r/62129/diff/5/
> 
> 
> Testing
> -------
> 
> UI and REST calls working as expected now.
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>


Re: Review Request 62129: ATLAS-2117: Basic search issues due to Titan Solr schema

Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62129/
-----------------------------------------------------------

(Updated Sept. 14, 2017, 5:15 a.m.)


Review request for atlas and Madhan Neethiraj.


Changes
-------

Removed offending characters logic for a different review and JIRA


Bugs: ATLAS-2117
    https://issues.apache.org/jira/browse/ATLAS-2117


Repository: atlas


Description
-------

See JIRA


Diffs (updated)
-----

  repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java ddf117fa 


Diff: https://reviews.apache.org/r/62129/diff/5/

Changes: https://reviews.apache.org/r/62129/diff/4-5/


Testing
-------

UI and REST calls working as expected now.


Thanks,

Apoorv Naik


Re: Review Request 62129: ATLAS-2117: Basic search issues due to Titan Solr schema

Posted by Apoorv Naik <na...@gmail.com>.

> On Sept. 14, 2017, 2:55 a.m., Madhan Neethiraj wrote:
> > repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java
> > Lines 232 (patched)
> > <https://reviews.apache.org/r/62129/diff/4/?file=1821427#file1821427line232>
> >
> >     Instead of completely rejecting index-query on detecting NEQ on a string attribute, consider treating this as a non-indexed attribute (line #240) - so that index-query can handle other attributes and this attribute can be handled by graph query or in-memory query.

That's a good idea, I think it's better to move this section in attribute processing call and any such violation should mark the attribute to be filtered by graph. Will update the review shortly


- Apoorv


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62129/#review185363
-----------------------------------------------------------


On Sept. 14, 2017, 2:32 a.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62129/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2017, 2:32 a.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2117
>     https://issues.apache.org/jira/browse/ATLAS-2117
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> See JIRA
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java ddf117fa 
> 
> 
> Diff: https://reviews.apache.org/r/62129/diff/4/
> 
> 
> Testing
> -------
> 
> UI and REST calls working as expected now.
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>


Re: Review Request 62129: ATLAS-2117: Basic search issues due to Titan Solr schema

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62129/#review185363
-----------------------------------------------------------




repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java
Lines 232 (patched)
<https://reviews.apache.org/r/62129/#comment261669>

    Instead of completely rejecting index-query on detecting NEQ on a string attribute, consider treating this as a non-indexed attribute (line #240) - so that index-query can handle other attributes and this attribute can be handled by graph query or in-memory query.


- Madhan Neethiraj


On Sept. 14, 2017, 2:32 a.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62129/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2017, 2:32 a.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2117
>     https://issues.apache.org/jira/browse/ATLAS-2117
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> See JIRA
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java ddf117fa 
> 
> 
> Diff: https://reviews.apache.org/r/62129/diff/4/
> 
> 
> Testing
> -------
> 
> UI and REST calls working as expected now.
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>


Re: Review Request 62129: ATLAS-2117: Basic search issues due to Titan Solr schema

Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62129/
-----------------------------------------------------------

(Updated Sept. 14, 2017, 2:32 a.m.)


Review request for atlas and Madhan Neethiraj.


Bugs: ATLAS-2117
    https://issues.apache.org/jira/browse/ATLAS-2117


Repository: atlas


Description
-------

See JIRA


Diffs (updated)
-----

  repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java ddf117fa 


Diff: https://reviews.apache.org/r/62129/diff/4/

Changes: https://reviews.apache.org/r/62129/diff/3-4/


Testing
-------

UI and REST calls working as expected now.


Thanks,

Apoorv Naik


Re: Review Request 62129: ATLAS-2117: Basic search issues due to Titan Solr schema

Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62129/
-----------------------------------------------------------

(Updated Sept. 13, 2017, 4:16 a.m.)


Review request for atlas and Madhan Neethiraj.


Changes
-------

Reverting overlapping change from ATLAS-2115


Bugs: ATLAS-2117
    https://issues.apache.org/jira/browse/ATLAS-2117


Repository: atlas


Description
-------

See JIRA


Diffs (updated)
-----

  repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java 0daab030 
  repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java d5e39236 


Diff: https://reviews.apache.org/r/62129/diff/3/

Changes: https://reviews.apache.org/r/62129/diff/2-3/


Testing
-------

UI and REST calls working as expected now.


Thanks,

Apoorv Naik


Re: Review Request 62129: ATLAS-2117: Basic search issues due to Titan Solr schema

Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62129/
-----------------------------------------------------------

(Updated Sept. 11, 2017, 9:48 p.m.)


Review request for atlas and Madhan Neethiraj.


Changes
-------

Added dependency on other another review, for the IN predicate changes.


Bugs: ATLAS-2117
    https://issues.apache.org/jira/browse/ATLAS-2117


Repository: atlas


Description
-------

See JIRA


Diffs
-----

  repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java 0daab030 
  repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java d5e39236 
  repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java fc973e6f 


Diff: https://reviews.apache.org/r/62129/diff/2/


Testing
-------

UI and REST calls working as expected now.


Thanks,

Apoorv Naik


Re: Review Request 62129: ATLAS-2117: Basic search issues due to Titan Solr schema

Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62129/
-----------------------------------------------------------

(Updated Sept. 6, 2017, 11:38 p.m.)


Review request for atlas and Madhan Neethiraj.


Changes
-------

Addressed review comments


Bugs: ATLAS-2117
    https://issues.apache.org/jira/browse/ATLAS-2117


Repository: atlas


Description
-------

See JIRA


Diffs (updated)
-----

  repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java 0daab030 
  repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java d5e39236 
  repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java fc973e6f 


Diff: https://reviews.apache.org/r/62129/diff/2/

Changes: https://reviews.apache.org/r/62129/diff/1-2/


Testing
-------

UI and REST calls working as expected now.


Thanks,

Apoorv Naik