You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "mcgilman (via GitHub)" <gi...@apache.org> on 2025/09/09 19:41:11 UTC
[PR] NIFI-14950: Allowing individual state entries to be removed when the … [nifi]
mcgilman opened a new pull request, #10287:
URL: https://github.com/apache/nifi/pull/10287
…underlying component supports it.
This PR is the UI counterpart to https://github.com/apache/nifi/pull/10238. It should not be merged until the back end changes land first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-14950: Allowing individual state entries to be removed when the … [nifi]
Posted by "rfellows (via GitHub)" <gi...@apache.org>.
rfellows commented on code in PR #10287:
URL: https://github.com/apache/nifi/pull/10287#discussion_r2340910724
##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/ui/common/component-state/component-state.component.html:
##########
@@ -89,6 +106,23 @@ <h2 mat-dialog-title>Component State</h2>
</ng-container>
}
+ <!-- Actions Column -->
+ @if (displayedColumns.includes('actions')) {
+ <ng-container matColumnDef="actions">
+ <th mat-header-cell *matHeaderCellDef></th>
+ <td mat-cell *matCellDef="let item">
+ <button
+ [disabled]="isClearing"
+ mat-icon-button
+ color="primary"
+ (click)="clearComponentStateEntry(item)"
+ [title]="'Clear state entry: ' + item.key">
+ <i class="fa fa-trash" aria-hidden="true"></i>
Review Comment:
from MDN:
> `aria-hidden="true"` should not be used on elements that can receive focus
These trash can icons can be tabbed to, so we should not be setting this attribute.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-14950: Allowing individual state entries to be removed when the … [nifi]
Posted by "pvillard31 (via GitHub)" <gi...@apache.org>.
pvillard31 commented on PR #10287:
URL: https://github.com/apache/nifi/pull/10287#issuecomment-3275298083
Thanks for the changes @mcgilman ! I cannot really comment on the code changes but I have built this PR in combination with #10238 and it works as expected based on the testing I did.
As a side-note, the MacOS build failure is because of the known issue that has been fixed in #10288 in case you want to rebase on `main` and have full green builds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-14950: Allowing individual state entries to be removed when the … [nifi]
Posted by "rfellows (via GitHub)" <gi...@apache.org>.
rfellows merged PR #10287:
URL: https://github.com/apache/nifi/pull/10287
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-14950: Allowing individual state entries to be removed when the … [nifi]
Posted by "rfellows (via GitHub)" <gi...@apache.org>.
rfellows commented on PR #10287:
URL: https://github.com/apache/nifi/pull/10287#issuecomment-3280381455
reviewing...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org