You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Xuefu Zhang <xz...@cloudera.com> on 2014/03/31 21:07:32 UTC
Review Request 19856: HIVE-6793: DDLSemanticAnalyzer.analyzeShowRoles()
should use HiveAuthorizationTaskFactory
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19856/
-----------------------------------------------------------
Review request for hive.
Bugs: HIVE-6793
https://issues.apache.org/jira/browse/HIVE-6793
Repository: hive-git
Description
-------
Please refer to the JIRA description.
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 117295a
ql/src/java/org/apache/hadoop/hive/ql/parse/authorization/HiveAuthorizationTaskFactory.java cc84731
ql/src/java/org/apache/hadoop/hive/ql/parse/authorization/HiveAuthorizationTaskFactoryImpl.java 0354604
Diff: https://reviews.apache.org/r/19856/diff/
Testing
-------
Pure refactoring. No new test cases are added. Patch should be okay if pre-commit test passes.
Thanks,
Xuefu Zhang
Re: Review Request 19856: HIVE-6793: DDLSemanticAnalyzer.analyzeShowRoles()
should use HiveAuthorizationTaskFactory
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19856/#review39089
-----------------------------------------------------------
Ship it!
Ship It!
- Brock Noland
On March 31, 2014, 7:07 p.m., Xuefu Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19856/
> -----------------------------------------------------------
>
> (Updated March 31, 2014, 7:07 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-6793
> https://issues.apache.org/jira/browse/HIVE-6793
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Please refer to the JIRA description.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 117295a
> ql/src/java/org/apache/hadoop/hive/ql/parse/authorization/HiveAuthorizationTaskFactory.java cc84731
> ql/src/java/org/apache/hadoop/hive/ql/parse/authorization/HiveAuthorizationTaskFactoryImpl.java 0354604
>
> Diff: https://reviews.apache.org/r/19856/diff/
>
>
> Testing
> -------
>
> Pure refactoring. No new test cases are added. Patch should be okay if pre-commit test passes.
>
>
> Thanks,
>
> Xuefu Zhang
>
>