You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@ofbiz.apache.org by "skip@theDevers" <sk...@thedevers.org> on 2007/10/19 20:26:57 UTC
Bug in add party notes
Log into webtools. Click on Party tab. Click on "Find..." at the bottom
with all the fields blank. Select "DemoCustCompany" [Details]
At the very bottom of the page, click "Create New" in the notes area.
In the next screen, enter a noteId and note and click save at the bottom.
You get this error:
...
[noteId,DemoNote1(java.lang.String)][partyId,DemoCustCompany(java.lang.Strin
g)] ... INSERT on table 'PARTY_NOTE' caused a violation of foreign key
constraint 'PARTY_NOTE_NOTE' for key (DemoNote1).
....
org.ofbiz.party.party.PartyServices.createPartyNote(PartyServices.java:631)
If you look at the code referenced, you will note that if the "Note Id"
field is left blank, the NoteData entry is created and everything works
fine.
It is my view that createPartyNote() should be modified to check to see if
the NoteData exists if a noteId is passed and if not, one should be created
or else the Note id field should be removed from (or passed as hidden) the
note creation screen.
I don't actually understand why the user would be asked to enter a noteId
anyway.
I can fix this and submit a patch, but I wanted to be sure I wasn't missing
something.
Skip
Re: How ot create a patch file?
Posted by David E Jones <jo...@hotwaxmedia.com>.
There is some info in the Contributors Best Practices document (this
is the doc for anyone who wants to contribute, mostly through Jira,
etc):
http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices
-David
On Oct 20, 2007, at 11:17 AM, skip@theDevers wrote:
> Can someone tell me the svn command to create a patch? If so, I'll
> submit
> it today.
>
>
> Skip
>
> -----Original Message-----
> From: Jacques Le Roux [mailto:jacques.le.roux@les7arts.com]
> Sent: Saturday, October 20, 2007 5:26 AM
> To: user@ofbiz.apache.org
> Subject: Re: Bug in add party notes
>
>
> Hi Skip,
>
> De : "skip@theDevers" <sk...@thedevers.org>
>> Log into webtools. Click on Party tab. Click on "Find..." at the
>> bottom
>> with all the fields blank. Select "DemoCustCompany" [Details]
>>
>> At the very bottom of the page, click "Create New" in the notes area.
>>
>> In the next screen, enter a noteId and note and click save at the
>> bottom.
>> You get this error:
>>
>> ...
>>
> [noteId,DemoNote1(java.lang.String)][partyId,DemoCustCompany
> (java.lang.Strin
>> g)] ... INSERT on table 'PARTY_NOTE' caused a violation of foreign
>> key
>> constraint 'PARTY_NOTE_NOTE' for key (DemoNote1).
>>
>> ....
>>
>>
> org.ofbiz.party.party.PartyServices.createPartyNote
> (PartyServices.java:631)
>>
>>
>> If you look at the code referenced, you will note that if the
>> "Note Id"
>> field is left blank, the NoteData entry is created and everything
>> works
>> fine.
>>
>>
>> It is my view that createPartyNote() should be modified to check
>> to see if
>> the NoteData exists if a noteId is passed and if not, one should be
> created
>> or else the Note id field should be removed from (or passed as
>> hidden) the
>> note creation screen.
>
> Yes I agree, this is a solution
>
>> I don't actually understand why the user would be asked to enter a
>> noteId
>> anyway.
>
> Maybe to allow user to set itself his/her notes number for recall
> later ?
> But then it should not be a primary key (which should be
> generated) or it should be checked in code (as for Product for
> instance)
>
>> I can fix this and submit a patch, but I wanted to be sure I wasn't
> missing
>> something.
>
> Please feel free to submit a patch
>
> Thanks
>
> Jacques
>
>> Skip
>>
>
>
Re: How ot create a patch file?
Posted by BJ Freeman <bj...@free-man.net>.
I am stubborn, but once I learn I don't forget.
:)
David E Jones sent the following on 10/20/2007 10:24 AM:
>
> Looks like we're on the same page BJ. ;)
>
> -David
>
>
> On Oct 20, 2007, at 11:21 AM, BJ Freeman wrote:
>
>> http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices
>>
>> skip@theDevers sent the following on 10/20/2007 10:17 AM:
>>> Can someone tell me the svn command to create a patch? If so, I'll
>>> submit
>>> it today.
>>>
>>>
>>> Skip
>>>
>>> -----Original Message-----
>>> From: Jacques Le Roux [mailto:jacques.le.roux@les7arts.com]
>>> Sent: Saturday, October 20, 2007 5:26 AM
>>> To: user@ofbiz.apache.org
>>> Subject: Re: Bug in add party notes
>>>
>>>
>>> Hi Skip,
>>>
>>> De : "skip@theDevers" <sk...@thedevers.org>
>>>> Log into webtools. Click on Party tab. Click on "Find..." at the
>>>> bottom
>>>> with all the fields blank. Select "DemoCustCompany" [Details]
>>>>
>>>> At the very bottom of the page, click "Create New" in the notes area.
>>>>
>>>> In the next screen, enter a noteId and note and click save at the
>>>> bottom.
>>>> You get this error:
>>>>
>>>> ...
>>>>
>>> [noteId,DemoNote1(java.lang.String)][partyId,DemoCustCompany(java.lang.Strin
>>>
>>>> g)] ... INSERT on table 'PARTY_NOTE' caused a violation of foreign key
>>>> constraint 'PARTY_NOTE_NOTE' for key (DemoNote1).
>>>>
>>>> ....
>>>>
>>>>
>>> org.ofbiz.party.party.PartyServices.createPartyNote(PartyServices.java:631)
>>>
>>>>
>>>> If you look at the code referenced, you will note that if the "Note Id"
>>>> field is left blank, the NoteData entry is created and everything works
>>>> fine.
>>>>
>>>>
>>>> It is my view that createPartyNote() should be modified to check to
>>>> see if
>>>> the NoteData exists if a noteId is passed and if not, one should be
>>> created
>>>> or else the Note id field should be removed from (or passed as
>>>> hidden) the
>>>> note creation screen.
>>>
>>> Yes I agree, this is a solution
>>>
>>>> I don't actually understand why the user would be asked to enter a
>>>> noteId
>>>> anyway.
>>>
>>> Maybe to allow user to set itself his/her notes number for recall
>>> later ?
>>> But then it should not be a primary key (which should be
>>> generated) or it should be checked in code (as for Product for instance)
>>>
>>>> I can fix this and submit a patch, but I wanted to be sure I wasn't
>>> missing
>>>> something.
>>>
>>> Please feel free to submit a patch
>>>
>>> Thanks
>>>
>>> Jacques
>>>
>>>> Skip
>>>>
>>>
>>>
>>>
>>>
>>>
>
Re: How ot create a patch file?
Posted by David E Jones <jo...@hotwaxmedia.com>.
Looks like we're on the same page BJ. ;)
-David
On Oct 20, 2007, at 11:21 AM, BJ Freeman wrote:
> http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best
> +Practices
>
> skip@theDevers sent the following on 10/20/2007 10:17 AM:
>> Can someone tell me the svn command to create a patch? If so,
>> I'll submit
>> it today.
>>
>>
>> Skip
>>
>> -----Original Message-----
>> From: Jacques Le Roux [mailto:jacques.le.roux@les7arts.com]
>> Sent: Saturday, October 20, 2007 5:26 AM
>> To: user@ofbiz.apache.org
>> Subject: Re: Bug in add party notes
>>
>>
>> Hi Skip,
>>
>> De : "skip@theDevers" <sk...@thedevers.org>
>>> Log into webtools. Click on Party tab. Click on "Find..." at
>>> the bottom
>>> with all the fields blank. Select "DemoCustCompany" [Details]
>>>
>>> At the very bottom of the page, click "Create New" in the notes
>>> area.
>>>
>>> In the next screen, enter a noteId and note and click save at the
>>> bottom.
>>> You get this error:
>>>
>>> ...
>>>
>> [noteId,DemoNote1(java.lang.String)][partyId,DemoCustCompany
>> (java.lang.Strin
>>> g)] ... INSERT on table 'PARTY_NOTE' caused a violation of
>>> foreign key
>>> constraint 'PARTY_NOTE_NOTE' for key (DemoNote1).
>>>
>>> ....
>>>
>>>
>> org.ofbiz.party.party.PartyServices.createPartyNote
>> (PartyServices.java:631)
>>>
>>> If you look at the code referenced, you will note that if the
>>> "Note Id"
>>> field is left blank, the NoteData entry is created and everything
>>> works
>>> fine.
>>>
>>>
>>> It is my view that createPartyNote() should be modified to check
>>> to see if
>>> the NoteData exists if a noteId is passed and if not, one should be
>> created
>>> or else the Note id field should be removed from (or passed as
>>> hidden) the
>>> note creation screen.
>>
>> Yes I agree, this is a solution
>>
>>> I don't actually understand why the user would be asked to enter
>>> a noteId
>>> anyway.
>>
>> Maybe to allow user to set itself his/her notes number for recall
>> later ?
>> But then it should not be a primary key (which should be
>> generated) or it should be checked in code (as for Product for
>> instance)
>>
>>> I can fix this and submit a patch, but I wanted to be sure I wasn't
>> missing
>>> something.
>>
>> Please feel free to submit a patch
>>
>> Thanks
>>
>> Jacques
>>
>>> Skip
>>>
>>
>>
>>
>>
>>
RE: How ot create a patch file?
Posted by "skip@theDevers" <sk...@thedevers.org>.
Done
I have submitted my first of what I hope to be many additions.
Skip
> -----Original Message-----
> From: BJ Freeman [mailto:bjfree@free-man.net]
> Sent: Saturday, October 20, 2007 10:21 AM
> To: user@ofbiz.apache.org
> Subject: Re: How ot create a patch file?
>
>
> http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices
>
> skip@theDevers sent the following on 10/20/2007 10:17 AM:
>> Can someone tell me the svn command to create a patch? If so, I'll
submit
>> it today.
>>
>>
>> Skip
>>
>> -----Original Message-----
>> From: Jacques Le Roux [mailto:jacques.le.roux@les7arts.com]
>> Sent: Saturday, October 20, 2007 5:26 AM
>> To: user@ofbiz.apache.org
>> Subject: Re: Bug in add party notes
>>
>>
>> Hi Skip,
>>
>> De : "skip@theDevers" <sk...@thedevers.org>
>>> Log into webtools. Click on Party tab. Click on "Find..." at the
bottom
>>> with all the fields blank. Select "DemoCustCompany" [Details]
>>>
>>> At the very bottom of the page, click "Create New" in the notes area.
>>>
>>> In the next screen, enter a noteId and note and click save at the
bottom.
>>> You get this error:
>>>
>>> ...
>>>
>
[noteId,DemoNote1(java.lang.String)][partyId,DemoCustCompany(java.lang.Strin
>>> g)] ... INSERT on table 'PARTY_NOTE' caused a violation of foreign key
>>> constraint 'PARTY_NOTE_NOTE' for key (DemoNote1).
>>>
>>> ....
>>>
>>>
>
org.ofbiz.party.party.PartyServices.createPartyNote(PartyServices.java:631)
>>> If you look at the code referenced, you will note that if the "Note Id"
>>> field is left blank, the NoteData entry is created and everything works
>>> fine.
>>>
>>>
>>> It is my view that createPartyNote() should be modified to check to see
> if
>>> the NoteData exists if a noteId is passed and if not, one should be
>> created
>>> or else the Note id field should be removed from (or passed as hidden)
> the
>>> note creation screen.
>> Yes I agree, this is a solution
>>
>>> I don't actually understand why the user would be asked to enter a
noteId
>>> anyway.
>> Maybe to allow user to set itself his/her notes number for recall later ?
>> But then it should not be a primary key (which should be
>> generated) or it should be checked in code (as for Product for instance)
>>
>>> I can fix this and submit a patch, but I wanted to be sure I wasn't
>> missing
>>> something.
>> Please feel free to submit a patch
>>
>> Thanks
>>
>> Jacques
>>
>>> Skip
>>>
>>
>>
>>
>>
>
>
>
>
Re: How ot create a patch file?
Posted by BJ Freeman <bj...@free-man.net>.
When I started we did not have the luxury of these documents.
but we all have to invest the time.
even the ones that answer you have had to.
skip@theDevers sent the following on 10/20/2007 11:00 AM:
> Thanks BJ
>
> I have looked at this 15 times and always stopped after reading the first
> few lines of "How to Contriubte". So much to read.
>
> -----Original Message-----
> From: BJ Freeman [mailto:bjfree@free-man.net]
> Sent: Saturday, October 20, 2007 10:21 AM
> To: user@ofbiz.apache.org
> Subject: Re: How ot create a patch file?
>
>
> http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices
>
> skip@theDevers sent the following on 10/20/2007 10:17 AM:
>> Can someone tell me the svn command to create a patch? If so, I'll submit
>> it today.
>>
>>
>> Skip
>>
>> -----Original Message-----
>> From: Jacques Le Roux [mailto:jacques.le.roux@les7arts.com]
>> Sent: Saturday, October 20, 2007 5:26 AM
>> To: user@ofbiz.apache.org
>> Subject: Re: Bug in add party notes
>>
>>
>> Hi Skip,
>>
>> De : "skip@theDevers" <sk...@thedevers.org>
>>> Log into webtools. Click on Party tab. Click on "Find..." at the bottom
>>> with all the fields blank. Select "DemoCustCompany" [Details]
>>>
>>> At the very bottom of the page, click "Create New" in the notes area.
>>>
>>> In the next screen, enter a noteId and note and click save at the bottom.
>>> You get this error:
>>>
>>> ...
>>>
> [noteId,DemoNote1(java.lang.String)][partyId,DemoCustCompany(java.lang.Strin
>>> g)] ... INSERT on table 'PARTY_NOTE' caused a violation of foreign key
>>> constraint 'PARTY_NOTE_NOTE' for key (DemoNote1).
>>>
>>> ....
>>>
>>>
> org.ofbiz.party.party.PartyServices.createPartyNote(PartyServices.java:631)
>>> If you look at the code referenced, you will note that if the "Note Id"
>>> field is left blank, the NoteData entry is created and everything works
>>> fine.
>>>
>>>
>>> It is my view that createPartyNote() should be modified to check to see
> if
>>> the NoteData exists if a noteId is passed and if not, one should be
>> created
>>> or else the Note id field should be removed from (or passed as hidden)
> the
>>> note creation screen.
>> Yes I agree, this is a solution
>>
>>> I don't actually understand why the user would be asked to enter a noteId
>>> anyway.
>> Maybe to allow user to set itself his/her notes number for recall later ?
>> But then it should not be a primary key (which should be
>> generated) or it should be checked in code (as for Product for instance)
>>
>>> I can fix this and submit a patch, but I wanted to be sure I wasn't
>> missing
>>> something.
>> Please feel free to submit a patch
>>
>> Thanks
>>
>> Jacques
>>
>>> Skip
>>>
>>
>>
>>
>>
>
>
>
>
RE: How ot create a patch file?
Posted by "skip@theDevers" <sk...@thedevers.org>.
Thanks BJ
I have looked at this 15 times and always stopped after reading the first
few lines of "How to Contriubte". So much to read.
-----Original Message-----
From: BJ Freeman [mailto:bjfree@free-man.net]
Sent: Saturday, October 20, 2007 10:21 AM
To: user@ofbiz.apache.org
Subject: Re: How ot create a patch file?
http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices
skip@theDevers sent the following on 10/20/2007 10:17 AM:
> Can someone tell me the svn command to create a patch? If so, I'll submit
> it today.
>
>
> Skip
>
> -----Original Message-----
> From: Jacques Le Roux [mailto:jacques.le.roux@les7arts.com]
> Sent: Saturday, October 20, 2007 5:26 AM
> To: user@ofbiz.apache.org
> Subject: Re: Bug in add party notes
>
>
> Hi Skip,
>
> De : "skip@theDevers" <sk...@thedevers.org>
>> Log into webtools. Click on Party tab. Click on "Find..." at the bottom
>> with all the fields blank. Select "DemoCustCompany" [Details]
>>
>> At the very bottom of the page, click "Create New" in the notes area.
>>
>> In the next screen, enter a noteId and note and click save at the bottom.
>> You get this error:
>>
>> ...
>>
>
[noteId,DemoNote1(java.lang.String)][partyId,DemoCustCompany(java.lang.Strin
>> g)] ... INSERT on table 'PARTY_NOTE' caused a violation of foreign key
>> constraint 'PARTY_NOTE_NOTE' for key (DemoNote1).
>>
>> ....
>>
>>
>
org.ofbiz.party.party.PartyServices.createPartyNote(PartyServices.java:631)
>>
>> If you look at the code referenced, you will note that if the "Note Id"
>> field is left blank, the NoteData entry is created and everything works
>> fine.
>>
>>
>> It is my view that createPartyNote() should be modified to check to see
if
>> the NoteData exists if a noteId is passed and if not, one should be
> created
>> or else the Note id field should be removed from (or passed as hidden)
the
>> note creation screen.
>
> Yes I agree, this is a solution
>
>> I don't actually understand why the user would be asked to enter a noteId
>> anyway.
>
> Maybe to allow user to set itself his/her notes number for recall later ?
> But then it should not be a primary key (which should be
> generated) or it should be checked in code (as for Product for instance)
>
>> I can fix this and submit a patch, but I wanted to be sure I wasn't
> missing
>> something.
>
> Please feel free to submit a patch
>
> Thanks
>
> Jacques
>
>> Skip
>>
>
>
>
>
>
Re: How ot create a patch file?
Posted by BJ Freeman <bj...@free-man.net>.
http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices
skip@theDevers sent the following on 10/20/2007 10:17 AM:
> Can someone tell me the svn command to create a patch? If so, I'll submit
> it today.
>
>
> Skip
>
> -----Original Message-----
> From: Jacques Le Roux [mailto:jacques.le.roux@les7arts.com]
> Sent: Saturday, October 20, 2007 5:26 AM
> To: user@ofbiz.apache.org
> Subject: Re: Bug in add party notes
>
>
> Hi Skip,
>
> De : "skip@theDevers" <sk...@thedevers.org>
>> Log into webtools. Click on Party tab. Click on "Find..." at the bottom
>> with all the fields blank. Select "DemoCustCompany" [Details]
>>
>> At the very bottom of the page, click "Create New" in the notes area.
>>
>> In the next screen, enter a noteId and note and click save at the bottom.
>> You get this error:
>>
>> ...
>>
> [noteId,DemoNote1(java.lang.String)][partyId,DemoCustCompany(java.lang.Strin
>> g)] ... INSERT on table 'PARTY_NOTE' caused a violation of foreign key
>> constraint 'PARTY_NOTE_NOTE' for key (DemoNote1).
>>
>> ....
>>
>>
> org.ofbiz.party.party.PartyServices.createPartyNote(PartyServices.java:631)
>>
>> If you look at the code referenced, you will note that if the "Note Id"
>> field is left blank, the NoteData entry is created and everything works
>> fine.
>>
>>
>> It is my view that createPartyNote() should be modified to check to see if
>> the NoteData exists if a noteId is passed and if not, one should be
> created
>> or else the Note id field should be removed from (or passed as hidden) the
>> note creation screen.
>
> Yes I agree, this is a solution
>
>> I don't actually understand why the user would be asked to enter a noteId
>> anyway.
>
> Maybe to allow user to set itself his/her notes number for recall later ?
> But then it should not be a primary key (which should be
> generated) or it should be checked in code (as for Product for instance)
>
>> I can fix this and submit a patch, but I wanted to be sure I wasn't
> missing
>> something.
>
> Please feel free to submit a patch
>
> Thanks
>
> Jacques
>
>> Skip
>>
>
>
>
>
>
How ot create a patch file?
Posted by "skip@theDevers" <sk...@thedevers.org>.
Can someone tell me the svn command to create a patch? If so, I'll submit
it today.
Skip
-----Original Message-----
From: Jacques Le Roux [mailto:jacques.le.roux@les7arts.com]
Sent: Saturday, October 20, 2007 5:26 AM
To: user@ofbiz.apache.org
Subject: Re: Bug in add party notes
Hi Skip,
De : "skip@theDevers" <sk...@thedevers.org>
> Log into webtools. Click on Party tab. Click on "Find..." at the bottom
> with all the fields blank. Select "DemoCustCompany" [Details]
>
> At the very bottom of the page, click "Create New" in the notes area.
>
> In the next screen, enter a noteId and note and click save at the bottom.
> You get this error:
>
> ...
>
[noteId,DemoNote1(java.lang.String)][partyId,DemoCustCompany(java.lang.Strin
> g)] ... INSERT on table 'PARTY_NOTE' caused a violation of foreign key
> constraint 'PARTY_NOTE_NOTE' for key (DemoNote1).
>
> ....
>
>
org.ofbiz.party.party.PartyServices.createPartyNote(PartyServices.java:631)
>
>
> If you look at the code referenced, you will note that if the "Note Id"
> field is left blank, the NoteData entry is created and everything works
> fine.
>
>
> It is my view that createPartyNote() should be modified to check to see if
> the NoteData exists if a noteId is passed and if not, one should be
created
> or else the Note id field should be removed from (or passed as hidden) the
> note creation screen.
Yes I agree, this is a solution
> I don't actually understand why the user would be asked to enter a noteId
> anyway.
Maybe to allow user to set itself his/her notes number for recall later ?
But then it should not be a primary key (which should be
generated) or it should be checked in code (as for Product for instance)
> I can fix this and submit a patch, but I wanted to be sure I wasn't
missing
> something.
Please feel free to submit a patch
Thanks
Jacques
> Skip
>
Re: Bug in add party notes
Posted by Jacques Le Roux <ja...@les7arts.com>.
Hi Skip,
De : "skip@theDevers" <sk...@thedevers.org>
> Log into webtools. Click on Party tab. Click on "Find..." at the bottom
> with all the fields blank. Select "DemoCustCompany" [Details]
>
> At the very bottom of the page, click "Create New" in the notes area.
>
> In the next screen, enter a noteId and note and click save at the bottom.
> You get this error:
>
> ...
> [noteId,DemoNote1(java.lang.String)][partyId,DemoCustCompany(java.lang.Strin
> g)] ... INSERT on table 'PARTY_NOTE' caused a violation of foreign key
> constraint 'PARTY_NOTE_NOTE' for key (DemoNote1).
>
> ....
>
> org.ofbiz.party.party.PartyServices.createPartyNote(PartyServices.java:631)
>
>
> If you look at the code referenced, you will note that if the "Note Id"
> field is left blank, the NoteData entry is created and everything works
> fine.
>
>
> It is my view that createPartyNote() should be modified to check to see if
> the NoteData exists if a noteId is passed and if not, one should be created
> or else the Note id field should be removed from (or passed as hidden) the
> note creation screen.
Yes I agree, this is a solution
> I don't actually understand why the user would be asked to enter a noteId
> anyway.
Maybe to allow user to set itself his/her notes number for recall later ? But then it should not be a primary key (which should be
generated) or it should be checked in code (as for Product for instance)
> I can fix this and submit a patch, but I wanted to be sure I wasn't missing
> something.
Please feel free to submit a patch
Thanks
Jacques
> Skip
>