You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2022/09/06 08:50:23 UTC

[GitHub] [calcite] zhuwenzhuang opened a new pull request, #2895: [CALCITE-5267] Remove useless variable 'newCasts' in AggregateCaseToF…

zhuwenzhuang opened a new pull request, #2895:
URL: https://github.com/apache/calcite/pull/2895

   Remove useless variable 'newCasts' in AggregateCaseToFilter.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [calcite] zhuwenzhuang commented on pull request #2895: [CALCITE-5267] Remove useless variable 'newCasts' in AggregateCaseToF…

Posted by GitBox <gi...@apache.org>.

zhuwenzhuang commented on PR #2895:
URL: https://github.com/apache/calcite/pull/2895#issuecomment-1238273162

   > I checked the history. The rule is introduced from Druid[1], in which newCasts is used. It may be better to correct it instead of removing it.
   > 
   > [1] https://github.com/apache/druid/pull/4360/files#diff-809e3a73d1485dad83629598ea5bcbab8f5ce7724e9572975b052176c44fbdf7
   
   I guess the code "relBuilder.aggregate(groupKey, newCalls).convert(aggregate.getRowType(), false)" is a better way to do CAST. So we don't need to save every project to keep types stable.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [calcite] libenchao closed pull request #2895: [CALCITE-5267] Remove useless variable 'newCasts' in AggregateCaseToF…

Posted by GitBox <gi...@apache.org>.

libenchao closed pull request #2895: [CALCITE-5267] Remove useless variable 'newCasts' in AggregateCaseToF…
URL: https://github.com/apache/calcite/pull/2895


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org