You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by "Noa Horn (JIRA)" <ji...@apache.org> on 2015/11/24 20:57:11 UTC

[jira] [Comment Edited] (HAWQ-185) clean pxf jars in source code

    [ https://issues.apache.org/jira/browse/HAWQ-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15025119#comment-15025119 ] 

Noa Horn edited comment on HAWQ-185 at 11/24/15 7:57 PM:
---------------------------------------------------------

Regarding gradle-wrapper.jar, Gradle guide instructs to add it to the version control:
{quote}
The wrapper is something you should check into version control. By distributing the wrapper with your project, anyone can work with it without needing to install Gradle beforehand. Even better, users of the build are guaranteed to use the version of Gradle that the build was designed to work with. Of course, this is also great for continuous integration servers (i.e. servers that regularly build your project) as it requires no configuration on the server. 
{quote}
https://docs.gradle.org/current/userguide/gradle_wrapper.html

[~rvs] Is it acceptable?


was (Author: nhorn):
Regarding gradle-wrapper.jar, Gradle guide instructs to add it to the version control:
{quote}
The wrapper is something you should check into version control. By distributing the wrapper with your project, anyone can work with it without needing to install Gradle beforehand. Even better, users of the build are guaranteed to use the version of Gradle that the build was designed to work with. Of course, this is also great for continuous integration servers (i.e. servers that regularly build your project) as it requires no configuration on the server. 
{quote}
https://docs.gradle.org/current/userguide/gradle_wrapper.html


> clean pxf jars in source code
> -----------------------------
>
>                 Key: HAWQ-185
>                 URL: https://issues.apache.org/jira/browse/HAWQ-185
>             Project: Apache HAWQ
>          Issue Type: Bug
>          Components: PXF
>            Reporter: Lei Chang
>            Assignee: Noa Horn
>             Fix For: 2.0.0-beta-incubating
>
>
> From Roman's scan, some jar and .classes should be cleaned.
>    * anythings that's *.tar.gz
>    * anything that's a dependency jar
>    * ./pxf/gradle/wrapper/gradle-wrapper.jar
>    * ./src/test/regress/data/pxf/*.class
>    * ./src/test/regress/data/pxf/*.class



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)