[GitHub] [spark] holdenk commented on a change in pull request #35763: [SPARK-38433][BUILD] change the shell code style with shellcheck

[GitBox <gi...@apache.org>]

holdenk commented on a change in pull request #35763:
URL: https://github.com/apache/spark/pull/35763#discussion_r828319101



##########
File path: build/sbt-launch-lib.bash
##########
@@ -186,7 +186,7 @@ run() {
     ${SBT_OPTS:-$default_sbt_opts} \
     $(get_mem_opts $sbt_mem) \
     ${java_opts} \
-    ${java_args[@]} \
+    "${java_args[@]}" \

Review comment:
       I think this is ok, my one concern would be someone _might_ be depending on the shell expansion here for something like class path but since this is a build only tool I think that's an OK risk to take given the tradeoffs.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org