You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by sgrebnov <gi...@git.apache.org> on 2014/06/18 15:03:12 UTC

[GitHub] cordova-lib pull request: CB-6970 Share win project files manipula...

GitHub user sgrebnov opened a pull request:

    https://github.com/apache/cordova-lib/pull/32

    CB-6970 Share win project files manipulation code between cordova and plugman

    https://issues.apache.org/jira/browse/CB-6970
    
    1. Shared csproj and jsproj classes
    2. Updated code to use those classes instead of manual manipulation
    3. Updated removeSourceFile method to support regexp as parameter (ability to remove batch files or all files from specific folder).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-lib CB-6970

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/32.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #32
    
----
commit 09759f285e698e16746304f1f6d074a4cc019008
Author: sgrebnov <v-...@microsoft.com>
Date:   2014-06-18T12:58:20Z

    CB-6970 Share win project files manipulation code between cordova and plugman

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-lib pull request: CB-6970 Share win project files manipula...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-lib/pull/32


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-lib pull request: CB-6970 Share win project files manipula...

Posted by kamrik <gi...@git.apache.org>.
Github user kamrik commented on the pull request:

    https://github.com/apache/cordova-lib/pull/32#issuecomment-46496437
  
    Thanks! This looks much cleaner.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---