[GitHub] [pulsar] jerrypeng commented on a change in pull request #10057: Implement GenericObject - Allow GenericRecord to wrap any Java Object

[GitBox <gi...@apache.org>]

jerrypeng commented on a change in pull request #10057:
URL: https://github.com/apache/pulsar/pull/10057#discussion_r607403128



##########
File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/schema/GenericObject.java
##########
@@ -0,0 +1,50 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.client.api.schema;
+
+import org.apache.pulsar.common.schema.SchemaType;
+
+/**
+ * This is an abstraction over the logical value that is store into a Message.
+ * Pulsar decodes the payload of the Message using the Schema that is configured for the topic.
+ */
+public interface GenericObject {

Review comment:
       Is this interface suppose to be used as a schema type for producers or consumers, .e.g. Consumer<GenericObject> ? If so, can you write some tests that has consumers / producers that uses this new type of Schema?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org