You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "zhoulii (via GitHub)" <gi...@apache.org> on 2025/07/15 03:17:55 UTC
[PR] [flink] fix that AppendBypassCoordinateOperator does not generate com… [paimon]
zhoulii opened a new pull request, #5897:
URL: https://github.com/apache/paimon/pull/5897
…paction tasks.
<!-- Please specify the module before the PR name: [core] ... or [flink] ... -->
### Purpose
<!-- Linking this pull request to the issue -->
Linked issue: close #5896
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [flink] fix that AppendBypassCoordinateOperator does not generate compaction tasks. [paimon]
Posted by "zhoulii (via GitHub)" <gi...@apache.org>.
zhoulii commented on code in PR #5897:
URL: https://github.com/apache/paimon/pull/5897#discussion_r2206496507
##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/source/AppendBypassCoordinateOperator.java:
##########
@@ -85,10 +87,15 @@ public void open() throws Exception {
private void asyncPlan(AppendCompactCoordinator coordinator) {
while (compactTasks.size() < MAX_PENDING_TASKS) {
- List<AppendCompactTask> tasks = coordinator.run();
- compactTasks.addAll(tasks);
- if (tasks.isEmpty()) {
- break;
+ try {
+ List<AppendCompactTask> tasks = coordinator.run();
+ compactTasks.addAll(tasks);
+ if (tasks.isEmpty()) {
+ break;
+ }
+ } catch (Throwable t) {
+ LOG.error("Fatal exception happened when generating compaction tasks.", t);
+ this.throwable = t;
Review Comment:
> We should return here?
fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [flink] fix that AppendBypassCoordinateOperator does not generate compaction tasks. [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #5897:
URL: https://github.com/apache/paimon/pull/5897
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [flink] fix that AppendBypassCoordinateOperator does not generate compaction tasks. [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #5897:
URL: https://github.com/apache/paimon/pull/5897#discussion_r2206387196
##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/source/AppendBypassCoordinateOperator.java:
##########
@@ -85,10 +87,15 @@ public void open() throws Exception {
private void asyncPlan(AppendCompactCoordinator coordinator) {
while (compactTasks.size() < MAX_PENDING_TASKS) {
- List<AppendCompactTask> tasks = coordinator.run();
- compactTasks.addAll(tasks);
- if (tasks.isEmpty()) {
- break;
+ try {
+ List<AppendCompactTask> tasks = coordinator.run();
+ compactTasks.addAll(tasks);
+ if (tasks.isEmpty()) {
+ break;
+ }
+ } catch (Throwable t) {
+ LOG.error("Fatal exception happened when generating compaction tasks.", t);
+ this.throwable = t;
Review Comment:
We should return here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org