You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/12 03:04:51 UTC
[GitHub] [flink-table-store] SteNicholas opened a new pull request, #209: [FLINK-27103] Don't store redundant primary key fields
SteNicholas opened a new pull request, #209:
URL: https://github.com/apache/flink-table-store/pull/209
`ChangelogWithKeyFileStoreTable` currently stores the primary key redundantly in the file, which could directly use the primary key field in the original fields to avoid redundant storage.
**The brief change log**
- The `primaryKey` of `SinkRecord` is set to null for `ChangelogWithKeyFileStoreTable` and `KeyValueSerializer` reads the primary key from the value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #209: [FLINK-27103] Don't store redundant primary key fields
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on code in PR #209:
URL: https://github.com/apache/flink-table-store/pull/209#discussion_r918515556
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/KeyValueSerializer.java:
##########
@@ -45,6 +49,13 @@ public class KeyValueSerializer extends ObjectSerializer<KeyValue> {
private final OffsetRowData reusedValue;
private final KeyValue reusedKv;
+ private TableSchema tableSchema;
+
+ public KeyValueSerializer(RowType keyType, RowType valueType, TableSchema tableSchema) {
Review Comment:
I think we can introduce a special deserializer for `ColumnarRowIterator`.
After getting `VectorizedColumnBatch` from `ColumnarRowData`. We can get `ColumnVector[]`. Then, we can do our projection to produce key and value for `KeyValue`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] SteNicholas closed pull request #209: [FLINK-27103] Don't store redundant primary key fields
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas closed pull request #209: [FLINK-27103] Don't store redundant primary key fields
URL: https://github.com/apache/flink-table-store/pull/209
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org