You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Andrew Kennedy (JIRA)" <ji...@apache.org> on 2011/03/01 13:50:37 UTC
[jira] Created: (QPID-3095) AMQBrokerDetails equals() and
hashCode() methods do adhere to contract
AMQBrokerDetails equals() and hashCode() methods do adhere to contract
----------------------------------------------------------------------
Key: QPID-3095
URL: https://issues.apache.org/jira/browse/QPID-3095
Project: Qpid
Issue Type: Bug
Components: Java Client
Affects Versions: 0.9
Reporter: Andrew Kennedy
Priority: Minor
The AMQBrokerDetails object has an equals and a hashCode implementation that are not compatible. Equality uses case-insensitive comparisons and also compares SSL status, whereas the hashCode is calculated using the provided values and does not include SSL details. The contract for hashCode is given here:
http://download.oracle.com/javase/6/docs/api/java/lang/Object.html#hashCode%28%29
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3095) AMQBrokerDetails equals() and
hashCode() methods do not adhere to contract
Posted by "Rob Godfrey (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rob Godfrey updated QPID-3095:
------------------------------
Status: Ready To Review (was: In Progress)
> AMQBrokerDetails equals() and hashCode() methods do not adhere to contract
> --------------------------------------------------------------------------
>
> Key: QPID-3095
> URL: https://issues.apache.org/jira/browse/QPID-3095
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: 0.9
> Reporter: Andrew Kennedy
> Assignee: Rob Godfrey
> Priority: Minor
> Fix For: 0.15
>
>
> The AMQBrokerDetails object has an equals and a hashCode implementation that are not compatible. Equality uses case-insensitive comparisons and also compares SSL status, whereas the hashCode is calculated using the provided values and does not include SSL details. The contract for hashCode is given here:
> http://download.oracle.com/javase/6/docs/api/java/lang/Object.html#hashCode%28%29
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Assigned] (QPID-3095) AMQBrokerDetails equals() and
hashCode() methods do not adhere to contract
Posted by "Rob Godfrey (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rob Godfrey reassigned QPID-3095:
---------------------------------
Assignee: Robbie Gemmell (was: Rob Godfrey)
Can you review this trivial change please Robbie?
> AMQBrokerDetails equals() and hashCode() methods do not adhere to contract
> --------------------------------------------------------------------------
>
> Key: QPID-3095
> URL: https://issues.apache.org/jira/browse/QPID-3095
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: 0.9
> Reporter: Andrew Kennedy
> Assignee: Robbie Gemmell
> Priority: Minor
> Fix For: 0.15
>
>
> The AMQBrokerDetails object has an equals and a hashCode implementation that are not compatible. Equality uses case-insensitive comparisons and also compares SSL status, whereas the hashCode is calculated using the provided values and does not include SSL details. The contract for hashCode is given here:
> http://download.oracle.com/javase/6/docs/api/java/lang/Object.html#hashCode%28%29
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Resolved] (QPID-3095) AMQBrokerDetails equals() and
hashCode() methods do not adhere to contract
Posted by "Robbie Gemmell (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell resolved QPID-3095.
----------------------------------
Resolution: Fixed
Looks ok to me.
> AMQBrokerDetails equals() and hashCode() methods do not adhere to contract
> --------------------------------------------------------------------------
>
> Key: QPID-3095
> URL: https://issues.apache.org/jira/browse/QPID-3095
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: 0.9
> Reporter: Andrew Kennedy
> Assignee: Robbie Gemmell
> Priority: Minor
> Fix For: 0.15
>
>
> The AMQBrokerDetails object has an equals and a hashCode implementation that are not compatible. Equality uses case-insensitive comparisons and also compares SSL status, whereas the hashCode is calculated using the provided values and does not include SSL details. The contract for hashCode is given here:
> http://download.oracle.com/javase/6/docs/api/java/lang/Object.html#hashCode%28%29
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3095) AMQBrokerDetails equals() and
hashCode() methods do not adhere to contract
Posted by "Rob Godfrey (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rob Godfrey updated QPID-3095:
------------------------------
Fix Version/s: 0.15
Assignee: Rob Godfrey
> AMQBrokerDetails equals() and hashCode() methods do not adhere to contract
> --------------------------------------------------------------------------
>
> Key: QPID-3095
> URL: https://issues.apache.org/jira/browse/QPID-3095
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: 0.9
> Reporter: Andrew Kennedy
> Assignee: Rob Godfrey
> Priority: Minor
> Fix For: 0.15
>
>
> The AMQBrokerDetails object has an equals and a hashCode implementation that are not compatible. Equality uses case-insensitive comparisons and also compares SSL status, whereas the hashCode is calculated using the provided values and does not include SSL details. The contract for hashCode is given here:
> http://download.oracle.com/javase/6/docs/api/java/lang/Object.html#hashCode%28%29
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org