You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "lincoln-lil (via GitHub)" <gi...@apache.org> on 2023/03/24 12:22:26 UTC

[GitHub] [flink] lincoln-lil opened a new pull request, #22268: [FLINK-30897][tests]Avoid timeouts in JUnit tests

lincoln-lil opened a new pull request, #22268:
URL: https://github.com/apache/flink/pull/22268

   ## What is the purpose of the change
   Due to our [testing guideline](https://flink.apache.org/contributing/code-style-and-quality-common.html#avoid-timeouts-in-junit-tests), we should 'Avoid timeouts in JUnit tests' but rather depend on the global timeout in Azure. There're 10 itcases throughout the project that use the 'Timeout Rule' and 22 tests use the 'Deadline' to set local timeouts. 
   This is a best effortly removal for these timeout rule and local deadline timeout usages in related tests.
   
   ## Brief change log
   remove timeout rule and local deadline timeout the logic in related tests
   
   ## Verifying this change
   existing cases
   
   ## Does this pull request potentially affect one of the following parts:
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
     - The serializers: (no )
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
     - Does this pull request introduce a new feature? (no)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] flinkbot commented on pull request #22268: [FLINK-30897][tests]Avoid timeouts in JUnit tests

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #22268:
URL: https://github.com/apache/flink/pull/22268#issuecomment-1482725972

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b039fa180db0bc408aef34fbe6bb056185d8f95e",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "b039fa180db0bc408aef34fbe6bb056185d8f95e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b039fa180db0bc408aef34fbe6bb056185d8f95e UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org