You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Ignasi Barrera <no...@github.com> on 2017/11/29 14:13:19 UTC
[jclouds/jclouds] Fix GCE live tests (#1163)
Fixes all Google Compute Engine Live tests: :muscle:
```bash
Tests run: 179, Failures: 0, Errors: 0, Skipped: 8
Total time: 01:04 h (Wall Clock)
```
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1163
-- Commit Summary --
* Fix GCE live tests
-- File Changes --
M providers/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/functions/ResetWindowsPassword.java (146)
M providers/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/strategy/CreateNodesWithGroupEncodedIntoNameThenAddToSet.java (42)
M providers/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/Image.java (2)
M providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/compute/functions/ResetWindowsPasswordTest.java (5)
M providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/AddressApiLiveTest.java (2)
M providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/BackendServiceApiLiveTest.java (2)
M providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/DiskApiLiveTest.java (2)
M providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/FirewallApiLiveTest.java (2)
M providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/ForwardingRuleApiLiveTest.java (2)
M providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/GlobalForwardingRuleApiLiveTest.java (2)
M providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/InstanceApiLiveTest.java (2)
M providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/InstanceApiWindowsLiveTest.java (2)
M providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/NetworkApiLiveTest.java (2)
M providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/ProjectApiLiveTest.java (2)
M providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/RouteApiLiveTest.java (2)
M providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/SnapshotApiLiveTest.java (2)
M providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/TargetPoolApiLiveTest.java (2)
M providers/google-compute-engine/src/test/resources/logback-test.xml (2)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/1163.patch
https://github.com/jclouds/jclouds/pull/1163.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1163
Re: [jclouds/jclouds] Fix GCE live tests (#1163)
Posted by Ignasi Barrera <no...@github.com>.
Yes, same Jenkins plugin bug :(
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1163#issuecomment-347880334
Re: [jclouds/jclouds] Fix GCE live tests (#1163)
Posted by Ignasi Barrera <no...@github.com>.
I've upgraded the plugins and it should work now: rebuild please!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1163#issuecomment-347889370
Re: [jclouds/jclouds] Fix GCE live tests (#1163)
Posted by Ignasi Barrera <no...@github.com>.
Closed #1163.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1163#event-1365285222
Re: [jclouds/jclouds] Fix GCE live tests (#1163)
Posted by Ignasi Barrera <no...@github.com>.
merged to [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/715994b1) and [2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/b0fa8abb).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1163#issuecomment-348140330
Re: [jclouds/jclouds] Fix GCE live tests (#1163)
Posted by Andrea Turli <no...@github.com>.
andreaturli approved this pull request.
only a minor comment, lgtm
thanks @nacx
> + filter(transform(contentEntries, deserializeSerialOutput(json)), notNull()), HasEncryptedPassword)
+ .transform(ExtractEncryptedPassword);
+
+ if (retrievedPassword.isPresent()) {
+ encryptedPassword.set(retrievedPassword.get());
+ }
+
+ return retrievedPassword.isPresent();
+ }
+ // Notice that timeoutDuration should be less than EXPIRE_DURATION
+ }, 10 * 60, 30, TimeUnit.SECONDS).apply(instance.get());
+
+ if (passwordRetrieved) {
+ return decryptPassword(encryptedPassword.get(), keys);
+ } else {
+ throw new IllegalStateException("Did not find the encrypted password in the serial port output");
should we also logged here?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1163#pullrequestreview-79918328
Re: [jclouds/jclouds] Fix GCE live tests (#1163)
Posted by Ignasi Barrera <no...@github.com>.
nacx commented on this pull request.
> + filter(transform(contentEntries, deserializeSerialOutput(json)), notNull()), HasEncryptedPassword)
+ .transform(ExtractEncryptedPassword);
+
+ if (retrievedPassword.isPresent()) {
+ encryptedPassword.set(retrievedPassword.get());
+ }
+
+ return retrievedPassword.isPresent();
+ }
+ // Notice that timeoutDuration should be less than EXPIRE_DURATION
+ }, 10 * 60, 30, TimeUnit.SECONDS).apply(instance.get());
+
+ if (passwordRetrieved) {
+ return decryptPassword(encryptedPassword.get(), keys);
+ } else {
+ throw new IllegalStateException("Did not find the encrypted password in the serial port output");
Why not. I'll add in another commit!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1163#discussion_r154030646
Re: [jclouds/jclouds] Fix GCE live tests (#1163)
Posted by Andrea Turli <no...@github.com>.
is the builder failure related?
rebuild please
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1163#issuecomment-347878150