You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Likitha Shetty <li...@citrix.com> on 2013/05/01 12:39:07 UTC
[MERGE] Dedicate guest vlan ranges to account
Hi all,
I would like to merge the feature Dedicate Guest VLAN range to master.
Jira ticket - https://issues.apache.org/jira/browse/CLOUDSTACK-704
FS - https://cwiki.apache.org/confluence/display/CLOUDSTACK/FS-+Dedicate+Guest+VLANs+per+tenant
Branch - dedicate-guest-vlan-ranges_2 (was developed in branch dedicate-guest-vlan-ranges)
Unit tests - Unit tests for the new API's can be found at server/test/com/cloud/network/DedicateGuestVlanRangesTest.java
Integration tests - Python tests can be found be found at test/integration/smoke/test_guest_vlan_range.py
Rebased the branch with master - Commit id: 807ad0a39ab272a4af2de3156b0b367570acccea
RAT - RAT build is successful and no new dependencies introduced
Thanks,
Likitha
Re: [MERGE] Dedicate guest vlan ranges to account
Posted by Prasanna Santhanam <ts...@apache.org>.
On Wed, May 08, 2013 at 06:10:11AM +0000, Likitha Shetty wrote:
> Prasanna, fixed the error.
>
> About the API naming of commands related to guest vlan range dedication, the API names were chosen to be consistent with the commands related to dedication of other resources (Host, Pod, Cluster and Zone - https://reviews.apache.org/r/10797/ ).
> In fact I was thinking of renaming the commands related to Public Ip Ranges dedication to :
> dedicatePublicIpRange
> releaseDedicatedPublicIpRange
>
> Since we are operating on a dedicated resource isn't it more fitting?
>
Changing the publicIpRange related APIs is okay. I'm fine with that.
--
Prasanna.,
------------------------
Powered by BigRock.com
RE: [MERGE] Dedicate guest vlan ranges to account
Posted by Likitha Shetty <li...@citrix.com>.
Prasanna, fixed the error.
About the API naming of commands related to guest vlan range dedication, the API names were chosen to be consistent with the commands related to dedication of other resources (Host, Pod, Cluster and Zone - https://reviews.apache.org/r/10797/ ).
In fact I was thinking of renaming the commands related to Public Ip Ranges dedication to :
dedicatePublicIpRange
releaseDedicatedPublicIpRange
Since we are operating on a dedicated resource isn't it more fitting?
Thank you,
Likitha
-----Original Message-----
>From: Prasanna Santhanam [mailto:tsp@apache.org]
>Sent: Tuesday, May 07, 2013 3:37 PM
>To: dev@cloudstack.apache.org
>Subject: Re: [MERGE] Dedicate guest vlan ranges to account
>
>On Mon, May 06, 2013 at 08:52:38AM +0000, Likitha Shetty wrote:
>> Thanks for reviewing.
>> Merged in to master - c8d843241e144288300c1912a25b201e010bb7a0.
>>
>
>I tried to run your test but looks like the AccessChecks weren't in place for your
>APIs. Since these are admin (?) APIs I've put them into commands.properties.in
>with the admin mask. The APIs then are discovered successfully by the server.
>But the test fails as shown
>below:
>
>~/workspace/cloudstack/incubator-cloudstack(branch:master*) » nosetests --
>with-marvin --marvin-config=setup/dev/advanced.cfg
>test/integration/smoke/test_guest_vlan_range.py --load Test guest vlan range
>dedication ... ERROR
>
>=================================================================
>=====
>ERROR: Test guest vlan range dedication
>----------------------------------------------------------------------
>Traceback (most recent call last):
> File "/Users/tsp/workspace/cloudstack/incubator-
>cloudstack/test/integration/smoke/test_guest_vlan_range.py", line 155, in
>test_dedicateGuestVlanRange
> id=dedicate_guest_vlan_range_response.id
> File "/Library/Python/2.7/site-packages/marvin/integration/lib/base.py", line
>2205, in listDedicated
> return map(lambda pn : PhysicalNetwork(pn.__dict__),
>apiclient.listDedicatedGuestVlanRanges(cmd))
> File "/Library/Python/2.7/site-
>packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 819, in
>listDedicatedGuestVlanRanges
> response = self.connection.marvin_request(command,
>response_type=response, method=method)
> File "/Library/Python/2.7/site-packages/marvin/cloudstackConnection.py", line
>215, in marvin_request
> response = jsonHelper.getResultObj(response.json(), response_type)
> File "/Library/Python/2.7/site-packages/marvin/jsonHelper.py", line 128, in
>getResultObj
> raise
>cloudstackException.cloudstackAPIException(responseName.replace("response",
>""), errMsg)
>cloudstackAPIException: Execute cmd: listdedicatedguestvlanranges failed, due
>to: errorCode: 431, errorText:Unable to execute API command
>listdedicatedguestvlanranges due to invalid value. Invalid parameter id
>value=c6fe7bf1-adb1-4423-8ac9-6ea6febea147 due to incorrect long value
>format, or entity does not exist or due to incorrect parameter annotation for the
>field in api cmd class.
>
>This looks like an annotation/type error in the field for id. Can you please take a
>look?
>
>
>Also, I'm not sure if the naming can be made less verbose for the dedicateXxx
>APIs.
>
>For public IP dedication we simply call:
>dedicatePublicIpRange
>releasePublicIpRange
>listVlanIpRanges (legacy)
>
>but for guestVlan dedication we have:
>
>dedicateGuestVlanRange
>releaseDedicatedGuestVlanRange (releaseGuestVlanRange?)
>listDedicatedGuestVlanRanges (listGuestVlanRanges? &account=<guest>
>&domainid=<ROOT>)
>
>I'm purely looking at naming only, there's probably a reason why these are
>named so.
>
>--
>Prasanna.,
>
>------------------------
>Powered by BigRock.com
Re: [MERGE] Dedicate guest vlan ranges to account
Posted by Prasanna Santhanam <ts...@apache.org>.
On Mon, May 06, 2013 at 08:52:38AM +0000, Likitha Shetty wrote:
> Thanks for reviewing.
> Merged in to master - c8d843241e144288300c1912a25b201e010bb7a0.
>
I tried to run your test but looks like the AccessChecks weren't in
place for your APIs. Since these are admin (?) APIs I've put them into
commands.properties.in with the admin mask. The APIs then are
discovered successfully by the server. But the test fails as shown
below:
~/workspace/cloudstack/incubator-cloudstack(branch:master*) » nosetests --with-marvin --marvin-config=setup/dev/advanced.cfg test/integration/smoke/test_guest_vlan_range.py --load
Test guest vlan range dedication ... ERROR
======================================================================
ERROR: Test guest vlan range dedication
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/tsp/workspace/cloudstack/incubator-cloudstack/test/integration/smoke/test_guest_vlan_range.py", line 155, in test_dedicateGuestVlanRange
id=dedicate_guest_vlan_range_response.id
File "/Library/Python/2.7/site-packages/marvin/integration/lib/base.py", line 2205, in listDedicated
return map(lambda pn : PhysicalNetwork(pn.__dict__), apiclient.listDedicatedGuestVlanRanges(cmd))
File "/Library/Python/2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 819, in listDedicatedGuestVlanRanges
response = self.connection.marvin_request(command, response_type=response, method=method)
File "/Library/Python/2.7/site-packages/marvin/cloudstackConnection.py", line 215, in marvin_request
response = jsonHelper.getResultObj(response.json(), response_type)
File "/Library/Python/2.7/site-packages/marvin/jsonHelper.py", line 128, in getResultObj
raise cloudstackException.cloudstackAPIException(responseName.replace("response", ""), errMsg)
cloudstackAPIException: Execute cmd: listdedicatedguestvlanranges failed, due to: errorCode: 431, errorText:Unable to execute API command listdedicatedguestvlanranges due to invalid value. Invalid parameter id value=c6fe7bf1-adb1-4423-8ac9-6ea6febea147 due to incorrect long value format, or entity does not exist or due to incorrect parameter annotation for the field in api cmd class.
This looks like an annotation/type error in the field for id. Can you please take a look?
Also, I'm not sure if the naming can be made less verbose for the dedicateXxx APIs.
For public IP dedication we simply call:
dedicatePublicIpRange
releasePublicIpRange
listVlanIpRanges (legacy)
but for guestVlan dedication we have:
dedicateGuestVlanRange
releaseDedicatedGuestVlanRange (releaseGuestVlanRange?)
listDedicatedGuestVlanRanges (listGuestVlanRanges? &account=<guest> &domainid=<ROOT>)
I'm purely looking at naming only, there's probably a reason why these are named so.
--
Prasanna.,
------------------------
Powered by BigRock.com
RE: [MERGE] Dedicate guest vlan ranges to account
Posted by Likitha Shetty <li...@citrix.com>.
Thanks for reviewing.
Merged in to master - c8d843241e144288300c1912a25b201e010bb7a0.
Thank you,
Likitha
>-----Original Message-----
>From: Prasanna Santhanam [mailto:tsp@apache.org]
>Sent: Monday, May 06, 2013 12:52 PM
>To: dev@cloudstack.apache.org
>Subject: Re: [MERGE] Dedicate guest vlan ranges to account
>
>+1 - tests look good.
>
>On Thu, May 02, 2013 at 12:28:09PM +0000, Hugo Trippaers wrote:
>> Looks good to me
>>
>> +1 to merge
>>
>> Cheers,
>>
>> Hugo
>>
>> > -----Original Message-----
>> > From: Likitha Shetty [mailto:likitha.shetty@citrix.com]
>> > Sent: Thursday, May 02, 2013 12:28 PM
>> > To: dev@cloudstack.apache.org
>> > Subject: RE: [MERGE] Dedicate guest vlan ranges to account
>> >
>> > Updated branch dedicate-guest-vlan-ranges_2 with the suggested changes.
>> >
>> > Thanks,
>> > Likitha
>> >
>> > >-----Original Message-----
>> > >From: Likitha Shetty [mailto:likitha.shetty@citrix.com]
>> > >Sent: Thursday, May 02, 2013 10:58 AM
>> > >To: dev@cloudstack.apache.org
>> > >Subject: RE: [MERGE] Dedicate guest vlan ranges to account
>> > >
>> > >Thanks for taking a look Hugo.
>> > >I will update the branch with the fixes.
>> > >
>> > >Thanks,
>> > >Likitha
>> > >
>> > >>-----Original Message-----
>> > >>From: Hugo Trippaers [mailto:HTrippaers@schubergphilis.com]
>> > >>Sent: Wednesday, May 01, 2013 5:07 PM
>> > >>To: dev@cloudstack.apache.org
>> > >>Subject: RE: [MERGE] Dedicate guest vlan ranges to account
>> > >>
>> > >>Likitha,
>> > >>
>> > >>Couple of remarks on the merge request:
>> > >>
>> > >>I think the calls you added to the system should fail with an
>> > >>informative error message if the physical network does not have
>> > >>the isolation type VLAN, as your code is only usable in networks
>> > >>with VLAN style
>> > >isolation.
>> > >>
>> > >>Can you double check your formatting and line endings of the new files?
>> > >>For example DedicateGuestVlanRangeCmd.java seems to have windows
>> > style
>> > >>line endings.
>> > >>
>> > >> I also noticed some files with changed permissions (from 644 to
>> > >>755) (in one case without any changes in the file itself). Can
>> > >>you fix that? Permissions should be 644 for java code.
>> > >>
>> > >>Cheers,
>> > >>
>> > >>Hugo
>> > >>
>> > >>> -----Original Message-----
>> > >>> From: Likitha Shetty [mailto:likitha.shetty@citrix.com]
>> > >>> Sent: Wednesday, May 01, 2013 12:39 PM
>> > >>> To: dev@cloudstack.apache.org
>> > >>> Subject: [MERGE] Dedicate guest vlan ranges to account
>> > >>>
>> > >>> Hi all,
>> > >>>
>> > >>> I would like to merge the feature Dedicate Guest VLAN range to master.
>> > >>>
>> > >>> Jira ticket -
>> > >>> https://issues.apache.org/jira/browse/CLOUDSTACK-704
>> > >>> FS - https://cwiki.apache.org/confluence/display/CLOUDSTACK/FS-
>> > >>> +Dedicate+Guest+VLANs+per+tenant
>> > >>> Branch - dedicate-guest-vlan-ranges_2 (was developed in branch
>> > >>> dedicate-
>> > >>> guest-vlan-ranges) Unit tests - Unit tests for the new API's
>> > >>> can be found at
>> > >>> server/test/com/cloud/network/DedicateGuestVlanRangesTest.java
>> > >>> Integration tests - Python tests can be found be found at
>> > >>> test/integration/smoke/test_guest_vlan_range.py
>> > >>> Rebased the branch with master - Commit id:
>> > >>> 807ad0a39ab272a4af2de3156b0b367570acccea
>> > >>> RAT - RAT build is successful and no new dependencies introduced
>> > >>>
>> > >>> Thanks,
>> > >>> Likitha
>
>--
>Prasanna.,
>
>------------------------
>Powered by BigRock.com
Re: [MERGE] Dedicate guest vlan ranges to account
Posted by Prasanna Santhanam <ts...@apache.org>.
+1 - tests look good.
On Thu, May 02, 2013 at 12:28:09PM +0000, Hugo Trippaers wrote:
> Looks good to me
>
> +1 to merge
>
> Cheers,
>
> Hugo
>
> > -----Original Message-----
> > From: Likitha Shetty [mailto:likitha.shetty@citrix.com]
> > Sent: Thursday, May 02, 2013 12:28 PM
> > To: dev@cloudstack.apache.org
> > Subject: RE: [MERGE] Dedicate guest vlan ranges to account
> >
> > Updated branch dedicate-guest-vlan-ranges_2 with the suggested changes.
> >
> > Thanks,
> > Likitha
> >
> > >-----Original Message-----
> > >From: Likitha Shetty [mailto:likitha.shetty@citrix.com]
> > >Sent: Thursday, May 02, 2013 10:58 AM
> > >To: dev@cloudstack.apache.org
> > >Subject: RE: [MERGE] Dedicate guest vlan ranges to account
> > >
> > >Thanks for taking a look Hugo.
> > >I will update the branch with the fixes.
> > >
> > >Thanks,
> > >Likitha
> > >
> > >>-----Original Message-----
> > >>From: Hugo Trippaers [mailto:HTrippaers@schubergphilis.com]
> > >>Sent: Wednesday, May 01, 2013 5:07 PM
> > >>To: dev@cloudstack.apache.org
> > >>Subject: RE: [MERGE] Dedicate guest vlan ranges to account
> > >>
> > >>Likitha,
> > >>
> > >>Couple of remarks on the merge request:
> > >>
> > >>I think the calls you added to the system should fail with an
> > >>informative error message if the physical network does not have the
> > >>isolation type VLAN, as your code is only usable in networks with VLAN
> > >>style
> > >isolation.
> > >>
> > >>Can you double check your formatting and line endings of the new files?
> > >>For example DedicateGuestVlanRangeCmd.java seems to have windows
> > style
> > >>line endings.
> > >>
> > >> I also noticed some files with changed permissions (from 644 to 755)
> > >>(in one case without any changes in the file itself). Can you fix
> > >>that? Permissions should be 644 for java code.
> > >>
> > >>Cheers,
> > >>
> > >>Hugo
> > >>
> > >>> -----Original Message-----
> > >>> From: Likitha Shetty [mailto:likitha.shetty@citrix.com]
> > >>> Sent: Wednesday, May 01, 2013 12:39 PM
> > >>> To: dev@cloudstack.apache.org
> > >>> Subject: [MERGE] Dedicate guest vlan ranges to account
> > >>>
> > >>> Hi all,
> > >>>
> > >>> I would like to merge the feature Dedicate Guest VLAN range to master.
> > >>>
> > >>> Jira ticket - https://issues.apache.org/jira/browse/CLOUDSTACK-704
> > >>> FS - https://cwiki.apache.org/confluence/display/CLOUDSTACK/FS-
> > >>> +Dedicate+Guest+VLANs+per+tenant
> > >>> Branch - dedicate-guest-vlan-ranges_2 (was developed in branch
> > >>> dedicate-
> > >>> guest-vlan-ranges) Unit tests - Unit tests for the new API's can be
> > >>> found at
> > >>> server/test/com/cloud/network/DedicateGuestVlanRangesTest.java
> > >>> Integration tests - Python tests can be found be found at
> > >>> test/integration/smoke/test_guest_vlan_range.py
> > >>> Rebased the branch with master - Commit id:
> > >>> 807ad0a39ab272a4af2de3156b0b367570acccea
> > >>> RAT - RAT build is successful and no new dependencies introduced
> > >>>
> > >>> Thanks,
> > >>> Likitha
--
Prasanna.,
------------------------
Powered by BigRock.com
RE: [MERGE] Dedicate guest vlan ranges to account
Posted by Hugo Trippaers <HT...@schubergphilis.com>.
Looks good to me
+1 to merge
Cheers,
Hugo
> -----Original Message-----
> From: Likitha Shetty [mailto:likitha.shetty@citrix.com]
> Sent: Thursday, May 02, 2013 12:28 PM
> To: dev@cloudstack.apache.org
> Subject: RE: [MERGE] Dedicate guest vlan ranges to account
>
> Updated branch dedicate-guest-vlan-ranges_2 with the suggested changes.
>
> Thanks,
> Likitha
>
> >-----Original Message-----
> >From: Likitha Shetty [mailto:likitha.shetty@citrix.com]
> >Sent: Thursday, May 02, 2013 10:58 AM
> >To: dev@cloudstack.apache.org
> >Subject: RE: [MERGE] Dedicate guest vlan ranges to account
> >
> >Thanks for taking a look Hugo.
> >I will update the branch with the fixes.
> >
> >Thanks,
> >Likitha
> >
> >>-----Original Message-----
> >>From: Hugo Trippaers [mailto:HTrippaers@schubergphilis.com]
> >>Sent: Wednesday, May 01, 2013 5:07 PM
> >>To: dev@cloudstack.apache.org
> >>Subject: RE: [MERGE] Dedicate guest vlan ranges to account
> >>
> >>Likitha,
> >>
> >>Couple of remarks on the merge request:
> >>
> >>I think the calls you added to the system should fail with an
> >>informative error message if the physical network does not have the
> >>isolation type VLAN, as your code is only usable in networks with VLAN
> >>style
> >isolation.
> >>
> >>Can you double check your formatting and line endings of the new files?
> >>For example DedicateGuestVlanRangeCmd.java seems to have windows
> style
> >>line endings.
> >>
> >> I also noticed some files with changed permissions (from 644 to 755)
> >>(in one case without any changes in the file itself). Can you fix
> >>that? Permissions should be 644 for java code.
> >>
> >>Cheers,
> >>
> >>Hugo
> >>
> >>> -----Original Message-----
> >>> From: Likitha Shetty [mailto:likitha.shetty@citrix.com]
> >>> Sent: Wednesday, May 01, 2013 12:39 PM
> >>> To: dev@cloudstack.apache.org
> >>> Subject: [MERGE] Dedicate guest vlan ranges to account
> >>>
> >>> Hi all,
> >>>
> >>> I would like to merge the feature Dedicate Guest VLAN range to master.
> >>>
> >>> Jira ticket - https://issues.apache.org/jira/browse/CLOUDSTACK-704
> >>> FS - https://cwiki.apache.org/confluence/display/CLOUDSTACK/FS-
> >>> +Dedicate+Guest+VLANs+per+tenant
> >>> Branch - dedicate-guest-vlan-ranges_2 (was developed in branch
> >>> dedicate-
> >>> guest-vlan-ranges) Unit tests - Unit tests for the new API's can be
> >>> found at
> >>> server/test/com/cloud/network/DedicateGuestVlanRangesTest.java
> >>> Integration tests - Python tests can be found be found at
> >>> test/integration/smoke/test_guest_vlan_range.py
> >>> Rebased the branch with master - Commit id:
> >>> 807ad0a39ab272a4af2de3156b0b367570acccea
> >>> RAT - RAT build is successful and no new dependencies introduced
> >>>
> >>> Thanks,
> >>> Likitha
RE: [MERGE] Dedicate guest vlan ranges to account
Posted by Likitha Shetty <li...@citrix.com>.
Updated branch dedicate-guest-vlan-ranges_2 with the suggested changes.
Thanks,
Likitha
>-----Original Message-----
>From: Likitha Shetty [mailto:likitha.shetty@citrix.com]
>Sent: Thursday, May 02, 2013 10:58 AM
>To: dev@cloudstack.apache.org
>Subject: RE: [MERGE] Dedicate guest vlan ranges to account
>
>Thanks for taking a look Hugo.
>I will update the branch with the fixes.
>
>Thanks,
>Likitha
>
>>-----Original Message-----
>>From: Hugo Trippaers [mailto:HTrippaers@schubergphilis.com]
>>Sent: Wednesday, May 01, 2013 5:07 PM
>>To: dev@cloudstack.apache.org
>>Subject: RE: [MERGE] Dedicate guest vlan ranges to account
>>
>>Likitha,
>>
>>Couple of remarks on the merge request:
>>
>>I think the calls you added to the system should fail with an
>>informative error message if the physical network does not have the
>>isolation type VLAN, as your code is only usable in networks with VLAN style
>isolation.
>>
>>Can you double check your formatting and line endings of the new files?
>>For example DedicateGuestVlanRangeCmd.java seems to have windows style
>>line endings.
>>
>> I also noticed some files with changed permissions (from 644 to 755)
>>(in one case without any changes in the file itself). Can you fix
>>that? Permissions should be 644 for java code.
>>
>>Cheers,
>>
>>Hugo
>>
>>> -----Original Message-----
>>> From: Likitha Shetty [mailto:likitha.shetty@citrix.com]
>>> Sent: Wednesday, May 01, 2013 12:39 PM
>>> To: dev@cloudstack.apache.org
>>> Subject: [MERGE] Dedicate guest vlan ranges to account
>>>
>>> Hi all,
>>>
>>> I would like to merge the feature Dedicate Guest VLAN range to master.
>>>
>>> Jira ticket - https://issues.apache.org/jira/browse/CLOUDSTACK-704
>>> FS - https://cwiki.apache.org/confluence/display/CLOUDSTACK/FS-
>>> +Dedicate+Guest+VLANs+per+tenant
>>> Branch - dedicate-guest-vlan-ranges_2 (was developed in branch
>>> dedicate-
>>> guest-vlan-ranges) Unit tests - Unit tests for the new API's can be
>>> found at
>>> server/test/com/cloud/network/DedicateGuestVlanRangesTest.java
>>> Integration tests - Python tests can be found be found at
>>> test/integration/smoke/test_guest_vlan_range.py
>>> Rebased the branch with master - Commit id:
>>> 807ad0a39ab272a4af2de3156b0b367570acccea
>>> RAT - RAT build is successful and no new dependencies introduced
>>>
>>> Thanks,
>>> Likitha
RE: [MERGE] Dedicate guest vlan ranges to account
Posted by Likitha Shetty <li...@citrix.com>.
Thanks for taking a look Hugo.
I will update the branch with the fixes.
Thanks,
Likitha
>-----Original Message-----
>From: Hugo Trippaers [mailto:HTrippaers@schubergphilis.com]
>Sent: Wednesday, May 01, 2013 5:07 PM
>To: dev@cloudstack.apache.org
>Subject: RE: [MERGE] Dedicate guest vlan ranges to account
>
>Likitha,
>
>Couple of remarks on the merge request:
>
>I think the calls you added to the system should fail with an informative error
>message if the physical network does not have the isolation type VLAN, as your
>code is only usable in networks with VLAN style isolation.
>
>Can you double check your formatting and line endings of the new files? For
>example DedicateGuestVlanRangeCmd.java seems to have windows style line
>endings.
>
> I also noticed some files with changed permissions (from 644 to 755) (in one
>case without any changes in the file itself). Can you fix that? Permissions should
>be 644 for java code.
>
>Cheers,
>
>Hugo
>
>> -----Original Message-----
>> From: Likitha Shetty [mailto:likitha.shetty@citrix.com]
>> Sent: Wednesday, May 01, 2013 12:39 PM
>> To: dev@cloudstack.apache.org
>> Subject: [MERGE] Dedicate guest vlan ranges to account
>>
>> Hi all,
>>
>> I would like to merge the feature Dedicate Guest VLAN range to master.
>>
>> Jira ticket - https://issues.apache.org/jira/browse/CLOUDSTACK-704
>> FS - https://cwiki.apache.org/confluence/display/CLOUDSTACK/FS-
>> +Dedicate+Guest+VLANs+per+tenant
>> Branch - dedicate-guest-vlan-ranges_2 (was developed in branch
>> dedicate-
>> guest-vlan-ranges) Unit tests - Unit tests for the new API's can be
>> found at
>> server/test/com/cloud/network/DedicateGuestVlanRangesTest.java
>> Integration tests - Python tests can be found be found at
>> test/integration/smoke/test_guest_vlan_range.py
>> Rebased the branch with master - Commit id:
>> 807ad0a39ab272a4af2de3156b0b367570acccea
>> RAT - RAT build is successful and no new dependencies introduced
>>
>> Thanks,
>> Likitha
RE: [MERGE] Dedicate guest vlan ranges to account
Posted by Hugo Trippaers <HT...@schubergphilis.com>.
Likitha,
Couple of remarks on the merge request:
I think the calls you added to the system should fail with an informative error message if the physical network does not have the isolation type VLAN, as your code is only usable in networks with VLAN style isolation.
Can you double check your formatting and line endings of the new files? For example DedicateGuestVlanRangeCmd.java seems to have windows style line endings.
I also noticed some files with changed permissions (from 644 to 755) (in one case without any changes in the file itself). Can you fix that? Permissions should be 644 for java code.
Cheers,
Hugo
> -----Original Message-----
> From: Likitha Shetty [mailto:likitha.shetty@citrix.com]
> Sent: Wednesday, May 01, 2013 12:39 PM
> To: dev@cloudstack.apache.org
> Subject: [MERGE] Dedicate guest vlan ranges to account
>
> Hi all,
>
> I would like to merge the feature Dedicate Guest VLAN range to master.
>
> Jira ticket - https://issues.apache.org/jira/browse/CLOUDSTACK-704
> FS - https://cwiki.apache.org/confluence/display/CLOUDSTACK/FS-
> +Dedicate+Guest+VLANs+per+tenant
> Branch - dedicate-guest-vlan-ranges_2 (was developed in branch dedicate-
> guest-vlan-ranges) Unit tests - Unit tests for the new API's can be found at
> server/test/com/cloud/network/DedicateGuestVlanRangesTest.java
> Integration tests - Python tests can be found be found at
> test/integration/smoke/test_guest_vlan_range.py
> Rebased the branch with master - Commit id:
> 807ad0a39ab272a4af2de3156b0b367570acccea
> RAT - RAT build is successful and no new dependencies introduced
>
> Thanks,
> Likitha