You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jdo-dev@db.apache.org by "mboapache (via GitHub)" <gi...@apache.org> on 2026/08/30 16:18:16 UTC

[PR] Object identity construction (db-jdo)

mboapache opened a new pull request, #134:
URL: https://github.com/apache/db-jdo/pull/134

   Identity-key construction gated on an allowlist; Class.forName no longer initializes unvetted classes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscribe@db.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Object identity construction (db-jdo)

Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #134:
URL: https://github.com/apache/db-jdo/pull/134#issuecomment-5469834866

   ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=db-jdo&pullRequest=134) **Quality Gate passed**  
   Issues  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [1 New issue](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=134&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png '') [0 Accepted issues](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=134&issueStatuses=ACCEPTED)
   
   Measures  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=134&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=134&metric=new_coverage&view=list)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=134&metric=new_duplicated_lines_density&view=list)  
     
   <!-- sqra-placement-anchor -->
   [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=db-jdo&pullRequest=134)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscribe@db.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Object identity construction (db-jdo)

Posted by "mboapache (via GitHub)" <gi...@apache.org>.
mboapache commented on PR #134:
URL: https://github.com/apache/db-jdo/pull/134#issuecomment-5782074883

   I agree with Craig's commet. Altough it is a backward compatibility issue to remove support for arbitrary classes to be used as ObjectIdentity, I also think this is not a problem in practice. People will use classes like LongIdentity or StringIdentity or come up with their own ObjectId class and then there is no prblem.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscribe@db.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Object identity construction (db-jdo)

Posted by "clr-apache (via GitHub)" <gi...@apache.org>.
clr-apache commented on PR #134:
URL: https://github.com/apache/db-jdo/pull/134#issuecomment-5781415729

   I do not believe that we need a new constant to allow arbitrary classes to be used as ObjectIdentity.
   We can simplify this by allowing the standard identity classes that are shipped with JDO or a user-specified object identity class named in the metadata.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscribe@db.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Object identity construction (db-jdo)

Posted by "mboapache (via GitHub)" <gi...@apache.org>.
mboapache commented on PR #134:
URL: https://github.com/apache/db-jdo/pull/134#issuecomment-6298294802

   This pull request no longer relevant, superseeded by [PR# 142](https://github.com/apache/db-jdo/pull/142)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscribe@db.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Object identity construction (db-jdo)

Posted by "mboapache (via GitHub)" <gi...@apache.org>.
mboapache closed pull request #134: Object identity construction
URL: https://github.com/apache/db-jdo/pull/134


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscribe@db.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org