You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/07/09 03:42:02 UTC
[GitHub] [incubator-mxnet] ChaiBapchya opened a new pull request #18677: Migrate from private jetpack files to public
ChaiBapchya opened a new pull request #18677:
URL: https://github.com/apache/incubator-mxnet/pull/18677
## Description ##
Fixes #18637
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [x] Changes are complete (i.e. I finished coding on this PR)
- [x] All changes have test coverage:
- [x] Code is well-documented:
- [x] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
@leezu @ptrendx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18677: Migrate from private jetpack files to public
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18677:
URL: https://github.com/apache/incubator-mxnet/pull/18677#issuecomment-658991439
Undefined action detected.
Permissible actions are : run ci [all], run ci [job1, job2]
Example : @mxnet-bot run ci [all]
Example : @mxnet-bot run ci [centos-cpu, clang]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ChaiBapchya commented on pull request #18677: Migrate from private jetpack files to public
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on pull request #18677:
URL: https://github.com/apache/incubator-mxnet/pull/18677#issuecomment-656259253
> I will be working with @TristonC to get those other packages too.
@ptrendx any ETA on the same? thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ChaiBapchya commented on pull request #18677: Migrate from private jetpack files to public
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on pull request #18677:
URL: https://github.com/apache/incubator-mxnet/pull/18677#issuecomment-656287604
Thanks @ptrendx @leezu
I can confirm that pinning the cmake version resolves the issue: https://github.com/ChaiBapchya/incubator-mxnet/commit/18595b39418582697485b1eca55f83659bec3ed4
And running
```
ci/build.py --docker-registry mxnetci --platform jetson --docker-build-retries 3 --shm-size 500m /work/runtime_functions.sh build_jetson
```
Resolved the issue and it build perfectly.
Commented this on the Triston's cmake [upstream] issue : https://gitlab.kitware.com/cmake/cmake/-/issues/20826
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ChaiBapchya commented on pull request #18677: Migrate from private jetpack files to public
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on pull request #18677:
URL: https://github.com/apache/incubator-mxnet/pull/18677#issuecomment-658991603
@mxnet-label-bot add [pr-awaiting-review]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ChaiBapchya commented on pull request #18677: Migrate from private jetpack files to public
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on pull request #18677:
URL: https://github.com/apache/incubator-mxnet/pull/18677#issuecomment-658354091
Jetson pipeline error should be resolved by https://github.com/apache/incubator-mxnet/pull/18713
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ptrendx commented on pull request #18677: Migrate from private jetpack files to public
Posted by GitBox <gi...@apache.org>.
ptrendx commented on pull request #18677:
URL: https://github.com/apache/incubator-mxnet/pull/18677#issuecomment-656234288
@leezu I'm not a CMake expert unfortunately - the only thing I could give them is this Jetson build (you can take this Dockerfile, see that it does not produce `--ccbin` option for Ninja, and then install CMake 3.17.1 on top of it and redo cmake to see that this version does produce the correct option). I don't think this counts as minimal example :-(.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu merged pull request #18677: Migrate from private jetpack files to public
Posted by GitBox <gi...@apache.org>.
leezu merged pull request #18677:
URL: https://github.com/apache/incubator-mxnet/pull/18677
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #18677: Migrate from private jetpack files to public
Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #18677:
URL: https://github.com/apache/incubator-mxnet/pull/18677#issuecomment-656232317
@ptrendx could you help get a reproducible example to cmake so that the bug can be fixed upstream?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ChaiBapchya commented on pull request #18677: Migrate from private jetpack files to public
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on pull request #18677:
URL: https://github.com/apache/incubator-mxnet/pull/18677#issuecomment-658991400
@mxnet-bot add [pr-awaiting-review]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ptrendx commented on pull request #18677: Migrate from private jetpack files to public
Posted by GitBox <gi...@apache.org>.
ptrendx commented on pull request #18677:
URL: https://github.com/apache/incubator-mxnet/pull/18677#issuecomment-656197254
The error in the Jetson pipeline is due to what I believe is a bug in CMake 3.17.3 (https://gitlab.kitware.com/cmake/cmake/-/issues/20826), which results in not setting the host compiler for CUDA. Set the version of CMake to 3.17.1 or 3.17.2 (3.17.1 was the version in the previously cached docker container, which is why you did not see this failure earlier).
That said, please wait with merging this PR - those packages do not include cuDNN and TRT, which we would also like to have in order to enable proper cross compilation support for Jetson that includes every feature. I will be working with @tristonc to get those other packages too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18677: Migrate from private jetpack files to public
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18677:
URL: https://github.com/apache/incubator-mxnet/pull/18677#issuecomment-655880493
Hey @ChaiBapchya , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [windows-gpu, sanity, website, edge, centos-cpu, miscellaneous, windows-cpu, clang, centos-gpu, unix-cpu, unix-gpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ChaiBapchya edited a comment on pull request #18677: Migrate from private jetpack files to public
Posted by GitBox <gi...@apache.org>.
ChaiBapchya edited a comment on pull request #18677:
URL: https://github.com/apache/incubator-mxnet/pull/18677#issuecomment-656287604
Thanks @ptrendx @leezu
I can confirm that pinning the cmake version resolves the issue: https://github.com/ChaiBapchya/incubator-mxnet/commit/18595b39418582697485b1eca55f83659bec3ed4
Run
```
ci/build.py --docker-registry mxnetci --platform jetson --docker-build-retries 3 --shm-size 500m /work/runtime_functions.sh build_jetson
```
Build passes.
Commented this on the Triston's cmake [upstream] issue : https://gitlab.kitware.com/cmake/cmake/-/issues/20826
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ChaiBapchya commented on pull request #18677: Migrate from private jetpack files to public
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on pull request #18677:
URL: https://github.com/apache/incubator-mxnet/pull/18677#issuecomment-655880685
Once this is merged in master, I'll subsequently cherry-pick it into other branches which use private S3 buckets for Jetpack files
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org