You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "juliuszsompolski (via GitHub)" <gi...@apache.org> on 2023/07/18 10:23:08 UTC
[GitHub] [spark] juliuszsompolski opened a new pull request, #42060: [SPARK-43755][FOLLOWUP] Open `AdaptiveSparkPlanHelper.allChildren` instead of copying
juliuszsompolski opened a new pull request, #42060:
URL: https://github.com/apache/spark/pull/42060
### What changes were proposed in this pull request?
Minor refactor - make `AdaptiveSparkPlanHelper.allChildren` protected in place of private, so that we don't have to copy it over, risking that the two versions will get out of sync.
### Why are the changes needed?
Minor refactor.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] juliuszsompolski commented on pull request #42060: [SPARK-43755][FOLLOWUP] Open `AdaptiveSparkPlanHelper.allChildren` instead of copying
Posted by "juliuszsompolski (via GitHub)" <gi...@apache.org>.
juliuszsompolski commented on PR #42060:
URL: https://github.com/apache/spark/pull/42060#issuecomment-1639960406
cc @HyukjinKwon @xuanyuanking this is a tiny followup to code that got refactored in https://github.com/apache/spark/pull/41315. It could be considered for branch-3.5 to keep the two in sync?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #42060: [SPARK-43755][CONNECT][MINOR] Open `AdaptiveSparkPlanHelper.allChildren` instead of using copy in `MetricGenerator`
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #42060: [SPARK-43755][CONNECT][MINOR] Open `AdaptiveSparkPlanHelper.allChildren` instead of using copy in `MetricGenerator`
URL: https://github.com/apache/spark/pull/42060
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #42060: [SPARK-43755][CONNECT][MINOR] Open `AdaptiveSparkPlanHelper.allChildren` instead of using copy in `MetricGenerator`
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #42060:
URL: https://github.com/apache/spark/pull/42060#issuecomment-1641210891
Merged to master and branch-3.5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org