You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/08/12 08:11:27 UTC
[GitHub] [dubbo-go] whitekeyboard opened a new issue #710: initHystrixConfigProvider初始化错误
whitekeyboard opened a new issue #710:
URL: https://github.com/apache/dubbo-go/issues/710
<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks!
-->
**What happened**:
[dubbo-go/filter/filter_impl/hystrix_filter.go ]
func initHystrixConfigProvider() error {
if config.GetProviderConfig().FilterConf == nil {
return perrors.Errorf("no config for hystrix")
}
filterConfig := config.**GetConsumerConfig**().FilterConf.(map[interface{}]interface{})[HYSTRIX]
**What you expected to happen**:
如上，initHystrixConfigProvider函数初始化会出错，此处是否调用错误，initHystrixConfigProvider应该调用config.GetProviderConfig().FilterConf.(map[interface{}]interface{})[HYSTRIX]才对的吧
**How to reproduce it (as minimally and precisely as possible)**:
**Anything else we need to know?**:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] whitekeyboard commented on issue #710: initHystrixConfigProvider初始化错误
Posted by GitBox <gi...@apache.org>.
whitekeyboard commented on issue #710:
URL: https://github.com/apache/dubbo-go/issues/710#issuecomment-672771465
@hxmhlt as Provder ，init to cal;l initHystrixConfigProvider, and initHystrixConfigProvider to call **ConsumerConfig**, not to call **GetProviderConfig**?????
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] hxmhlt commented on issue #710: initHystrixConfigProvider初始化错误
Posted by GitBox <gi...@apache.org>.
hxmhlt commented on issue #710:
URL: https://github.com/apache/dubbo-go/issues/710#issuecomment-679799886
@YGrylls
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] whitekeyboard edited a comment on issue #710: initHystrixConfigProvider初始化错误
Posted by GitBox <gi...@apache.org>.
whitekeyboard edited a comment on issue #710:
URL: https://github.com/apache/dubbo-go/issues/710#issuecomment-672771465
@hxmhlt as Provder ，init to call initHystrixConfigProvider, and initHystrixConfigProvider to call **ConsumerConfig**, not to call **GetProviderConfig**?????
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] hxmhlt commented on issue #710: initHystrixConfigProvider初始化错误
Posted by GitBox <gi...@apache.org>.
hxmhlt commented on issue #710:
URL: https://github.com/apache/dubbo-go/issues/710#issuecomment-679801178
Is this a bug ? @YGrylls
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] zouyx commented on issue #710: initHystrixConfigProvider初始化错误
Posted by GitBox <gi...@apache.org>.
zouyx commented on issue #710:
URL: https://github.com/apache/dubbo-go/issues/710#issuecomment-681316225
#666
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks closed issue #710: initHystrixConfigProvider初始化错误
Posted by GitBox <gi...@apache.org>.
AlexStocks closed issue #710:
URL: https://github.com/apache/dubbo-go/issues/710
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] whitekeyboard commented on issue #710: initHystrixConfigProvider初始化错误
Posted by GitBox <gi...@apache.org>.
whitekeyboard commented on issue #710:
URL: https://github.com/apache/dubbo-go/issues/710#issuecomment-672764875
@AlexStocks just a normal developer, and find this bug , is it a BUG???
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] whitekeyboard edited a comment on issue #710: initHystrixConfigProvider初始化错误
Posted by GitBox <gi...@apache.org>.
whitekeyboard edited a comment on issue #710:
URL: https://github.com/apache/dubbo-go/issues/710#issuecomment-672771465
@hxmhlt as Provder ，init to call initHystrixConfigProvider, and initHystrixConfigProvider to call **GetConsumerConfig**, not to call **GetProviderConfig**?????
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] whitekeyboard commented on issue #710: initHystrixConfigProvider初始化错误
Posted by GitBox <gi...@apache.org>.
whitekeyboard commented on issue #710:
URL: https://github.com/apache/dubbo-go/issues/710#issuecomment-675806112
@AlexStocks @hxmhlt 此处初始化提供者（initHystrixConfigProvider），实现中为啥要获取消费者的配置，（config.GetConsumerConfig()）此处个人感觉不是太合理啊。如果本身只是作为提供者，这此处没有消费者配置，这样处理不太对吧？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] whitekeyboard edited a comment on issue #710: initHystrixConfigProvider初始化错误
Posted by GitBox <gi...@apache.org>.
whitekeyboard edited a comment on issue #710:
URL: https://github.com/apache/dubbo-go/issues/710#issuecomment-672771465
@hxmhlt as **Provider**，init to call initHystrixConfigProvider, and initHystrixConfigProvider to call **GetConsumerConfig**, not to call **GetProviderConfig**?????
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] hxmhlt commented on issue #710: initHystrixConfigProvider初始化错误
Posted by GitBox <gi...@apache.org>.
hxmhlt commented on issue #710:
URL: https://github.com/apache/dubbo-go/issues/710#issuecomment-672768457
@whitekeyboard It is not a BUG. Hystirx should read config in ConsumerConfig. Pls configure in ConsumerConfig with your consumer application.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks removed a comment on issue #710: initHystrixConfigProvider初始化错误
Posted by GitBox <gi...@apache.org>.
AlexStocks removed a comment on issue #710:
URL: https://github.com/apache/dubbo-go/issues/710#issuecomment-672766130
@whitekeyboard would u pls submit a pr?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks closed issue #710: initHystrixConfigProvider初始化错误
Posted by GitBox <gi...@apache.org>.
AlexStocks closed issue #710:
URL: https://github.com/apache/dubbo-go/issues/710
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on issue #710: initHystrixConfigProvider初始化错误
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on issue #710:
URL: https://github.com/apache/dubbo-go/issues/710#issuecomment-672766130
@whitekeyboard would u pls submit a pr?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] whitekeyboard commented on issue #710: initHystrixConfigProvider初始化错误
Posted by GitBox <gi...@apache.org>.
whitekeyboard commented on issue #710:
URL: https://github.com/apache/dubbo-go/issues/710#issuecomment-680401947
@YGrylls ths!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] YGrylls commented on issue #710: initHystrixConfigProvider初始化错误
Posted by GitBox <gi...@apache.org>.
YGrylls commented on issue #710:
URL: https://github.com/apache/dubbo-go/issues/710#issuecomment-679823353
Yes, it's a bug. My bad. **GetProviderConfig()** should be called here. @whitekeyboard A pr is welcome, or let me fix this this weekend
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on issue #710: initHystrixConfigProvider初始化错误
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on issue #710:
URL: https://github.com/apache/dubbo-go/issues/710#issuecomment-672762802
@whitekeyboard would u pls submit a pr?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org