You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "iwangjie (via GitHub)" <gi...@apache.org> on 2023/02/15 07:56:46 UTC
[GitHub] [shenyu] iwangjie opened a new pull request, #4387: Critical link, LOG invoke method, causing performance loss.
iwangjie opened a new pull request, #4387:
URL: https://github.com/apache/shenyu/pull/4387
<!-- Describe your PR here; eg. Fixes #issueNo -->
<!--
Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
-->
Make sure that:
- [ ] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
- [ ] You submit test cases (unit or integration tests) that back your changes.
- [ ] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] li-keguo merged pull request #4387: Critical link, LOG invoke method, causing performance loss.
Posted by "li-keguo (via GitHub)" <gi...@apache.org>.
li-keguo merged PR #4387:
URL: https://github.com/apache/shenyu/pull/4387
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] codecov-commenter commented on pull request #4387: Critical link, LOG invoke method, causing performance loss.
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4387:
URL: https://github.com/apache/shenyu/pull/4387#issuecomment-1430920366
# [Codecov](https://codecov.io/gh/apache/shenyu/pull/4387?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#4387](https://codecov.io/gh/apache/shenyu/pull/4387?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (472fcc9) into [master](https://codecov.io/gh/apache/shenyu/commit/43230a4c306629d3fc4052cb0c89e83b2e8c6094?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (43230a4) will **decrease** coverage by `0.09%`.
> The diff coverage is `70.12%`.
```diff
@@ Coverage Diff @@
## master #4387 +/- ##
============================================
- Coverage 68.33% 68.25% -0.09%
+ Complexity 7515 7506 -9
============================================
Files 1020 1020
Lines 28801 28802 +1
Branches 2568 2564 -4
============================================
- Hits 19681 19658 -23
- Misses 7580 7604 +24
Partials 1540 1540
```
| [Impacted Files](https://codecov.io/gh/apache/shenyu/pull/4387?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...disruptor/subscriber/ApiDocExecutorSubscriber.java](https://codecov.io/gh/apache/shenyu/pull/4387?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vZGlzcnVwdG9yL3N1YnNjcmliZXIvQXBpRG9jRXhlY3V0b3JTdWJzY3JpYmVyLmphdmE=) | `27.27% <0.00%> (+4.19%)` | :arrow_up: |
| [.../apache/shenyu/admin/listener/etcd/EtcdClient.java](https://codecov.io/gh/apache/shenyu/pull/4387?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vbGlzdGVuZXIvZXRjZC9FdGNkQ2xpZW50LmphdmE=) | `59.25% <0.00%> (ø)` | |
| [...va/org/apache/shenyu/admin/model/bean/DocInfo.java](https://codecov.io/gh/apache/shenyu/pull/4387?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vbW9kZWwvYmVhbi9Eb2NJbmZvLmphdmE=) | `90.00% <ø> (ø)` | |
| [...ache/shenyu/admin/model/dto/CreateResourceDTO.java](https://codecov.io/gh/apache/shenyu/pull/4387?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vbW9kZWwvZHRvL0NyZWF0ZVJlc291cmNlRFRPLmphdmE=) | `100.00% <ø> (+26.92%)` | :arrow_up: |
| [...che/shenyu/admin/model/entity/DashboardUserDO.java](https://codecov.io/gh/apache/shenyu/pull/4387?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vbW9kZWwvZW50aXR5L0Rhc2hib2FyZFVzZXJETy5qYXZh) | `67.41% <0.00%> (+0.74%)` | :arrow_up: |
| [.../shenyu/admin/service/impl/AppAuthServiceImpl.java](https://codecov.io/gh/apache/shenyu/pull/4387?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9pbXBsL0FwcEF1dGhTZXJ2aWNlSW1wbC5qYXZh) | `77.45% <0.00%> (ø)` | |
| [.../java/org/apache/shenyu/admin/utils/HttpUtils.java](https://codecov.io/gh/apache/shenyu/pull/4387?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdXRpbHMvSHR0cFV0aWxzLmphdmE=) | `10.16% <0.00%> (ø)` | |
| [...a/org/apache/shenyu/common/constant/Constants.java](https://codecov.io/gh/apache/shenyu/pull/4387?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi9jb25zdGFudC9Db25zdGFudHMuamF2YQ==) | `66.66% <ø> (ø)` | |
| [...yu/common/dto/convert/selector/ZombieUpstream.java](https://codecov.io/gh/apache/shenyu/pull/4387?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi9kdG8vY29udmVydC9zZWxlY3Rvci9ab21iaWVVcHN0cmVhbS5qYXZh) | `82.05% <ø> (-0.88%)` | :arrow_down: |
| [...a/org/apache/shenyu/admin/model/vo/RoleEditVO.java](https://codecov.io/gh/apache/shenyu/pull/4387?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vbW9kZWwvdm8vUm9sZUVkaXRWTy5qYXZh) | `20.00% <50.00%> (-0.59%)` | :arrow_down: |
| ... and [29 more](https://codecov.io/gh/apache/shenyu/pull/4387?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org