[GitHub] [daffodil-vscode] stevedlawrence commented on a diff in pull request #199: Add Scala Steward GitHub Action

[GitBox <gi...@apache.org>]

stevedlawrence commented on code in PR #199:
URL: https://github.com/apache/daffodil-vscode/pull/199#discussion_r905310746


##########
.github/workflows/scala-steward.yml:
##########
@@ -0,0 +1,18 @@
+# This workflow will launch at 00:00 every Sunday
+# This file is based on docs from https://github.com/scala-steward-org/scala-steward-action
+on:
+  schedule:
+    - cron: '0 12 * * *'
+
+name: Scala Steward CI
+
+jobs:
+  scala-steward:
+    runs-on: ubuntu-20.04
+    name: Launch Scala Steward

Review Comment:
   Should we add an `if` condition so that this is only triggered on the `apache/daffodil-vscode` repo? If someone creates a fork of the repo we probably don't want their fork to be spammed with PR's updating dependencies. Dependabot does that right now with no way to disable it and I find it pretty annoying.
   
   I think something like would work:
   ```yaml
   jobs:
     scala-steward:
       if: github.repository == 'apache/daffodil-vscode'
       ...
   ```



##########
.github/workflows/scala-steward.yml:
##########
@@ -0,0 +1,18 @@
+# This workflow will launch at 00:00 every Sunday

Review Comment:
   Needs an apache license to pass the rat check.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org