You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Prashant Satam <pr...@gmail.com> on 2023/09/11 11:08:47 UTC

Review Request 74594: RANGER:3923 : API to get DataShare id, name List

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74594/
-----------------------------------------------------------

Review request for ranger, Anand Nadar, Madhan Neethiraj, and Subhrat Chaudhary.


Bugs: RANGER-3923
    https://issues.apache.org/jira/browse/RANGER-3923


Repository: ranger


Description
-------

API to fetch Map of id,names for datashare


Diffs
-----

  agents-common/src/main/java/org/apache/ranger/plugin/store/GdsStore.java 53fe55336 
  security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java d2bd0789d 
  security-admin/src/main/java/org/apache/ranger/rest/GdsREST.java 653e397d4 
  security-admin/src/main/java/org/apache/ranger/security/context/RangerAPIList.java de9014072 


Diff: https://reviews.apache.org/r/74594/diff/1/


Testing
-------

Add multiple datashares then will able to fetch map of id,names for datashare


Thanks,

Prashant Satam

Re: Review Request 74594: RANGER:4397 : API to get DataShare id, name List

Posted by Prashant Satam <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74594/
-----------------------------------------------------------

(Updated Sept. 29, 2023, 1:25 p.m.)


Review request for ranger, Anand Nadar, Madhan Neethiraj, and Subhrat Chaudhary.


Bugs: RANGER-4397
    https://issues.apache.org/jira/browse/RANGER-4397


Repository: ranger


Description
-------

API to fetch List of datashare


Diffs (updated)
-----

  security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java ff6b2b23e 
  security-admin/src/main/java/org/apache/ranger/rest/GdsREST.java 653e397d4 
  security-admin/src/main/java/org/apache/ranger/security/context/RangerAPIList.java de9014072 
  security-admin/src/main/java/org/apache/ranger/view/RangerDataShareInfo.java PRE-CREATION 


Diff: https://reviews.apache.org/r/74594/diff/3/

Changes: https://reviews.apache.org/r/74594/diff/2-3/


Testing
-------

Add multiple datashares then will able to fetch list of dataShares
 API (/datashares/dataset).Need to send Query Param as dataShareHeader=true
Other query params = dataShareHeader=true&datasetId=1&sortBy=createTime&sortType=desc&pageSize=1
Response=========================>
 {
            "isEnabled": true,
            "dataShareId": 2,
            "name": "RangerDataShare1",
            "description": "This is RangerDatashare"
 }


Thanks,

Prashant Satam

Re: Review Request 74594: RANGER:4397 : API to get DataShare id, name List

Posted by Prashant Satam <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74594/
-----------------------------------------------------------

(Updated Sept. 25, 2023, 7:52 a.m.)


Review request for ranger, Anand Nadar, Madhan Neethiraj, and Subhrat Chaudhary.


Bugs: RANGER-4397
    https://issues.apache.org/jira/browse/RANGER-4397


Repository: ranger


Description (updated)
-------

API to fetch List of datashare


Diffs (updated)
-----

  agents-common/src/main/java/org/apache/ranger/plugin/util/SearchFilter.java 440bb4c24 
  security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java d2bd0789d 
  security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java 059954b46 
  security-admin/src/main/java/org/apache/ranger/db/XXGdsDataShareInDatasetDao.java 52c441104 
  security-admin/src/main/java/org/apache/ranger/db/XXGdsSharedResourceDao.java d3bd4d65b 
  security-admin/src/main/java/org/apache/ranger/rest/GdsREST.java 653e397d4 
  security-admin/src/main/java/org/apache/ranger/security/context/RangerAPIList.java de9014072 
  security-admin/src/main/java/org/apache/ranger/view/RangerDataShareInfo.java PRE-CREATION 


Diff: https://reviews.apache.org/r/74594/diff/2/

Changes: https://reviews.apache.org/r/74594/diff/1-2/


Testing (updated)
-------

Add multiple datashares then will able to fetch list of dataShares
 API (/datashares/dataset).Need to send Query Param as dataShareHeader=true
Other query params = dataShareHeader=false&datasetId=1&sortBy=createTime&sortType=desc&pageSize=1
Response=========================>
 {
            "isEnabled": true,
            "dataShareId": 2,
            "name": "RangerDataShare1",
            "description": "This is RangerDatashare"
 }


Thanks,

Prashant Satam