You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/01/21 06:39:36 UTC
[GitHub] [hudi] nsivabalan opened a new pull request #4660: [HUDI-3291] Flipping default record payload to DefaultHoodieRecordPayload
nsivabalan opened a new pull request #4660:
URL: https://github.com/apache/hudi/pull/4660
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds quick-start document.)*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4660: [HUDI-3291] Flipping default record payload to DefaultHoodieRecordPayload
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4660:
URL: https://github.com/apache/hudi/pull/4660#issuecomment-1018226185
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "590944041ba967d5390e5cc3d9b937226b6705af",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "590944041ba967d5390e5cc3d9b937226b6705af",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 590944041ba967d5390e5cc3d9b937226b6705af UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4660: [HUDI-3291][WIP][DO_NOT_MERGE] Flipping default record payload to DefaultHoodieRecordPayload
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4660:
URL: https://github.com/apache/hudi/pull/4660#issuecomment-1019766532
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "590944041ba967d5390e5cc3d9b937226b6705af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5405",
"triggerID" : "590944041ba967d5390e5cc3d9b937226b6705af",
"triggerType" : "PUSH"
}, {
"hash" : "01558c0609b14f4631f5d1b1118200c9823dda93",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5454",
"triggerID" : "01558c0609b14f4631f5d1b1118200c9823dda93",
"triggerType" : "PUSH"
}, {
"hash" : "f6ce8ce302780fe5c541047ec6cbe7f4bb7660e0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5456",
"triggerID" : "f6ce8ce302780fe5c541047ec6cbe7f4bb7660e0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f6ce8ce302780fe5c541047ec6cbe7f4bb7660e0 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5456)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4660: [HUDI-3291][WIP][DO_NOT_MERGE] Flipping default record payload to DefaultHoodieRecordPayload
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4660:
URL: https://github.com/apache/hudi/pull/4660#issuecomment-1019714112
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "590944041ba967d5390e5cc3d9b937226b6705af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5405",
"triggerID" : "590944041ba967d5390e5cc3d9b937226b6705af",
"triggerType" : "PUSH"
}, {
"hash" : "01558c0609b14f4631f5d1b1118200c9823dda93",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5454",
"triggerID" : "01558c0609b14f4631f5d1b1118200c9823dda93",
"triggerType" : "PUSH"
}, {
"hash" : "f6ce8ce302780fe5c541047ec6cbe7f4bb7660e0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f6ce8ce302780fe5c541047ec6cbe7f4bb7660e0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 01558c0609b14f4631f5d1b1118200c9823dda93 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5454)
* f6ce8ce302780fe5c541047ec6cbe7f4bb7660e0 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4660: [HUDI-3291][WIP][DO_NOT_MERGE] Flipping default record payload to DefaultHoodieRecordPayload
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4660:
URL: https://github.com/apache/hudi/pull/4660#issuecomment-1019737696
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "590944041ba967d5390e5cc3d9b937226b6705af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5405",
"triggerID" : "590944041ba967d5390e5cc3d9b937226b6705af",
"triggerType" : "PUSH"
}, {
"hash" : "01558c0609b14f4631f5d1b1118200c9823dda93",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5454",
"triggerID" : "01558c0609b14f4631f5d1b1118200c9823dda93",
"triggerType" : "PUSH"
}, {
"hash" : "f6ce8ce302780fe5c541047ec6cbe7f4bb7660e0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5456",
"triggerID" : "f6ce8ce302780fe5c541047ec6cbe7f4bb7660e0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 01558c0609b14f4631f5d1b1118200c9823dda93 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5454)
* f6ce8ce302780fe5c541047ec6cbe7f4bb7660e0 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5456)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4660: [HUDI-3291][WIP][DO_NOT_MERGE] Flipping default record payload to DefaultHoodieRecordPayload
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4660:
URL: https://github.com/apache/hudi/pull/4660#issuecomment-1019737696
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "590944041ba967d5390e5cc3d9b937226b6705af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5405",
"triggerID" : "590944041ba967d5390e5cc3d9b937226b6705af",
"triggerType" : "PUSH"
}, {
"hash" : "01558c0609b14f4631f5d1b1118200c9823dda93",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5454",
"triggerID" : "01558c0609b14f4631f5d1b1118200c9823dda93",
"triggerType" : "PUSH"
}, {
"hash" : "f6ce8ce302780fe5c541047ec6cbe7f4bb7660e0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5456",
"triggerID" : "f6ce8ce302780fe5c541047ec6cbe7f4bb7660e0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 01558c0609b14f4631f5d1b1118200c9823dda93 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5454)
* f6ce8ce302780fe5c541047ec6cbe7f4bb7660e0 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5456)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4660: [HUDI-3291] Flipping default record payload to DefaultHoodieRecordPayload
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4660:
URL: https://github.com/apache/hudi/pull/4660#issuecomment-1018262142
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "590944041ba967d5390e5cc3d9b937226b6705af",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5405",
"triggerID" : "590944041ba967d5390e5cc3d9b937226b6705af",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 590944041ba967d5390e5cc3d9b937226b6705af Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5405)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #4660: [HUDI-3291][WIP][DO_NOT_MERGE] Flipping default record payload to DefaultHoodieRecordPayload
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #4660:
URL: https://github.com/apache/hudi/pull/4660#issuecomment-1019712898
@danny0405 : Can we please take up flink in another patch. Even for spark, I need to think through quite a bit before we can flip. I created this just to check if all tests pass for now.
For eg, in case of DefaultHoodieRecordPayload we expect payload props to be set. We do take the preCombine field and set the appropriate payload property. But wanted to follow up compaction, deltastreamer flows to ensure all paths are intact.
So, even in spark we have some work to be done. would prefer to keep flink in a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #4660: [HUDI-3291][WIP][DO_NOT_MERGE] Flipping default record payload to DefaultHoodieRecordPayload
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #4660:
URL: https://github.com/apache/hudi/pull/4660#issuecomment-1024608648
Dependent on https://github.com/apache/hudi/pull/4681
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #4660: [HUDI-3291][WIP][DO_NOT_MERGE] Flipping default record payload to DefaultHoodieRecordPayload
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #4660:
URL: https://github.com/apache/hudi/pull/4660#issuecomment-1023768290
Here are the points to consider before we can make DefaultHoodieRecordPayload as default
As of now, its easier on the write path, bcoz, users can set the payload properties in the write config and all write path can rely on that. But we have quite a few read paths, like RealtimeCompactedRecordReader, RealtimeUnmergedRecordReader,HoodieMergeOnReadRDD which tries to call into getInsert() or combineAndGetUpdate() method on the record payload.
So, we are in need of serializing the properties in table config and reuse them in these flows. As of now, preCombine field is already part of table config and hence we can set the hoodie.payload.ordering.field based on that. But for "hoodie.payload.event.time.field", we don't serialize them to table config as of today.
So, if we really want to leverage event time, we might have to add the field to table config. If not, we may not update the event time in some of the read flows.
This patch have a close connection with https://github.com/apache/hudi/pull/4681. in this patch, we can see where all we might need to read the initialize the payload properties required to be passed into DefaultHoodieRecordPayload method calls.
Wanted to hear your thoughts on this.
@xushiyan @codope @yihua
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4660: [HUDI-3291][WIP][DO_NOT_MERGE] Flipping default record payload to DefaultHoodieRecordPayload
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4660:
URL: https://github.com/apache/hudi/pull/4660#issuecomment-1019709571
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "590944041ba967d5390e5cc3d9b937226b6705af",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5405",
"triggerID" : "590944041ba967d5390e5cc3d9b937226b6705af",
"triggerType" : "PUSH"
}, {
"hash" : "01558c0609b14f4631f5d1b1118200c9823dda93",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "01558c0609b14f4631f5d1b1118200c9823dda93",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 590944041ba967d5390e5cc3d9b937226b6705af Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5405)
* 01558c0609b14f4631f5d1b1118200c9823dda93 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4660: [HUDI-3291][WIP][DO_NOT_MERGE] Flipping default record payload to DefaultHoodieRecordPayload
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4660:
URL: https://github.com/apache/hudi/pull/4660#issuecomment-1019712985
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "590944041ba967d5390e5cc3d9b937226b6705af",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5405",
"triggerID" : "590944041ba967d5390e5cc3d9b937226b6705af",
"triggerType" : "PUSH"
}, {
"hash" : "01558c0609b14f4631f5d1b1118200c9823dda93",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5454",
"triggerID" : "01558c0609b14f4631f5d1b1118200c9823dda93",
"triggerType" : "PUSH"
}, {
"hash" : "f6ce8ce302780fe5c541047ec6cbe7f4bb7660e0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f6ce8ce302780fe5c541047ec6cbe7f4bb7660e0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 590944041ba967d5390e5cc3d9b937226b6705af Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5405)
* 01558c0609b14f4631f5d1b1118200c9823dda93 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5454)
* f6ce8ce302780fe5c541047ec6cbe7f4bb7660e0 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4660: [HUDI-3291] Flipping default record payload to DefaultHoodieRecordPayload
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4660:
URL: https://github.com/apache/hudi/pull/4660#issuecomment-1018227679
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "590944041ba967d5390e5cc3d9b937226b6705af",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5405",
"triggerID" : "590944041ba967d5390e5cc3d9b937226b6705af",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 590944041ba967d5390e5cc3d9b937226b6705af Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5405)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4660: [HUDI-3291][WIP][DO_NOT_MERGE] Flipping default record payload to DefaultHoodieRecordPayload
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4660:
URL: https://github.com/apache/hudi/pull/4660#issuecomment-1018262142
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "590944041ba967d5390e5cc3d9b937226b6705af",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5405",
"triggerID" : "590944041ba967d5390e5cc3d9b937226b6705af",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 590944041ba967d5390e5cc3d9b937226b6705af Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5405)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4660: [HUDI-3291][WIP][DO_NOT_MERGE] Flipping default record payload to DefaultHoodieRecordPayload
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4660:
URL: https://github.com/apache/hudi/pull/4660#issuecomment-1019712985
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "590944041ba967d5390e5cc3d9b937226b6705af",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5405",
"triggerID" : "590944041ba967d5390e5cc3d9b937226b6705af",
"triggerType" : "PUSH"
}, {
"hash" : "01558c0609b14f4631f5d1b1118200c9823dda93",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5454",
"triggerID" : "01558c0609b14f4631f5d1b1118200c9823dda93",
"triggerType" : "PUSH"
}, {
"hash" : "f6ce8ce302780fe5c541047ec6cbe7f4bb7660e0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f6ce8ce302780fe5c541047ec6cbe7f4bb7660e0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 590944041ba967d5390e5cc3d9b937226b6705af Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5405)
* 01558c0609b14f4631f5d1b1118200c9823dda93 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5454)
* f6ce8ce302780fe5c541047ec6cbe7f4bb7660e0 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4660: [HUDI-3291] Flipping default record payload to DefaultHoodieRecordPayload
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4660:
URL: https://github.com/apache/hudi/pull/4660#issuecomment-1018227679
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "590944041ba967d5390e5cc3d9b937226b6705af",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5405",
"triggerID" : "590944041ba967d5390e5cc3d9b937226b6705af",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 590944041ba967d5390e5cc3d9b937226b6705af Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5405)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4660: [HUDI-3291][WIP][DO_NOT_MERGE] Flipping default record payload to DefaultHoodieRecordPayload
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4660:
URL: https://github.com/apache/hudi/pull/4660#issuecomment-1019714112
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "590944041ba967d5390e5cc3d9b937226b6705af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5405",
"triggerID" : "590944041ba967d5390e5cc3d9b937226b6705af",
"triggerType" : "PUSH"
}, {
"hash" : "01558c0609b14f4631f5d1b1118200c9823dda93",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5454",
"triggerID" : "01558c0609b14f4631f5d1b1118200c9823dda93",
"triggerType" : "PUSH"
}, {
"hash" : "f6ce8ce302780fe5c541047ec6cbe7f4bb7660e0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f6ce8ce302780fe5c541047ec6cbe7f4bb7660e0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 01558c0609b14f4631f5d1b1118200c9823dda93 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5454)
* f6ce8ce302780fe5c541047ec6cbe7f4bb7660e0 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4660: [HUDI-3291][WIP][DO_NOT_MERGE] Flipping default record payload to DefaultHoodieRecordPayload
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4660:
URL: https://github.com/apache/hudi/pull/4660#issuecomment-1019710818
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "590944041ba967d5390e5cc3d9b937226b6705af",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5405",
"triggerID" : "590944041ba967d5390e5cc3d9b937226b6705af",
"triggerType" : "PUSH"
}, {
"hash" : "01558c0609b14f4631f5d1b1118200c9823dda93",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5454",
"triggerID" : "01558c0609b14f4631f5d1b1118200c9823dda93",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 590944041ba967d5390e5cc3d9b937226b6705af Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5405)
* 01558c0609b14f4631f5d1b1118200c9823dda93 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5454)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4660: [HUDI-3291][WIP][DO_NOT_MERGE] Flipping default record payload to DefaultHoodieRecordPayload
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4660:
URL: https://github.com/apache/hudi/pull/4660#issuecomment-1019709571
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "590944041ba967d5390e5cc3d9b937226b6705af",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5405",
"triggerID" : "590944041ba967d5390e5cc3d9b937226b6705af",
"triggerType" : "PUSH"
}, {
"hash" : "01558c0609b14f4631f5d1b1118200c9823dda93",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "01558c0609b14f4631f5d1b1118200c9823dda93",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 590944041ba967d5390e5cc3d9b937226b6705af Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5405)
* 01558c0609b14f4631f5d1b1118200c9823dda93 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4660: [HUDI-3291] Flipping default record payload to DefaultHoodieRecordPayload
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4660:
URL: https://github.com/apache/hudi/pull/4660#issuecomment-1018226185
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "590944041ba967d5390e5cc3d9b937226b6705af",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "590944041ba967d5390e5cc3d9b937226b6705af",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 590944041ba967d5390e5cc3d9b937226b6705af UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a change in pull request #4660: [HUDI-3291] Flipping default record payload to DefaultHoodieRecordPayload
Posted by GitBox <gi...@apache.org>.
danny0405 commented on a change in pull request #4660:
URL: https://github.com/apache/hudi/pull/4660#discussion_r790081396
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java
##########
@@ -108,7 +109,7 @@
public static final ConfigProperty<String> WRITE_PAYLOAD_CLASS_NAME = ConfigProperty
.key("hoodie.datasource.write.payload.class")
- .defaultValue(OverwriteWithLatestAvroPayload.class.getName())
+ .defaultValue(DefaultHoodieRecordPayload.class.getName())
Review comment:
And another one in FlinkOptions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4660: [HUDI-3291][WIP][DO_NOT_MERGE] Flipping default record payload to DefaultHoodieRecordPayload
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4660:
URL: https://github.com/apache/hudi/pull/4660#issuecomment-1019710818
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "590944041ba967d5390e5cc3d9b937226b6705af",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5405",
"triggerID" : "590944041ba967d5390e5cc3d9b937226b6705af",
"triggerType" : "PUSH"
}, {
"hash" : "01558c0609b14f4631f5d1b1118200c9823dda93",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5454",
"triggerID" : "01558c0609b14f4631f5d1b1118200c9823dda93",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 590944041ba967d5390e5cc3d9b937226b6705af Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5405)
* 01558c0609b14f4631f5d1b1118200c9823dda93 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5454)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org