You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gearpump.apache.org by kkasravi <gi...@git.apache.org> on 2017/02/27 23:57:01 UTC

[GitHub] incubator-gearpump pull request #163: GEARPUMP-279 akka-streams test example...

GitHub user kkasravi opened a pull request:

    https://github.com/apache/incubator-gearpump/pull/163

    GEARPUMP-279 akka-streams test examples do not work

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the commit message is formatted like:
       `[GEARPUMP-<Jira issue #>] Meaningful description of pull request` 
     - [ ] Make sure tests pass via `sbt clean test`.
     - [ ] Make sure old documentation affected by the pull request has been updated and new documentation added for new functionality. 
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kkasravi/incubator-gearpump GEARPUMP-279

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-gearpump/pull/163.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #163
    
----
commit dfc00833fd932391c680748e75e507d00c4be438
Author: Kam Kasravi <ka...@yahoo.com>
Date:   2017-02-27T23:42:14Z

    GEARPUMP-279 akka-streams test examples do not work

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-gearpump pull request #163: GEARPUMP-279 akka-streams test example...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-gearpump/pull/163


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-gearpump issue #163: GEARPUMP-279 akka-streams test examples do no...

Posted by manuzhang <gi...@git.apache.org>.
Github user manuzhang commented on the issue:

    https://github.com/apache/incubator-gearpump/pull/163
  
    merged and I also reworded the commit message to `use the imperative mood` following the [best practice](https://chris.beams.io/posts/git-commit/)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-gearpump issue #163: GEARPUMP-279 akka-streams test examples do no...

Posted by manuzhang <gi...@git.apache.org>.
Github user manuzhang commented on the issue:

    https://github.com/apache/incubator-gearpump/pull/163
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---