You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "manuzhang (via GitHub)" <gi...@apache.org> on 2026/06/22 07:07:35 UTC
[PR] refactor: remove map_contains_key serde [datafusion-comet]
manuzhang opened a new pull request, #4703:
URL: https://github.com/apache/datafusion-comet/pull/4703
## Which issue does this PR close?
Part of apache/datafusion-comet#4505.
## Rationale for this change
Spark rewrites `map_contains_key` to `ArrayContains(MapKeys(...), key)` before Comet serialization. The dedicated `MapContainsKey` serde path is therefore unreachable and should not remain registered as if it were used.
## What changes are included in this PR?
- Removes the unreachable `CometMapContainsKey` serde object.
- Removes the `MapContainsKey` registry entry from `QueryPlanSerde`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] refactor: remove map_contains_key serde [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove merged PR #4703:
URL: https://github.com/apache/datafusion-comet/pull/4703
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org