You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Philip Harvey (JIRA)" <ji...@apache.org> on 2012/09/03 13:41:08 UTC
[jira] [Created] (QPID-4281) Java tests logging broken because
log4j.configuration is not a valid URL
Philip Harvey created QPID-4281:
-----------------------------------
Summary: Java tests logging broken because log4j.configuration is not a valid URL
Key: QPID-4281
URL: https://issues.apache.org/jira/browse/QPID-4281
Project: Qpid
Issue Type: Bug
Components: Java Tests
Affects Versions: 0.18
Reporter: Philip Harvey
Priority: Minor
Fix For: 0.19
A change was made to the log4j configuration used by our unit tests in QPID-4109, such that the log4j.configuration system property that is effective in our unit tests is "test-profiles/log4j-test.xml" rather than "file:///path/to/log4j-test.xml".
This breaks our unit test logging configuration because Log4J requires that this system property is a valid URL.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Commented] (QPID-4281) Java tests logging broken because
log4j.configuration is not a valid URL
Posted by "Philip Harvey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473189#comment-13473189 ]
Philip Harvey commented on QPID-4281:
-------------------------------------
Note that there are changes being made in QPID-4335 to TestApplicationRegistry to use a hard-coded log4j.xml path. That change will need to be revisited as part of this JIRA.
> Java tests logging broken because log4j.configuration is not a valid URL
> ------------------------------------------------------------------------
>
> Key: QPID-4281
> URL: https://issues.apache.org/jira/browse/QPID-4281
> Project: Qpid
> Issue Type: Bug
> Components: Java Tests
> Affects Versions: 0.18
> Reporter: Philip Harvey
> Assignee: Philip Harvey
> Priority: Minor
> Fix For: 0.19
>
> Attachments: 0001-QPID-4281-Fix-setting-of-log4j-configuration-in-syst.patch
>
>
> A change was made to the log4j configuration used by our unit tests in QPID-4109, such that the log4j.configuration system property that is effective in our unit tests is "test-profiles/log4j-test.xml" rather than "file:///path/to/log4j-test.xml".
> This breaks our unit test logging configuration because Log4J requires that this system property is a valid URL.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Assigned] (QPID-4281) Java tests logging broken because
log4j.configuration is not a valid URL
Posted by "Alex Rudyy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Rudyy reassigned QPID-4281:
--------------------------------
Assignee: Alex Rudyy
> Java tests logging broken because log4j.configuration is not a valid URL
> ------------------------------------------------------------------------
>
> Key: QPID-4281
> URL: https://issues.apache.org/jira/browse/QPID-4281
> Project: Qpid
> Issue Type: Bug
> Components: Java Tests
> Affects Versions: 0.18
> Reporter: Philip Harvey
> Assignee: Alex Rudyy
> Priority: Minor
> Fix For: 0.19
>
> Attachments: 0001-QPID-4281-Fix-setting-of-log4j-configuration-in-syst.patch
>
>
> A change was made to the log4j configuration used by our unit tests in QPID-4109, such that the log4j.configuration system property that is effective in our unit tests is "test-profiles/log4j-test.xml" rather than "file:///path/to/log4j-test.xml".
> This breaks our unit test logging configuration because Log4J requires that this system property is a valid URL.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Updated] (QPID-4281) Java tests logging broken because
log4j.configuration is not a valid URL
Posted by "Alex Rudyy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Rudyy updated QPID-4281:
-----------------------------
Attachment: 0001-QPID-4281-Fix-setting-of-log4j-configuration-in-syst.patch
Attached a patch fixing the issue
> Java tests logging broken because log4j.configuration is not a valid URL
> ------------------------------------------------------------------------
>
> Key: QPID-4281
> URL: https://issues.apache.org/jira/browse/QPID-4281
> Project: Qpid
> Issue Type: Bug
> Components: Java Tests
> Affects Versions: 0.18
> Reporter: Philip Harvey
> Priority: Minor
> Fix For: 0.19
>
> Attachments: 0001-QPID-4281-Fix-setting-of-log4j-configuration-in-syst.patch
>
>
> A change was made to the log4j configuration used by our unit tests in QPID-4109, such that the log4j.configuration system property that is effective in our unit tests is "test-profiles/log4j-test.xml" rather than "file:///path/to/log4j-test.xml".
> This breaks our unit test logging configuration because Log4J requires that this system property is a valid URL.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Updated] (QPID-4281) Java tests logging broken because
log4j.configuration is not a valid URL
Posted by "Keith Wall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall updated QPID-4281:
-----------------------------
Status: Open (was: Ready To Review)
Hi Phil/Alex
Tests fail for me if I run within a directory whose parent contains spaces. This is the situation we have on Apache CI. For instance, BrokerLoggingTest:
{noformat}
Exception in constructor: testBrokerStartupConfiguration (java.lang.RuntimeException: Couldn't URI from log4.conf
iguration: file:////home/keith/src/qpid wspace/qpid/java/test-profiles/log4j-test.xml
at org.apache.qpid.test.utils.QpidBrokerTestCase.initialiseLogConfigFile(QpidBrokerTestCase.java:220)
at org.apache.qpid.test.utils.QpidBrokerTestCase.<init>(QpidBrokerTestCase.java:204)
at org.apache.qpid.server.logging.AbstractTestLogging.<init>(AbstractTestLogging.java:44)
at org.apache.qpid.server.logging.BrokerLoggingTest.<init>(BrokerLoggingTest.java:48)
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:39)
at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27)
at java.lang.reflect.Constructor.newInstance(Constructor.java:513)
at junit.framework.TestSuite.createTest(TestSuite.java:131)
at junit.framework.TestSuite.addTestMethod(TestSuite.java:114)
at junit.framework.TestSuite.<init>(TestSuite.java:75)
at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:398)
at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(JUnitTestRunner.java:931)
at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:785)
Caused by: java.net.URISyntaxException: Illegal character in path at index 30: file:////home/keith/src/qpid wspace/qpid/java/test-profiles/log4j-test.xml
at java.net.URI$Parser.fail(URI.java:2809)
at java.net.URI$Parser.checkChars(URI.java:2982)
at java.net.URI$Parser.parseHierarchical(URI.java:3066)
at java.net.URI$Parser.parse(URI.java:3014)
at java.net.URI.<init>(URI.java:578)
at org.apache.qpid.test.utils.QpidBrokerTestCase.initialiseLogConfigFile(QpidBrokerTestCase.java:212)
{noformat}
> Java tests logging broken because log4j.configuration is not a valid URL
> ------------------------------------------------------------------------
>
> Key: QPID-4281
> URL: https://issues.apache.org/jira/browse/QPID-4281
> Project: Qpid
> Issue Type: Bug
> Components: Java Tests
> Affects Versions: 0.18
> Reporter: Philip Harvey
> Assignee: Keith Wall
> Priority: Minor
> Fix For: 0.19
>
> Attachments: 0001-QPID-4281-Fix-setting-of-log4j-configuration-in-syst.patch
>
>
> A change was made to the log4j configuration used by our unit tests in QPID-4109, such that the log4j.configuration system property that is effective in our unit tests is "test-profiles/log4j-test.xml" rather than "file:///path/to/log4j-test.xml".
> This breaks our unit test logging configuration because Log4J requires that this system property is a valid URL.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Updated] (QPID-4281) Java tests logging broken because
log4j.configuration is not a valid URL
Posted by "Philip Harvey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Philip Harvey updated QPID-4281:
--------------------------------
Attachment: 0001-QPID-4281-Fix-setting-of-log4j-configuration-in-syst.patch
Attached new patch that addresses problems in the previous one when running from a directory containing spaces.
Dealing with spaces properly required a non-trivial refactoring of the way QpidBrokerTestCase constructs the broker command.
> Java tests logging broken because log4j.configuration is not a valid URL
> ------------------------------------------------------------------------
>
> Key: QPID-4281
> URL: https://issues.apache.org/jira/browse/QPID-4281
> Project: Qpid
> Issue Type: Bug
> Components: Java Tests
> Affects Versions: 0.18
> Reporter: Philip Harvey
> Assignee: Philip Harvey
> Priority: Minor
> Fix For: 0.19
>
> Attachments: 0001-QPID-4281-Fix-setting-of-log4j-configuration-in-syst.patch, 0001-QPID-4281-Fix-setting-of-log4j-configuration-in-syst.patch
>
>
> A change was made to the log4j configuration used by our unit tests in QPID-4109, such that the log4j.configuration system property that is effective in our unit tests is "test-profiles/log4j-test.xml" rather than "file:///path/to/log4j-test.xml".
> This breaks our unit test logging configuration because Log4J requires that this system property is a valid URL.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Assigned] (QPID-4281) Java tests logging broken because
log4j.configuration is not a valid URL
Posted by "Philip Harvey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Philip Harvey reassigned QPID-4281:
-----------------------------------
Assignee: Keith Wall (was: Philip Harvey)
Keith - please can you commit this patch, thanks.
> Java tests logging broken because log4j.configuration is not a valid URL
> ------------------------------------------------------------------------
>
> Key: QPID-4281
> URL: https://issues.apache.org/jira/browse/QPID-4281
> Project: Qpid
> Issue Type: Bug
> Components: Java Tests
> Affects Versions: 0.18
> Reporter: Philip Harvey
> Assignee: Keith Wall
> Priority: Minor
> Fix For: 0.19
>
> Attachments: 0001-QPID-4281-Fix-setting-of-log4j-configuration-in-syst.patch
>
>
> A change was made to the log4j configuration used by our unit tests in QPID-4109, such that the log4j.configuration system property that is effective in our unit tests is "test-profiles/log4j-test.xml" rather than "file:///path/to/log4j-test.xml".
> This breaks our unit test logging configuration because Log4J requires that this system property is a valid URL.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Updated] (QPID-4281) Java tests logging broken because
log4j.configuration is not a valid URL
Posted by "Alex Rudyy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Rudyy updated QPID-4281:
-----------------------------
Status: Ready To Review (was: In Progress)
> Java tests logging broken because log4j.configuration is not a valid URL
> ------------------------------------------------------------------------
>
> Key: QPID-4281
> URL: https://issues.apache.org/jira/browse/QPID-4281
> Project: Qpid
> Issue Type: Bug
> Components: Java Tests
> Affects Versions: 0.18
> Reporter: Philip Harvey
> Assignee: Alex Rudyy
> Priority: Minor
> Fix For: 0.19
>
> Attachments: 0001-QPID-4281-Fix-setting-of-log4j-configuration-in-syst.patch
>
>
> A change was made to the log4j configuration used by our unit tests in QPID-4109, such that the log4j.configuration system property that is effective in our unit tests is "test-profiles/log4j-test.xml" rather than "file:///path/to/log4j-test.xml".
> This breaks our unit test logging configuration because Log4J requires that this system property is a valid URL.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Assigned] (QPID-4281) Java tests logging broken because
log4j.configuration is not a valid URL
Posted by "Philip Harvey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Philip Harvey reassigned QPID-4281:
-----------------------------------
Assignee: Robbie Gemmell (was: Philip Harvey)
Hi Robbie, please can you review the updated patch.
> Java tests logging broken because log4j.configuration is not a valid URL
> ------------------------------------------------------------------------
>
> Key: QPID-4281
> URL: https://issues.apache.org/jira/browse/QPID-4281
> Project: Qpid
> Issue Type: Bug
> Components: Java Tests
> Affects Versions: 0.18
> Reporter: Philip Harvey
> Assignee: Robbie Gemmell
> Priority: Minor
> Fix For: 0.19
>
> Attachments: 0001-QPID-4281-Fix-setting-of-log4j-configuration-in-syst.patch, 0001-QPID-4281-Fix-setting-of-log4j-configuration-in-syst.patch
>
>
> A change was made to the log4j configuration used by our unit tests in QPID-4109, such that the log4j.configuration system property that is effective in our unit tests is "test-profiles/log4j-test.xml" rather than "file:///path/to/log4j-test.xml".
> This breaks our unit test logging configuration because Log4J requires that this system property is a valid URL.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Commented] (QPID-4281) Java tests logging broken because
log4j.configuration is not a valid URL
Posted by "Philip Harvey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13447305#comment-13447305 ]
Philip Harvey commented on QPID-4281:
-------------------------------------
Reviewed patch - looks good. I have observed the full set of tests passing with both spawned and in-process test profiles.
> Java tests logging broken because log4j.configuration is not a valid URL
> ------------------------------------------------------------------------
>
> Key: QPID-4281
> URL: https://issues.apache.org/jira/browse/QPID-4281
> Project: Qpid
> Issue Type: Bug
> Components: Java Tests
> Affects Versions: 0.18
> Reporter: Philip Harvey
> Assignee: Philip Harvey
> Priority: Minor
> Fix For: 0.19
>
> Attachments: 0001-QPID-4281-Fix-setting-of-log4j-configuration-in-syst.patch
>
>
> A change was made to the log4j configuration used by our unit tests in QPID-4109, such that the log4j.configuration system property that is effective in our unit tests is "test-profiles/log4j-test.xml" rather than "file:///path/to/log4j-test.xml".
> This breaks our unit test logging configuration because Log4J requires that this system property is a valid URL.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Assigned] (QPID-4281) Java tests logging broken because
log4j.configuration is not a valid URL
Posted by "Alex Rudyy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Rudyy reassigned QPID-4281:
--------------------------------
Assignee: Philip Harvey (was: Alex Rudyy)
Phil,
Could you please review the patch?
> Java tests logging broken because log4j.configuration is not a valid URL
> ------------------------------------------------------------------------
>
> Key: QPID-4281
> URL: https://issues.apache.org/jira/browse/QPID-4281
> Project: Qpid
> Issue Type: Bug
> Components: Java Tests
> Affects Versions: 0.18
> Reporter: Philip Harvey
> Assignee: Philip Harvey
> Priority: Minor
> Fix For: 0.19
>
> Attachments: 0001-QPID-4281-Fix-setting-of-log4j-configuration-in-syst.patch
>
>
> A change was made to the log4j configuration used by our unit tests in QPID-4109, such that the log4j.configuration system property that is effective in our unit tests is "test-profiles/log4j-test.xml" rather than "file:///path/to/log4j-test.xml".
> This breaks our unit test logging configuration because Log4J requires that this system property is a valid URL.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Assigned] (QPID-4281) Java tests logging broken because
log4j.configuration is not a valid URL
Posted by "Keith Wall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall reassigned QPID-4281:
--------------------------------
Assignee: Philip Harvey (was: Keith Wall)
> Java tests logging broken because log4j.configuration is not a valid URL
> ------------------------------------------------------------------------
>
> Key: QPID-4281
> URL: https://issues.apache.org/jira/browse/QPID-4281
> Project: Qpid
> Issue Type: Bug
> Components: Java Tests
> Affects Versions: 0.18
> Reporter: Philip Harvey
> Assignee: Philip Harvey
> Priority: Minor
> Fix For: 0.19
>
> Attachments: 0001-QPID-4281-Fix-setting-of-log4j-configuration-in-syst.patch
>
>
> A change was made to the log4j configuration used by our unit tests in QPID-4109, such that the log4j.configuration system property that is effective in our unit tests is "test-profiles/log4j-test.xml" rather than "file:///path/to/log4j-test.xml".
> This breaks our unit test logging configuration because Log4J requires that this system property is a valid URL.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org