You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by "kirklund (GitHub)" <gi...@apache.org> on 2019/12/06 00:33:41 UTC

[GitHub] [geode] kirklund opened pull request #4436: GEODE-7503: Cleanup GemFireCacheImpl


[ Full content available at: https://github.com/apache/geode/pull/4436 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] demery-pivotal commented on pull request #4436: GEODE-7503: Cleanup GemFireCacheImpl

Posted by "demery-pivotal (GitHub)" <gi...@apache.org>.

Is it possible (and reasonable) to move this check up the call stack, so that the exception message can refer to more public methods?

[ Full content available at: https://github.com/apache/geode/pull/4436 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] demery-pivotal commented on pull request #4436: GEODE-7503: Cleanup GemFireCacheImpl

Posted by "demery-pivotal (GitHub)" <gi...@apache.org>.

Should these be deprecated on `InternalCache` instead?

[ Full content available at: https://github.com/apache/geode/pull/4436 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] demery-pivotal commented on pull request #4436: GEODE-7503: Cleanup GemFireCacheImpl

Posted by "demery-pivotal (GitHub)" <gi...@apache.org>.

Yeah, this is much better. Later we may be able to bundle these three runnables into a single interface. And similar for any other clumps of related parameters.

[ Full content available at: https://github.com/apache/geode/pull/4436 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on pull request #4436: GEODE-7503: Cleanup GemFireCacheImpl

Posted by "kirklund (GitHub)" <gi...@apache.org>.

This is an old TODO.

[ Full content available at: https://github.com/apache/geode/pull/4436 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on pull request #4436: GEODE-7503: Cleanup GemFireCacheImpl

Posted by "kirklund (GitHub)" <gi...@apache.org>.

TODO: Wording should be improved to not use the name of a private method.

[ Full content available at: https://github.com/apache/geode/pull/4436 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on pull request #4436: GEODE-7503: Cleanup GemFireCacheImpl

Posted by "kirklund (GitHub)" <gi...@apache.org>.

Oops, I didn't mean to leave these in. I'll delete these.

[ Full content available at: https://github.com/apache/geode/pull/4436 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on issue #4436: GEODE-7503: Cleanup GemFireCacheImpl

Posted by "kirklund (GitHub)" <gi...@apache.org>.

Looks like AnalyzeManagementSerializablesJUnitTest is failing on develop as well as this PR branch. I'll rebase on develop soon.

[ Full content available at: https://github.com/apache/geode/pull/4436 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org