svn commit: r1877515 - /pivot/trunk/pivot_checks.xml

[rw...@apache.org]

Author: rwhitcomb
Date: Fri May  8 17:58:04 2020
New Revision: 1877515

URL: http://svn.apache.org/viewvc?rev=1877515&view=rev
Log:
PIVOT-1032: Tweak the checkstyle configuration:
* Don't flag inline conditionals as errors; personally I don't see an issue,
  the notes say they can be hard to understand so some organizations flag
  them, whereas the Pivot project has not, nor do the Java coding conventions
  forbid them, and there are more than I care to change, so I'm disabling it.
* Allow the legacy use of "package.html" instead of "package-info.java" because
  that's what we do (or have done, at least) in Pivot.


Modified:
    pivot/trunk/pivot_checks.xml

Modified: pivot/trunk/pivot_checks.xml
URL: http://svn.apache.org/viewvc/pivot/trunk/pivot_checks.xml?rev=1877515&r1=1877514&r2=1877515&view=diff
==============================================================================
--- pivot/trunk/pivot_checks.xml (original)
+++ pivot/trunk/pivot_checks.xml Fri May  8 17:58:04 2020
@@ -43,7 +43,9 @@
 
     <!-- Checks that a package-info.java file exists for each package.     -->
     <!-- See http://checkstyle.sf.net/config_javadoc.html#JavadocPackage -->
-    <module name="JavadocPackage"/>
+    <module name="JavadocPackage">
+        <property name="allowLegacy" value="true"/>
+    </module>
 
     <!-- Checks whether files end with a new line.                        -->
     <!-- See http://checkstyle.sf.net/config_misc.html#NewlineAtEndOfFile -->
@@ -149,7 +151,7 @@
 
         <!-- Checks for common coding problems               -->
         <!-- See http://checkstyle.sf.net/config_coding.html -->
-        <module name="AvoidInlineConditionals"/>
+        <!-- <module name="AvoidInlineConditionals"/> -->
         <module name="EmptyStatement"/>
         <module name="EqualsHashCode"/>
         <module name="HiddenField"/>