You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/05/11 00:41:09 UTC

[GitHub] [spark] cloud-fan commented on a diff in pull request #36418: [SPARK-39079][SQL] Add restriction to V2 catalog's name

cloud-fan commented on code in PR #36418:
URL: https://github.com/apache/spark/pull/36418#discussion_r869778558


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/package.scala:
##########
@@ -130,8 +130,11 @@ package object util extends Logging {
     "`" + name.replace("`", "``") + "`"
   }
 
+  def isValidPartName(part: String): Boolean =

Review Comment:
   how about `isValidNameInIdentifier`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org