You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Kevin Wilfong (Created) (JIRA)" <ji...@apache.org> on 2012/02/10 20:20:59 UTC
[jira] [Created] (HIVE-2797) Make the IP address of a Thrift client
available to HMSHandler.
Make the IP address of a Thrift client available to HMSHandler.
---------------------------------------------------------------
Key: HIVE-2797
URL: https://issues.apache.org/jira/browse/HIVE-2797
Project: Hive
Issue Type: Improvement
Reporter: Kevin Wilfong
Currently, in unsecured mode, metastore Thrift calls are, from the HMSHandler's point of view, anonymous. If we expose the IP address of the Thrift client to the HMSHandler from the Processor, this will help to give some context, in particular for audit logging, of where the call is coming from.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2797) Make the IP address of a Thrift client
available to HMSHandler.
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2797:
------------------------------
Attachment: HIVE-2797.D1701.5.patch
kevinwilfong updated the revision "HIVE-2797 [jira] Make the IP address of a Thrift client available to HMSHandler.".
Reviewers: JIRA, njain, ashutoshc
Really sorry about that Ashutosh. The TUGIContainingTranspport does not extend TSocket, which caused the errors you saw. I added a getSocket method to the class which returns the Socket object if the underlying TTransport is an instance of TSocket, otherwise null. TUGIBasedProcessor's implementation of setIpAddress now uses this method and handles the case of null.
REVISION DETAIL
https://reviews.facebook.net/D1701
AFFECTED FILES
shims/src/common/java/org/apache/hadoop/hive/thrift/TUGIContainingTransport.java
metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteUGIHiveMetaStoreIpAddress.java
metastore/src/test/org/apache/hadoop/hive/metastore/IpAddressListener.java
metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStoreIpAddress.java
metastore/src/java/org/apache/hadoop/hive/metastore/TUGIBasedProcessor.java
metastore/src/java/org/apache/hadoop/hive/metastore/TSetIpAddressProcessor.java
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
> Make the IP address of a Thrift client available to HMSHandler.
> ---------------------------------------------------------------
>
> Key: HIVE-2797
> URL: https://issues.apache.org/jira/browse/HIVE-2797
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-2797.D1701.1.patch, HIVE-2797.D1701.2.patch, HIVE-2797.D1701.3.patch, HIVE-2797.D1701.4.patch, HIVE-2797.D1701.5.patch
>
>
> Currently, in unsecured mode, metastore Thrift calls are, from the HMSHandler's point of view, anonymous. If we expose the IP address of the Thrift client to the HMSHandler from the Processor, this will help to give some context, in particular for audit logging, of where the call is coming from.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2797) Make the IP address of a Thrift
client available to HMSHandler.
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209026#comment-13209026 ]
Phabricator commented on HIVE-2797:
-----------------------------------
ashutoshc has commented on the revision "HIVE-2797 [jira] Make the IP address of a Thrift client available to HMSHandler.".
Looks good. Mind, adding a test for it?
REVISION DETAIL
https://reviews.facebook.net/D1701
> Make the IP address of a Thrift client available to HMSHandler.
> ---------------------------------------------------------------
>
> Key: HIVE-2797
> URL: https://issues.apache.org/jira/browse/HIVE-2797
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-2797.D1701.1.patch
>
>
> Currently, in unsecured mode, metastore Thrift calls are, from the HMSHandler's point of view, anonymous. If we expose the IP address of the Thrift client to the HMSHandler from the Processor, this will help to give some context, in particular for audit logging, of where the call is coming from.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2797) Make the IP address of a Thrift client
available to HMSHandler.
Posted by "Ashutosh Chauhan (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated HIVE-2797:
-----------------------------------
Status: Open (was: Patch Available)
Patch doesn't apply cleanly. Needs a rebase.
> Make the IP address of a Thrift client available to HMSHandler.
> ---------------------------------------------------------------
>
> Key: HIVE-2797
> URL: https://issues.apache.org/jira/browse/HIVE-2797
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-2797.D1701.1.patch, HIVE-2797.D1701.2.patch, HIVE-2797.D1701.3.patch, HIVE-2797.D1701.4.patch, HIVE-2797.D1701.5.patch
>
>
> Currently, in unsecured mode, metastore Thrift calls are, from the HMSHandler's point of view, anonymous. If we expose the IP address of the Thrift client to the HMSHandler from the Processor, this will help to give some context, in particular for audit logging, of where the call is coming from.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2797) Make the IP address of a Thrift
client available to HMSHandler.
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231249#comment-13231249 ]
Phabricator commented on HIVE-2797:
-----------------------------------
ashutoshc has requested changes to the revision "HIVE-2797 [jira] Make the IP address of a Thrift client available to HMSHandler.".
I saw multiple failures in metastore tests.
REVISION DETAIL
https://reviews.facebook.net/D1701
BRANCH
svn
> Make the IP address of a Thrift client available to HMSHandler.
> ---------------------------------------------------------------
>
> Key: HIVE-2797
> URL: https://issues.apache.org/jira/browse/HIVE-2797
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-2797.D1701.1.patch, HIVE-2797.D1701.2.patch, HIVE-2797.D1701.3.patch, HIVE-2797.D1701.4.patch
>
>
> Currently, in unsecured mode, metastore Thrift calls are, from the HMSHandler's point of view, anonymous. If we expose the IP address of the Thrift client to the HMSHandler from the Processor, this will help to give some context, in particular for audit logging, of where the call is coming from.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2797) Make the IP address of a Thrift client
available to HMSHandler.
Posted by "Ashutosh Chauhan (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated HIVE-2797:
-----------------------------------
Resolution: Fixed
Fix Version/s: 0.9.0
Status: Resolved (was: Patch Available)
Thanks, Kevin for updating the patch. Committed to trunk.
> Make the IP address of a Thrift client available to HMSHandler.
> ---------------------------------------------------------------
>
> Key: HIVE-2797
> URL: https://issues.apache.org/jira/browse/HIVE-2797
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Fix For: 0.9.0
>
> Attachments: HIVE-2797.7.patch, HIVE-2797.D1701.1.patch, HIVE-2797.D1701.2.patch, HIVE-2797.D1701.3.patch, HIVE-2797.D1701.4.patch, HIVE-2797.D1701.5.patch, HIVE-2797.D1701.6.patch
>
>
> Currently, in unsecured mode, metastore Thrift calls are, from the HMSHandler's point of view, anonymous. If we expose the IP address of the Thrift client to the HMSHandler from the Processor, this will help to give some context, in particular for audit logging, of where the call is coming from.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2797) Make the IP address of a Thrift client
available to HMSHandler.
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2797:
------------------------------
Attachment: HIVE-2797.D1701.2.patch
kevinwilfong updated the revision "HIVE-2797 [jira] Make the IP address of a Thrift client available to HMSHandler.".
Reviewers: JIRA, njain
Added a test case to check that the IP address is set for remote metastores.
REVISION DETAIL
https://reviews.facebook.net/D1701
AFFECTED FILES
metastore/src/test/org/apache/hadoop/hive/metastore/IpAddressListener.java
metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStoreIpAddress.java
metastore/src/java/org/apache/hadoop/hive/metastore/TUGIBasedProcessor.java
metastore/src/java/org/apache/hadoop/hive/metastore/TSetIpAddressProcessor.java
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
> Make the IP address of a Thrift client available to HMSHandler.
> ---------------------------------------------------------------
>
> Key: HIVE-2797
> URL: https://issues.apache.org/jira/browse/HIVE-2797
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-2797.D1701.1.patch, HIVE-2797.D1701.2.patch
>
>
> Currently, in unsecured mode, metastore Thrift calls are, from the HMSHandler's point of view, anonymous. If we expose the IP address of the Thrift client to the HMSHandler from the Processor, this will help to give some context, in particular for audit logging, of where the call is coming from.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2797) Make the IP address of a Thrift client
available to HMSHandler.
Posted by "Kevin Wilfong (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Wilfong updated HIVE-2797:
--------------------------------
Attachment: HIVE-2797.7.patch
> Make the IP address of a Thrift client available to HMSHandler.
> ---------------------------------------------------------------
>
> Key: HIVE-2797
> URL: https://issues.apache.org/jira/browse/HIVE-2797
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-2797.7.patch, HIVE-2797.D1701.1.patch, HIVE-2797.D1701.2.patch, HIVE-2797.D1701.3.patch, HIVE-2797.D1701.4.patch, HIVE-2797.D1701.5.patch, HIVE-2797.D1701.6.patch
>
>
> Currently, in unsecured mode, metastore Thrift calls are, from the HMSHandler's point of view, anonymous. If we expose the IP address of the Thrift client to the HMSHandler from the Processor, this will help to give some context, in particular for audit logging, of where the call is coming from.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2797) Make the IP address of a Thrift
client available to HMSHandler.
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233950#comment-13233950 ]
Phabricator commented on HIVE-2797:
-----------------------------------
ashutoshc has accepted the revision "HIVE-2797 [jira] Make the IP address of a Thrift client available to HMSHandler.".
No worries, Kevin. Thanks, for making changes.
+1 Feel free to commit if tests pass.
REVISION DETAIL
https://reviews.facebook.net/D1701
BRANCH
svn
> Make the IP address of a Thrift client available to HMSHandler.
> ---------------------------------------------------------------
>
> Key: HIVE-2797
> URL: https://issues.apache.org/jira/browse/HIVE-2797
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-2797.D1701.1.patch, HIVE-2797.D1701.2.patch, HIVE-2797.D1701.3.patch, HIVE-2797.D1701.4.patch, HIVE-2797.D1701.5.patch
>
>
> Currently, in unsecured mode, metastore Thrift calls are, from the HMSHandler's point of view, anonymous. If we expose the IP address of the Thrift client to the HMSHandler from the Processor, this will help to give some context, in particular for audit logging, of where the call is coming from.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2797) Make the IP address of a Thrift client
available to HMSHandler.
Posted by "Kevin Wilfong (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Wilfong updated HIVE-2797:
--------------------------------
Status: Patch Available (was: Open)
> Make the IP address of a Thrift client available to HMSHandler.
> ---------------------------------------------------------------
>
> Key: HIVE-2797
> URL: https://issues.apache.org/jira/browse/HIVE-2797
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-2797.D1701.1.patch, HIVE-2797.D1701.2.patch, HIVE-2797.D1701.3.patch, HIVE-2797.D1701.4.patch, HIVE-2797.D1701.5.patch
>
>
> Currently, in unsecured mode, metastore Thrift calls are, from the HMSHandler's point of view, anonymous. If we expose the IP address of the Thrift client to the HMSHandler from the Processor, this will help to give some context, in particular for audit logging, of where the call is coming from.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2797) Make the IP address of a Thrift client
available to HMSHandler.
Posted by "Kevin Wilfong (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Wilfong updated HIVE-2797:
--------------------------------
Status: Patch Available (was: Open)
> Make the IP address of a Thrift client available to HMSHandler.
> ---------------------------------------------------------------
>
> Key: HIVE-2797
> URL: https://issues.apache.org/jira/browse/HIVE-2797
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-2797.7.patch, HIVE-2797.D1701.1.patch, HIVE-2797.D1701.2.patch, HIVE-2797.D1701.3.patch, HIVE-2797.D1701.4.patch, HIVE-2797.D1701.5.patch, HIVE-2797.D1701.6.patch
>
>
> Currently, in unsecured mode, metastore Thrift calls are, from the HMSHandler's point of view, anonymous. If we expose the IP address of the Thrift client to the HMSHandler from the Processor, this will help to give some context, in particular for audit logging, of where the call is coming from.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2797) Make the IP address of a Thrift client
available to HMSHandler.
Posted by "Kevin Wilfong (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Wilfong updated HIVE-2797:
--------------------------------
Status: Open (was: Patch Available)
> Make the IP address of a Thrift client available to HMSHandler.
> ---------------------------------------------------------------
>
> Key: HIVE-2797
> URL: https://issues.apache.org/jira/browse/HIVE-2797
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-2797.D1701.1.patch
>
>
> Currently, in unsecured mode, metastore Thrift calls are, from the HMSHandler's point of view, anonymous. If we expose the IP address of the Thrift client to the HMSHandler from the Processor, this will help to give some context, in particular for audit logging, of where the call is coming from.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2797) Make the IP address of a Thrift client
available to HMSHandler.
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2797:
------------------------------
Attachment: HIVE-2797.D1701.1.patch
kevinwilfong requested code review of "HIVE-2797 [jira] Make the IP address of a Thrift client available to HMSHandler.".
Reviewers: JIRA
https://issues.apache.org/jira/browse/HIVE-2797
Created a new subclass of ThriftHiveMetastore.Processor which passes the IP address to the HMSHandler. Unsecure connections will use this processor. The IP address is stored in a thread local variable, so that multiple connections will each maintain there own IP address.
Currently, in unsecured mode, metastore Thrift calls are, from the HMSHandler's point of view, anonymous. If we expose the IP address of the Thrift client to the HMSHandler from the Processor, this will help to give some context, in particular for audit logging, of where the call is coming from.
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D1701
AFFECTED FILES
metastore/src/java/org/apache/hadoop/hive/metastore/TUGIBasedProcessor.java
metastore/src/java/org/apache/hadoop/hive/metastore/TSetIpAddressProcessor.java
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/3633/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Make the IP address of a Thrift client available to HMSHandler.
> ---------------------------------------------------------------
>
> Key: HIVE-2797
> URL: https://issues.apache.org/jira/browse/HIVE-2797
> Project: Hive
> Issue Type: Improvement
> Reporter: Kevin Wilfong
> Attachments: HIVE-2797.D1701.1.patch
>
>
> Currently, in unsecured mode, metastore Thrift calls are, from the HMSHandler's point of view, anonymous. If we expose the IP address of the Thrift client to the HMSHandler from the Processor, this will help to give some context, in particular for audit logging, of where the call is coming from.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2797) Make the IP address of a Thrift
client available to HMSHandler.
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233897#comment-13233897 ]
Phabricator commented on HIVE-2797:
-----------------------------------
kevinwilfong has commented on the revision "HIVE-2797 [jira] Make the IP address of a Thrift client available to HMSHandler.".
I added a test case which verifies that the IP address is accessible when the setugi config variable is true.
In addition I ran the entire test suite, TestHiveServerSessions timed out, but that seems to be an unrelated issue as it does the same on a fresh checkout.
REVISION DETAIL
https://reviews.facebook.net/D1701
> Make the IP address of a Thrift client available to HMSHandler.
> ---------------------------------------------------------------
>
> Key: HIVE-2797
> URL: https://issues.apache.org/jira/browse/HIVE-2797
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-2797.D1701.1.patch, HIVE-2797.D1701.2.patch, HIVE-2797.D1701.3.patch, HIVE-2797.D1701.4.patch, HIVE-2797.D1701.5.patch
>
>
> Currently, in unsecured mode, metastore Thrift calls are, from the HMSHandler's point of view, anonymous. If we expose the IP address of the Thrift client to the HMSHandler from the Processor, this will help to give some context, in particular for audit logging, of where the call is coming from.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2797) Make the IP address of a Thrift client
available to HMSHandler.
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2797:
------------------------------
Attachment: HIVE-2797.D1701.4.patch
kevinwilfong updated the revision "HIVE-2797 [jira] Make the IP address of a Thrift client available to HMSHandler.".
Reviewers: JIRA, njain
Ran svn up and resolved conflicts.
REVISION DETAIL
https://reviews.facebook.net/D1701
AFFECTED FILES
metastore/src/test/org/apache/hadoop/hive/metastore/IpAddressListener.java
metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStoreIpAddress.java
metastore/src/java/org/apache/hadoop/hive/metastore/TUGIBasedProcessor.java
metastore/src/java/org/apache/hadoop/hive/metastore/TSetIpAddressProcessor.java
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
> Make the IP address of a Thrift client available to HMSHandler.
> ---------------------------------------------------------------
>
> Key: HIVE-2797
> URL: https://issues.apache.org/jira/browse/HIVE-2797
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-2797.D1701.1.patch, HIVE-2797.D1701.2.patch, HIVE-2797.D1701.3.patch, HIVE-2797.D1701.4.patch
>
>
> Currently, in unsecured mode, metastore Thrift calls are, from the HMSHandler's point of view, anonymous. If we expose the IP address of the Thrift client to the HMSHandler from the Processor, this will help to give some context, in particular for audit logging, of where the call is coming from.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2797) Make the IP address of a Thrift client
available to HMSHandler.
Posted by "Kevin Wilfong (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Wilfong updated HIVE-2797:
--------------------------------
Component/s: Metastore
> Make the IP address of a Thrift client available to HMSHandler.
> ---------------------------------------------------------------
>
> Key: HIVE-2797
> URL: https://issues.apache.org/jira/browse/HIVE-2797
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Kevin Wilfong
> Attachments: HIVE-2797.D1701.1.patch
>
>
> Currently, in unsecured mode, metastore Thrift calls are, from the HMSHandler's point of view, anonymous. If we expose the IP address of the Thrift client to the HMSHandler from the Processor, this will help to give some context, in particular for audit logging, of where the call is coming from.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2797) Make the IP address of a Thrift client
available to HMSHandler.
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2797:
------------------------------
Attachment: HIVE-2797.D1701.3.patch
kevinwilfong updated the revision "HIVE-2797 [jira] Make the IP address of a Thrift client available to HMSHandler.".
Reviewers: JIRA, njain
REVISION DETAIL
https://reviews.facebook.net/D1701
AFFECTED FILES
metastore/src/test/org/apache/hadoop/hive/metastore/IpAddressListener.java
metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStoreIpAddress.java
metastore/src/java/org/apache/hadoop/hive/metastore/TUGIBasedProcessor.java
metastore/src/java/org/apache/hadoop/hive/metastore/TSetIpAddressProcessor.java
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
> Make the IP address of a Thrift client available to HMSHandler.
> ---------------------------------------------------------------
>
> Key: HIVE-2797
> URL: https://issues.apache.org/jira/browse/HIVE-2797
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-2797.D1701.1.patch, HIVE-2797.D1701.2.patch, HIVE-2797.D1701.3.patch, HIVE-2797.D1701.4.patch
>
>
> Currently, in unsecured mode, metastore Thrift calls are, from the HMSHandler's point of view, anonymous. If we expose the IP address of the Thrift client to the HMSHandler from the Processor, this will help to give some context, in particular for audit logging, of where the call is coming from.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2797) Make the IP address of a Thrift
client available to HMSHandler.
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237952#comment-13237952 ]
Hudson commented on HIVE-2797:
------------------------------
Integrated in Hive-trunk-h0.21 #1332 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1332/])
HIVE-2797: Make the IP address of a Thrift client available to HMSHandler. (Kevin Wilfong via Ashutosh Chauhan) (Revision 1305041)
Result = FAILURE
hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1305041
Files :
* /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
* /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/TSetIpAddressProcessor.java
* /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/TUGIBasedProcessor.java
* /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/IpAddressListener.java
* /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStoreIpAddress.java
* /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteUGIHiveMetaStoreIpAddress.java
* /hive/trunk/shims/src/common/java/org/apache/hadoop/hive/thrift/TUGIContainingTransport.java
> Make the IP address of a Thrift client available to HMSHandler.
> ---------------------------------------------------------------
>
> Key: HIVE-2797
> URL: https://issues.apache.org/jira/browse/HIVE-2797
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Fix For: 0.9.0
>
> Attachments: HIVE-2797.7.patch, HIVE-2797.D1701.1.patch, HIVE-2797.D1701.2.patch, HIVE-2797.D1701.3.patch, HIVE-2797.D1701.4.patch, HIVE-2797.D1701.5.patch, HIVE-2797.D1701.6.patch
>
>
> Currently, in unsecured mode, metastore Thrift calls are, from the HMSHandler's point of view, anonymous. If we expose the IP address of the Thrift client to the HMSHandler from the Processor, this will help to give some context, in particular for audit logging, of where the call is coming from.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2797) Make the IP address of a Thrift
client available to HMSHandler.
Posted by "Ashutosh Chauhan (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235864#comment-13235864 ]
Ashutosh Chauhan commented on HIVE-2797:
----------------------------------------
Latest patch fails to apply with following in shims/src/common/java/org/apache/hadoop/hive/thrift/TUGIContainingTransport.java.rej
{code}
***************
*** 71,74 ****
return transMap.get(trans);
}
}
- }
--- 85,88 ----
return transMap.get(trans);
}
}
+ }
{code}
> Make the IP address of a Thrift client available to HMSHandler.
> ---------------------------------------------------------------
>
> Key: HIVE-2797
> URL: https://issues.apache.org/jira/browse/HIVE-2797
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-2797.D1701.1.patch, HIVE-2797.D1701.2.patch, HIVE-2797.D1701.3.patch, HIVE-2797.D1701.4.patch, HIVE-2797.D1701.5.patch, HIVE-2797.D1701.6.patch
>
>
> Currently, in unsecured mode, metastore Thrift calls are, from the HMSHandler's point of view, anonymous. If we expose the IP address of the Thrift client to the HMSHandler from the Processor, this will help to give some context, in particular for audit logging, of where the call is coming from.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2797) Make the IP address of a Thrift client
available to HMSHandler.
Posted by "Kevin Wilfong (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Wilfong updated HIVE-2797:
--------------------------------
Assignee: Kevin Wilfong
Status: Patch Available (was: Open)
> Make the IP address of a Thrift client available to HMSHandler.
> ---------------------------------------------------------------
>
> Key: HIVE-2797
> URL: https://issues.apache.org/jira/browse/HIVE-2797
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-2797.D1701.1.patch
>
>
> Currently, in unsecured mode, metastore Thrift calls are, from the HMSHandler's point of view, anonymous. If we expose the IP address of the Thrift client to the HMSHandler from the Processor, this will help to give some context, in particular for audit logging, of where the call is coming from.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2797) Make the IP address of a Thrift
client available to HMSHandler.
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230794#comment-13230794 ]
Phabricator commented on HIVE-2797:
-----------------------------------
ashutoshc has accepted the revision "HIVE-2797 [jira] Make the IP address of a Thrift client available to HMSHandler.".
Thanks for adding test-case, Kevin.
+1 will commit if tests pass.
REVISION DETAIL
https://reviews.facebook.net/D1701
BRANCH
svn
> Make the IP address of a Thrift client available to HMSHandler.
> ---------------------------------------------------------------
>
> Key: HIVE-2797
> URL: https://issues.apache.org/jira/browse/HIVE-2797
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-2797.D1701.1.patch, HIVE-2797.D1701.2.patch, HIVE-2797.D1701.3.patch, HIVE-2797.D1701.4.patch
>
>
> Currently, in unsecured mode, metastore Thrift calls are, from the HMSHandler's point of view, anonymous. If we expose the IP address of the Thrift client to the HMSHandler from the Processor, this will help to give some context, in particular for audit logging, of where the call is coming from.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2797) Make the IP address of a Thrift
client available to HMSHandler.
Posted by "Kevin Wilfong (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237754#comment-13237754 ]
Kevin Wilfong commented on HIVE-2797:
-------------------------------------
Looks like something my editor must have done automatically, something about adding or removing a new line at the end of files. Anyway, I removed those lines from the patch manually (I hadn't intended to change that line anyway). HIVE-2797.7.patch contains this, and I tried applying it to a fresh checkout and did not get that error.
> Make the IP address of a Thrift client available to HMSHandler.
> ---------------------------------------------------------------
>
> Key: HIVE-2797
> URL: https://issues.apache.org/jira/browse/HIVE-2797
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-2797.7.patch, HIVE-2797.D1701.1.patch, HIVE-2797.D1701.2.patch, HIVE-2797.D1701.3.patch, HIVE-2797.D1701.4.patch, HIVE-2797.D1701.5.patch, HIVE-2797.D1701.6.patch
>
>
> Currently, in unsecured mode, metastore Thrift calls are, from the HMSHandler's point of view, anonymous. If we expose the IP address of the Thrift client to the HMSHandler from the Processor, this will help to give some context, in particular for audit logging, of where the call is coming from.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2797) Make the IP address of a Thrift client
available to HMSHandler.
Posted by "Kevin Wilfong (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Wilfong updated HIVE-2797:
--------------------------------
Status: Patch Available (was: Open)
> Make the IP address of a Thrift client available to HMSHandler.
> ---------------------------------------------------------------
>
> Key: HIVE-2797
> URL: https://issues.apache.org/jira/browse/HIVE-2797
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-2797.D1701.1.patch, HIVE-2797.D1701.2.patch
>
>
> Currently, in unsecured mode, metastore Thrift calls are, from the HMSHandler's point of view, anonymous. If we expose the IP address of the Thrift client to the HMSHandler from the Processor, this will help to give some context, in particular for audit logging, of where the call is coming from.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2797) Make the IP address of a Thrift client
available to HMSHandler.
Posted by "Kevin Wilfong (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Wilfong updated HIVE-2797:
--------------------------------
Status: Open (was: Patch Available)
> Make the IP address of a Thrift client available to HMSHandler.
> ---------------------------------------------------------------
>
> Key: HIVE-2797
> URL: https://issues.apache.org/jira/browse/HIVE-2797
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-2797.D1701.1.patch, HIVE-2797.D1701.2.patch, HIVE-2797.D1701.3.patch, HIVE-2797.D1701.4.patch
>
>
> Currently, in unsecured mode, metastore Thrift calls are, from the HMSHandler's point of view, anonymous. If we expose the IP address of the Thrift client to the HMSHandler from the Processor, this will help to give some context, in particular for audit logging, of where the call is coming from.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2797) Make the IP address of a Thrift client
available to HMSHandler.
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2797:
------------------------------
Attachment: HIVE-2797.D1701.6.patch
kevinwilfong updated the revision "HIVE-2797 [jira] Make the IP address of a Thrift client available to HMSHandler.".
Reviewers: JIRA, njain, ashutoshc
Ran updated my checkout.
REVISION DETAIL
https://reviews.facebook.net/D1701
AFFECTED FILES
shims/src/common/java/org/apache/hadoop/hive/thrift/TUGIContainingTransport.java
metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteUGIHiveMetaStoreIpAddress.java
metastore/src/test/org/apache/hadoop/hive/metastore/IpAddressListener.java
metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStoreIpAddress.java
metastore/src/java/org/apache/hadoop/hive/metastore/TUGIBasedProcessor.java
metastore/src/java/org/apache/hadoop/hive/metastore/TSetIpAddressProcessor.java
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
> Make the IP address of a Thrift client available to HMSHandler.
> ---------------------------------------------------------------
>
> Key: HIVE-2797
> URL: https://issues.apache.org/jira/browse/HIVE-2797
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-2797.D1701.1.patch, HIVE-2797.D1701.2.patch, HIVE-2797.D1701.3.patch, HIVE-2797.D1701.4.patch, HIVE-2797.D1701.5.patch, HIVE-2797.D1701.6.patch
>
>
> Currently, in unsecured mode, metastore Thrift calls are, from the HMSHandler's point of view, anonymous. If we expose the IP address of the Thrift client to the HMSHandler from the Processor, this will help to give some context, in particular for audit logging, of where the call is coming from.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira