You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2007/09/29 02:59:14 UTC
[Bug 5547] calculate_expire_delta return value in BayesStore SQL.pm causes Perl warning
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5547
------- Additional Comments From peter@unlikejam.dreamhost.com 2007-09-28 17:59 -------
If possible, could this trivial patch be reviewed for 3.2.4? In the mean time I
have been manually patching local installations and the patch resolves the
warning. See also #5661 related to SQL.pm. Cheers.
(In reply to comment #0)
> The calculate_expire_delta function in BayesStore/SQL.pm can return undef,
> which creates a warning (turns up in procmail logs):
> warn: Odd number of elements in hash assignment at BayesStore.pm line 322.
> warn: Use of uninitialized value in list assignment at BayesStore.pm line 322.
>
> It should probably return an empty hash at that point (as per the patch), since
> %delta may have information in it by that stage which we don't want to return,
> since the function didn't complete.
>
> Also need to make sure that the expected behaviour of "return 0 unless
> (%delta);" is maintained in BayesStore.pm, after this call is made:
> my %delta = $self->calculate_expire_delta($vars[10], $start, $max_expire_mult);
>
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.