[jira] [Commented] (HIVE-17117) Metalisteners are not notified when threadlocal metaconf is cleanup

["PRASHANT GOLASH (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-17117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092145#comment-16092145 ] 

PRASHANT GOLASH commented on HIVE-17117:
----------------------------------------

Made a change to notify meta listeners during shutdown.

Also added unit test cases.

> Metalisteners are not notified when threadlocal metaconf is cleanup 
> --------------------------------------------------------------------
>
>                 Key: HIVE-17117
>                 URL: https://issues.apache.org/jira/browse/HIVE-17117
>             Project: Hive
>          Issue Type: Bug
>          Components: Metastore
>         Environment: Tested on master branch (Applicable for downlevel versions as well)
>            Reporter: PRASHANT GOLASH
>            Priority: Minor
>         Attachments: HIVE-17117.patch
>
>
> Meta listeners are not notified of meta-conf cleanup. This could potentially leave stale values on listeners objects. For e.g.
> Request1
> a. HS2 -> HMS : HMSHandler#setMetaConf
>      MetaListeners are notified of the ConfigChangeEvent.
> b. HS2 -> HMS : HMSHandler#shutdown / HiveMetaStore#deleteContext (if shutdown is not invoked)
>     MetaConf is cleaned up in HiveMetaStore#cleanupRawStore, but meta listeners are not notified
> Request 2
> 3. HS2->HMS : AlterPartition
>      MetaListeners are notified of AlterPartitionEvent. If any listener has taken dependency on the meta conf value, it will still be having stale value from Request1 and would potentially be having issues.
> The correct behavior should be to notify meta listeners on cleanup as well.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)