You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by or...@apache.org on 2022/08/31 07:14:36 UTC
[camel] 02/03: (chores) camel-jms: use final when possible
This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
commit d43bb0c8605b2b9199a18e36b1db3203f6b9a0ed
Author: Otavio Rodolfo Piske <an...@gmail.com>
AuthorDate: Tue Aug 30 17:10:04 2022 +0200
(chores) camel-jms: use final when possible
---
.../java/org/apache/camel/component/jms/JmsPollingConsumer.java | 4 ++--
.../org/apache/camel/component/jms/reply/QueueReplyManager.java | 3 +--
.../org/apache/camel/component/jms/reply/ReplyManagerSupport.java | 1 -
.../jms/reply/UseMessageIdAsCorrelationIdMessageSentCallback.java | 6 +++---
4 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/components/camel-jms/src/main/java/org/apache/camel/component/jms/JmsPollingConsumer.java b/components/camel-jms/src/main/java/org/apache/camel/component/jms/JmsPollingConsumer.java
index 049b7ebe08e..9d61d9d7841 100644
--- a/components/camel-jms/src/main/java/org/apache/camel/component/jms/JmsPollingConsumer.java
+++ b/components/camel-jms/src/main/java/org/apache/camel/component/jms/JmsPollingConsumer.java
@@ -29,8 +29,8 @@ import org.springframework.jms.support.destination.JmsDestinationAccessor;
* A JMS {@link org.apache.camel.PollingConsumer}.
*/
public class JmsPollingConsumer extends PollingConsumerSupport {
- private JmsOperations template;
- private JmsEndpoint jmsEndpoint;
+ private final JmsOperations template;
+ private final JmsEndpoint jmsEndpoint;
public JmsPollingConsumer(JmsEndpoint endpoint, JmsOperations template) {
super(endpoint);
diff --git a/components/camel-jms/src/main/java/org/apache/camel/component/jms/reply/QueueReplyManager.java b/components/camel-jms/src/main/java/org/apache/camel/component/jms/reply/QueueReplyManager.java
index 87412e5a92e..0d393d0aeda 100644
--- a/components/camel-jms/src/main/java/org/apache/camel/component/jms/reply/QueueReplyManager.java
+++ b/components/camel-jms/src/main/java/org/apache/camel/component/jms/reply/QueueReplyManager.java
@@ -29,7 +29,6 @@ import org.apache.camel.CamelContext;
import org.apache.camel.Exchange;
import org.apache.camel.component.jms.ConsumerType;
import org.apache.camel.component.jms.DefaultSpringErrorHandler;
-import org.apache.camel.component.jms.JmsEndpoint;
import org.apache.camel.component.jms.MessageListenerContainerFactory;
import org.apache.camel.component.jms.ReplyToType;
import org.apache.camel.component.jms.SimpleJmsMessageListenerContainer;
@@ -101,7 +100,7 @@ public class QueueReplyManager extends ReplyManagerSupport {
}
private final class DestinationResolverDelegate implements DestinationResolver {
- private DestinationResolver delegate;
+ private final DestinationResolver delegate;
private Destination destination;
DestinationResolverDelegate(DestinationResolver delegate) {
diff --git a/components/camel-jms/src/main/java/org/apache/camel/component/jms/reply/ReplyManagerSupport.java b/components/camel-jms/src/main/java/org/apache/camel/component/jms/reply/ReplyManagerSupport.java
index f69cf5bd63b..08a0eb8f223 100644
--- a/components/camel-jms/src/main/java/org/apache/camel/component/jms/reply/ReplyManagerSupport.java
+++ b/components/camel-jms/src/main/java/org/apache/camel/component/jms/reply/ReplyManagerSupport.java
@@ -301,7 +301,6 @@ public abstract class ReplyManagerSupport extends ServiceSupport implements Repl
}
}
-
protected static void setupClientId(JmsEndpoint endpoint, DefaultMessageListenerContainer answer) {
String clientId = endpoint.getClientId();
if (clientId != null) {
diff --git a/components/camel-jms/src/main/java/org/apache/camel/component/jms/reply/UseMessageIdAsCorrelationIdMessageSentCallback.java b/components/camel-jms/src/main/java/org/apache/camel/component/jms/reply/UseMessageIdAsCorrelationIdMessageSentCallback.java
index 0419db4e372..83e6a2d14b3 100644
--- a/components/camel-jms/src/main/java/org/apache/camel/component/jms/reply/UseMessageIdAsCorrelationIdMessageSentCallback.java
+++ b/components/camel-jms/src/main/java/org/apache/camel/component/jms/reply/UseMessageIdAsCorrelationIdMessageSentCallback.java
@@ -32,9 +32,9 @@ import static org.apache.camel.component.jms.JmsMessageHelper.getJMSMessageID;
*/
public class UseMessageIdAsCorrelationIdMessageSentCallback implements MessageSentCallback {
- private ReplyManager replyManager;
- private String correlationId;
- private long requestTimeout;
+ private final ReplyManager replyManager;
+ private final String correlationId;
+ private final long requestTimeout;
public UseMessageIdAsCorrelationIdMessageSentCallback(ReplyManager replyManager, String correlationId,
long requestTimeout) {