You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2022/03/14 06:43:20 UTC

[GitHub] [buildstream] gtristan commented on pull request #1546: _yaml.pyx: port roundtripping code to the new ruamel.yaml API

gtristan commented on pull request #1546:
URL: https://github.com/apache/buildstream/pull/1546#issuecomment-1066433850


   > I've made it so a new instance is created on each call (like it was previously). I can explore thread local storage if you think it's worth it.
   
   I don't see that change here, in master `Messenger` has `_MessengerLocal` which is TLS for the messenger.
   
   Also, can we check if this change fixes `tests/internals/yaml.py::test_roundtrip_dump` which we currently have on XFAIL ?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org