[GitHub] [superset] pkdotson commented on a diff in pull request #20017: feat: hack db connection modal ctabtns

[GitBox <gi...@apache.org>]

pkdotson commented on code in PR #20017:
URL: https://github.com/apache/superset/pull/20017#discussion_r913913461


##########
superset-frontend/src/components/DatabaseSelector/index.tsx:
##########
@@ -87,7 +87,7 @@ export type DatabaseObject = {
 type SchemaValue = { label: string; value: string };
 
 export interface DatabaseSelectorProps {
-  db?: DatabaseObject;
+  db?: DatabaseObject | null | undefined;

Review Comment:
   I think i was trying to appease ts in on the props. But I removed and no issue came about



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org