You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/27 06:55:13 UTC

[GitHub] [spark] maropu commented on pull request #30212: [SPARK-33308][SQL] Refract current grouping analytics

maropu commented on pull request #30212:
URL: https://github.com/apache/spark/pull/30212#issuecomment-734677252


   > In postgres sql, it support
   >> select a, b, c, count(1) from t group by a, b, cube(a, b, c);
   select a, b, c, count(1) from t group by a, c, grouping sets (a, b, (a, b));
   
   Could you remove the two PostgreSQL examples above in the PR description? I think the examples is out-of-scope of this PR and they make reviewers confused.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org