You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/06/30 15:45:10 UTC

[GitHub] [echarts] 100pah commented on pull request #14995: fix: update conditions in 'indicesOfNearest' for custom series. close #14869

100pah commented on pull request #14995:
URL: https://github.com/apache/echarts/pull/14995#issuecomment-871516183


   @pissang @plainheart @AndrewRatnikov 
   
   I think this issue can not be resolved by change the condition when finding "nearest data".
   (This PR seems do not change the effect).
   
   To resolve this issue, I think we probably enhance the strategy from "finding the nearest data item" to "finding nearest graphic element". "finding the nearest data item" is only suitable to charts like `scatter`, where all of the elements are the same. For series with variable size of elements, we should better travel the elements and find the one that is nearest to the axis pointer. The travel could be based on `List#getItemGraphicEl()`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org