You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/05 21:36:03 UTC

[GitHub] [airflow] potiuk commented on a change in pull request #9157: Parameterized bash/python in the prod image

potiuk commented on a change in pull request #9157:
URL: https://github.com/apache/airflow/pull/9157#discussion_r436174691



##########
File path: entrypoint.sh
##########
@@ -103,7 +103,11 @@ if [[ -n ${AIRFLOW__CELERY__BROKER_URL} ]] && \
 fi
 
 if [[ ${AIRFLOW_COMMAND} == "bash" ]]; then
-   exec "/bin/bash"
+   shift
+   exec "/bin/bash" "${@}"
+elif [[ ${AIRFLOW_COMMAND} == "python" ]]; then
+   shift
+   exec "python" "${@}"

Review comment:
       I don't think there is a need. The image to choose from 'python2.7, 3.5, 3.6.... " determines what's the python version used. I think we should always use "python" and we get the right version automagically.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org