You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Yun Lee (JIRA)" <ji...@apache.org> on 2010/08/10 17:58:17 UTC
[jira] Created: (DERBY-4765) Convert
"org.apache.derbyTesting.functionTests.tests.derbynet.DerbyNetNewServer" to
junit.
Convert "org.apache.derbyTesting.functionTests.tests.derbynet.DerbyNetNewServer" to junit.
------------------------------------------------------------------------------------------
Key: DERBY-4765
URL: https://issues.apache.org/jira/browse/DERBY-4765
Project: Derby
Issue Type: Task
Components: Test
Reporter: Yun Lee
Assignee: Yun Lee
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-4765) Convert
"org.apache.derbyTesting.functionTests.tests.derbynet.DerbyNetNewServer" to
junit.
Posted by "Yun Lee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yun Lee updated DERBY-4765:
---------------------------
Attachment: derby-4765.stat
derby-4765.patch
> Convert "org.apache.derbyTesting.functionTests.tests.derbynet.DerbyNetNewServer" to junit.
> ------------------------------------------------------------------------------------------
>
> Key: DERBY-4765
> URL: https://issues.apache.org/jira/browse/DERBY-4765
> Project: Derby
> Issue Type: Task
> Components: Test
> Reporter: Yun Lee
> Assignee: Yun Lee
> Attachments: derby-4765.patch, derby-4765.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-4765) Convert
"org.apache.derbyTesting.functionTests.tests.derbynet.DerbyNetNewServer" to
junit.
Posted by "Yun Lee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yun Lee updated DERBY-4765:
---------------------------
Issue & fix info: [Patch Available]
> Convert "org.apache.derbyTesting.functionTests.tests.derbynet.DerbyNetNewServer" to junit.
> ------------------------------------------------------------------------------------------
>
> Key: DERBY-4765
> URL: https://issues.apache.org/jira/browse/DERBY-4765
> Project: Derby
> Issue Type: Task
> Components: Test
> Reporter: Yun Lee
> Assignee: Yun Lee
> Attachments: derby-4765.patch, derby-4765.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4765) Convert
"org.apache.derbyTesting.functionTests.tests.derbynet.DerbyNetNewServer" to
junit.
Posted by "Myrna van Lunteren (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898027#action_12898027 ]
Myrna van Lunteren commented on DERBY-4765:
-------------------------------------------
Thanks for this patch!
These are my comments:
- the old test was activated from NetHarnessTest.java. You can see there, that it cannot run with J2ME.
This needs to be preserved. You need to add the appropriate check - if (JDBC.vmSupportsJDBC3()) - to the suite() method, and it needs to go into a special section, with comments, in derbynet._Suite.java
- I don't see that there's any checking done for a successful start of the networkserver. This can be accomplished by calling NetworkServerTestSetup. waitForServerStart(NetworkServerControl networkServerController)
nits:
- the old test needs to be removed from NetHarnessTest.java
- we've lost the comment of DERBY-1466. It's an explanation of why there's no setting of setting of 'autoflush'. I think it makes sense to preserve that comment.
> Convert "org.apache.derbyTesting.functionTests.tests.derbynet.DerbyNetNewServer" to junit.
> ------------------------------------------------------------------------------------------
>
> Key: DERBY-4765
> URL: https://issues.apache.org/jira/browse/DERBY-4765
> Project: Derby
> Issue Type: Task
> Components: Test
> Reporter: Yun Lee
> Assignee: Yun Lee
> Attachments: derby-4765.patch, derby-4765.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DERBY-4765) Convert
"org.apache.derbyTesting.functionTests.tests.derbynet.DerbyNetNewServer" to
junit.
Posted by "Yun Lee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yun Lee closed DERBY-4765.
--------------------------
Thanks, Myrna!
> Convert "org.apache.derbyTesting.functionTests.tests.derbynet.DerbyNetNewServer" to junit.
> ------------------------------------------------------------------------------------------
>
> Key: DERBY-4765
> URL: https://issues.apache.org/jira/browse/DERBY-4765
> Project: Derby
> Issue Type: Task
> Components: Test
> Reporter: Yun Lee
> Assignee: Yun Lee
> Fix For: 10.7.0.0
>
> Attachments: derby-4765-1.patch, derby-4765-1.stat, derby-4765.patch, derby-4765.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-4765) Convert
"org.apache.derbyTesting.functionTests.tests.derbynet.DerbyNetNewServer" to
junit.
Posted by "Yun Lee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yun Lee updated DERBY-4765:
---------------------------
Attachment: (was: derby-4767-1.stat)
> Convert "org.apache.derbyTesting.functionTests.tests.derbynet.DerbyNetNewServer" to junit.
> ------------------------------------------------------------------------------------------
>
> Key: DERBY-4765
> URL: https://issues.apache.org/jira/browse/DERBY-4765
> Project: Derby
> Issue Type: Task
> Components: Test
> Reporter: Yun Lee
> Assignee: Yun Lee
> Attachments: derby-4765-1.patch, derby-4765-1.stat, derby-4765.patch, derby-4765.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-4765) Convert
"org.apache.derbyTesting.functionTests.tests.derbynet.DerbyNetNewServer" to
junit.
Posted by "Yun Lee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yun Lee updated DERBY-4765:
---------------------------
Attachment: derby-4767-1.stat
derby-4767-1.patch
Hi, Myrna. Thanks for your advice! I've improved my patch, and submitted a new one, please check it, thanks!
> Convert "org.apache.derbyTesting.functionTests.tests.derbynet.DerbyNetNewServer" to junit.
> ------------------------------------------------------------------------------------------
>
> Key: DERBY-4765
> URL: https://issues.apache.org/jira/browse/DERBY-4765
> Project: Derby
> Issue Type: Task
> Components: Test
> Reporter: Yun Lee
> Assignee: Yun Lee
> Attachments: derby-4765.patch, derby-4765.stat, derby-4767-1.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-4765) Convert
"org.apache.derbyTesting.functionTests.tests.derbynet.DerbyNetNewServer" to
junit.
Posted by "Yun Lee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yun Lee updated DERBY-4765:
---------------------------
Attachment: (was: derby-4767-1.patch)
> Convert "org.apache.derbyTesting.functionTests.tests.derbynet.DerbyNetNewServer" to junit.
> ------------------------------------------------------------------------------------------
>
> Key: DERBY-4765
> URL: https://issues.apache.org/jira/browse/DERBY-4765
> Project: Derby
> Issue Type: Task
> Components: Test
> Reporter: Yun Lee
> Assignee: Yun Lee
> Attachments: derby-4765.patch, derby-4765.stat, derby-4767-1.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DERBY-4765) Convert
"org.apache.derbyTesting.functionTests.tests.derbynet.DerbyNetNewServer" to
junit.
Posted by "Myrna van Lunteren (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Myrna van Lunteren resolved DERBY-4765.
---------------------------------------
Issue & fix info: (was: [Patch Available])
Fix Version/s: 10.7.0.0
Resolution: Fixed
Thanks Yun for the updated patch.
I made 3 tiny changes:
- changed the text for the asserts because it suggested the pings would add text to the log; they don't (in the original test, the connections did, but now it's only the start and shutdown text).
- moved the assert for empty log up to before the server.start
This seems a bit superfluous, but I wanted to prevent the -unlikely- situation that the text would already be there by the time the assert was done; which could possibly result in false failures.
- rearranged the tests in _Suite.java so there's only one if (JDBC.vmSupportsJDBC3()) block.
committed with revision 985400.
> Convert "org.apache.derbyTesting.functionTests.tests.derbynet.DerbyNetNewServer" to junit.
> ------------------------------------------------------------------------------------------
>
> Key: DERBY-4765
> URL: https://issues.apache.org/jira/browse/DERBY-4765
> Project: Derby
> Issue Type: Task
> Components: Test
> Reporter: Yun Lee
> Assignee: Yun Lee
> Fix For: 10.7.0.0
>
> Attachments: derby-4765-1.patch, derby-4765-1.stat, derby-4765.patch, derby-4765.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4765) Convert
"org.apache.derbyTesting.functionTests.tests.derbynet.DerbyNetNewServer" to
junit.
Posted by "Yun Lee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12896919#action_12896919 ]
Yun Lee commented on DERBY-4765:
--------------------------------
Please check the patch. Any comment is welcome.
> Convert "org.apache.derbyTesting.functionTests.tests.derbynet.DerbyNetNewServer" to junit.
> ------------------------------------------------------------------------------------------
>
> Key: DERBY-4765
> URL: https://issues.apache.org/jira/browse/DERBY-4765
> Project: Derby
> Issue Type: Task
> Components: Test
> Reporter: Yun Lee
> Assignee: Yun Lee
> Attachments: derby-4765.patch, derby-4765.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-4765) Convert
"org.apache.derbyTesting.functionTests.tests.derbynet.DerbyNetNewServer" to
junit.
Posted by "Yun Lee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yun Lee updated DERBY-4765:
---------------------------
Attachment: derby-4765-1.patch
derby-4765-1.stat
> Convert "org.apache.derbyTesting.functionTests.tests.derbynet.DerbyNetNewServer" to junit.
> ------------------------------------------------------------------------------------------
>
> Key: DERBY-4765
> URL: https://issues.apache.org/jira/browse/DERBY-4765
> Project: Derby
> Issue Type: Task
> Components: Test
> Reporter: Yun Lee
> Assignee: Yun Lee
> Attachments: derby-4765-1.patch, derby-4765-1.stat, derby-4765.patch, derby-4765.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.