[jira] [Commented] (GIRAPH-1213) Fix issues with network requests retries and add more logging

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GIRAPH-1213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717744#comment-16717744 ] 

ASF GitHub Bot commented on GIRAPH-1213:
----------------------------------------

Github user dlogothetis commented on a diff in the pull request:

    https://github.com/apache/giraph/pull/96#discussion_r239255770
  
    --- Diff: giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyClient.java ---
    @@ -1147,8 +1158,11 @@ private void checkRequestsAfterChannelFailure(final Channel channel) {
         resendRequestsWhenNeeded(new Predicate<RequestInfo>() {
           @Override
           public boolean apply(RequestInfo requestInfo) {
    -        return requestInfo.getDestinationAddress().equals(
    -            channel.remoteAddress());
    +        if (requestInfo.getWriteFuture() == null ||
    --- End diff --
    
    When is this condition true?


> Fix issues with network requests retries and add more logging
> -------------------------------------------------------------
>
>                 Key: GIRAPH-1213
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-1213
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Maja Kabiljo
>            Assignee: Maja Kabiljo
>            Priority: Major
>
> Fixing two bugs:
>  * When channel fails, we are currently retrying all requests towards the destination machine from the channel, instead of just ones which are happening on the concrete channel.
>  * In practice, we've noticed BlockingOperationException can get thrown when we wait to connect on channel in which case we silently don't send the request we are trying to send, so catching this exception and retrying instead.
> Also added logging of channel ids to be able to debug issues related to network requests not delivering easier.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)