You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "David Knupp (Code Review)" <ge...@cloudera.org> on 2020/04/27 17:30:46 UTC
[Impala-ASF-CR] IMPALA-9648: Don't ban netty 3* from fe/pom.xml
David Knupp has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15819
Change subject: IMPALA-9648: Don't ban netty 3* from fe/pom.xml
......................................................................
IMPALA-9648: Don't ban netty 3* from fe/pom.xml
netty-all < 4.14.46 and netty < 3.10.6 were banned in any earlier patch,
but we have found that in some environments, netty 3.10.5 is still present,
so this can cause build failures. The ban on netty-all is not an issue.
While we sort what needs to be done with regard to netty 3.10.5, we'll
temporarily remove the ban. This change may become permanent based on
further investigation.
Change-Id: Ib1a55f22f1925872c0d19aaf0670404203dcca54
---
M fe/pom.xml
1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/15819/1
--
To view, visit http://gerrit.cloudera.org:8080/15819
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib1a55f22f1925872c0d19aaf0670404203dcca54
Gerrit-Change-Number: 15819
Gerrit-PatchSet: 1
Gerrit-Owner: David Knupp <dk...@cloudera.com>
[Impala-ASF-CR] IMPALA-9648: Don't ban netty 3* from fe/pom.xml
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15819 )
Change subject: IMPALA-9648: Don't ban netty 3* from fe/pom.xml
......................................................................
IMPALA-9648: Don't ban netty 3* from fe/pom.xml
netty-all < 4.14.46 and netty < 3.10.6 were banned in any earlier patch,
but we have found that in some environments, netty 3.10.5 is still present,
so this can cause build failures. The ban on netty-all is not an issue.
While we sort what needs to be done with regard to netty 3.10.5, we'll
temporarily remove the ban. This change may become permanent based on
further investigation.
Change-Id: Ib1a55f22f1925872c0d19aaf0670404203dcca54
Reviewed-on: http://gerrit.cloudera.org:8080/15819
Reviewed-by: Csaba Ringhofer <cs...@cloudera.com>
Tested-by: David Knupp <dk...@cloudera.com>
---
M fe/pom.xml
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
Csaba Ringhofer: Looks good to me, approved
David Knupp: Verified
--
To view, visit http://gerrit.cloudera.org:8080/15819
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib1a55f22f1925872c0d19aaf0670404203dcca54
Gerrit-Change-Number: 15819
Gerrit-PatchSet: 2
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-9648: Don't ban netty 3* from fe/pom.xml
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15819 )
Change subject: IMPALA-9648: Don't ban netty 3* from fe/pom.xml
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/15819
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1a55f22f1925872c0d19aaf0670404203dcca54
Gerrit-Change-Number: 15819
Gerrit-PatchSet: 1
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Apr 2020 17:35:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9648: Don't ban netty 3* from fe/pom.xml
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15819 )
Change subject: IMPALA-9648: Don't ban netty 3* from fe/pom.xml
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15819
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1a55f22f1925872c0d19aaf0670404203dcca54
Gerrit-Change-Number: 15819
Gerrit-PatchSet: 1
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Apr 2020 17:33:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9648: Don't ban netty 3* from fe/pom.xml
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15819 )
Change subject: IMPALA-9648: Don't ban netty 3* from fe/pom.xml
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5887/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15819
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1a55f22f1925872c0d19aaf0670404203dcca54
Gerrit-Change-Number: 15819
Gerrit-PatchSet: 1
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Apr 2020 18:15:33 +0000
Gerrit-HasComments: No