[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #7053: Fix bug for AggregateMetrics rule in Recommendation Engine

[GitBox <gi...@apache.org>]

siddharthteotia commented on a change in pull request #7053:
URL: https://github.com/apache/incubator-pinot/pull/7053#discussion_r650280778



##########
File path: pinot-controller/src/main/java/org/apache/pinot/controller/recommender/rules/impl/AggregateMetricsRule.java
##########
@@ -68,6 +78,14 @@ private boolean shouldAggregate(InputManager inputManager) {
     return true;
   }
 
+  private Set<String> getGroupByColumnNames(QueryContext queryContext) {
+    List<ExpressionContext> groupByExprs = queryContext.getGroupByExpressions();

Review comment:
       This won't work if the group by expression is a transform function? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org