You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/04/18 01:37:35 UTC

[GitHub] [rocketmq] ltamber commented on a diff in pull request #4176: [ISSUE #4175] Prevent update topic on slave

ltamber commented on code in PR #4176:
URL: https://github.com/apache/rocketmq/pull/4176#discussion_r851832041


##########
broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java:
##########
@@ -1636,4 +1649,14 @@ private MessageExtBrokerInner toMessageExtBrokerInner(MessageExt msgExt) {
         inner.setWaitStoreMsgOK(false);
         return inner;
     }
+
+    private boolean validateSlave(RemotingCommand response) {

Review Comment:
   I think the method name `validateSlave` meaning only check but not modify, maybe we should use a name mean `adjust response if slave`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org