You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ignite.apache.org by nt...@apache.org on 2016/02/01 15:27:07 UTC
[12/48] ignite git commit: IGNITE-2324: .NET: Added static code
analysis rules and suppressed warnings accordingly.
http://git-wip-us.apache.org/repos/asf/ignite/blob/a34d7058/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Cache/CacheImpl.cs
----------------------------------------------------------------------
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Cache/CacheImpl.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Cache/CacheImpl.cs
index dbb58c8..f55863e 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Cache/CacheImpl.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Cache/CacheImpl.cs
@@ -1000,36 +1000,46 @@ namespace Apache.Ignite.Core.Impl.Cache
/// <summary>
/// QueryContinuous implementation.
/// </summary>
- private IContinuousQueryHandle<ICacheEntry<TK, TV>> QueryContinuousImpl(ContinuousQuery<TK, TV> qry,
+ private IContinuousQueryHandle<ICacheEntry<TK, TV>> QueryContinuousImpl(ContinuousQuery<TK, TV> qry,
QueryBase initialQry)
{
qry.Validate();
var hnd = new ContinuousQueryHandleImpl<TK, TV>(qry, Marshaller, _flagKeepBinary);
- using (var stream = IgniteManager.Memory.Allocate().GetStream())
+ try
{
- var writer = Marshaller.StartMarshal(stream);
-
- hnd.Start(_ignite, writer, () =>
+ using (var stream = IgniteManager.Memory.Allocate().GetStream())
{
- if (initialQry != null)
+ var writer = Marshaller.StartMarshal(stream);
+
+ hnd.Start(_ignite, writer, () =>
{
- writer.WriteInt((int) initialQry.OpId);
+ if (initialQry != null)
+ {
+ writer.WriteInt((int) initialQry.OpId);
- initialQry.Write(writer, IsKeepBinary);
- }
- else
- writer.WriteInt(-1); // no initial query
+ initialQry.Write(writer, IsKeepBinary);
+ }
+ else
+ writer.WriteInt(-1); // no initial query
- FinishMarshal(writer);
+ FinishMarshal(writer);
- // ReSharper disable once AccessToDisposedClosure
- return UU.CacheOutOpContinuousQuery(Target, (int)CacheOp.QryContinuous, stream.SynchronizeOutput());
- }, qry);
+ // ReSharper disable once AccessToDisposedClosure
+ return UU.CacheOutOpContinuousQuery(Target, (int) CacheOp.QryContinuous,
+ stream.SynchronizeOutput());
+ }, qry);
+ }
+
+ return hnd;
}
+ catch (Exception)
+ {
+ hnd.Dispose();
- return hnd;
+ throw;
+ }
}
#endregion
http://git-wip-us.apache.org/repos/asf/ignite/blob/a34d7058/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Cache/Query/AbstractQueryCursor.cs
----------------------------------------------------------------------
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Cache/Query/AbstractQueryCursor.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Cache/Query/AbstractQueryCursor.cs
index 55eb459..a22b247 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Cache/Query/AbstractQueryCursor.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Cache/Query/AbstractQueryCursor.cs
@@ -20,7 +20,6 @@ namespace Apache.Ignite.Core.Impl.Cache.Query
using System;
using System.Collections;
using System.Collections.Generic;
- using System.Diagnostics.CodeAnalysis;
using Apache.Ignite.Core.Cache.Query;
using Apache.Ignite.Core.Impl.Binary;
using Apache.Ignite.Core.Impl.Binary.IO;
@@ -108,14 +107,13 @@ namespace Apache.Ignite.Core.Impl.Cache.Query
#region Public IEnumerable methods
/** <inheritdoc /> */
- [SuppressMessage("ReSharper", "PossibleNullReferenceException")]
public IEnumerator<T> GetEnumerator()
{
ThrowIfDisposed();
if (_iterCalled)
throw new InvalidOperationException("Failed to get enumerator entries because " +
- "GetEnumeartor() method has already been called.");
+ "GetEnumerator() method has already been called.");
if (_getAllCalled)
throw new InvalidOperationException("Failed to get enumerator entries because " +
http://git-wip-us.apache.org/repos/asf/ignite/blob/a34d7058/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Cache/Query/Continuous/ContinuousQueryFilterHolder.cs
----------------------------------------------------------------------
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Cache/Query/Continuous/ContinuousQueryFilterHolder.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Cache/Query/Continuous/ContinuousQueryFilterHolder.cs
index 9f357ea..c2e7762 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Cache/Query/Continuous/ContinuousQueryFilterHolder.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Cache/Query/Continuous/ContinuousQueryFilterHolder.cs
@@ -24,7 +24,7 @@ namespace Apache.Ignite.Core.Impl.Cache.Query.Continuous
/// Continuous query remote filter holder. Wraps real filter into binary object,
/// so that it can be passed over wire to another node.
/// </summary>
- public class ContinuousQueryFilterHolder : IBinaryWriteAware
+ internal class ContinuousQueryFilterHolder : IBinaryWriteAware
{
/** Filter object. */
private readonly object _filter;
http://git-wip-us.apache.org/repos/asf/ignite/blob/a34d7058/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Cache/Query/Continuous/ContinuousQueryHandleImpl.cs
----------------------------------------------------------------------
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Cache/Query/Continuous/ContinuousQueryHandleImpl.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Cache/Query/Continuous/ContinuousQueryHandleImpl.cs
index fef904b..bbc2dbe 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Cache/Query/Continuous/ContinuousQueryHandleImpl.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Cache/Query/Continuous/ContinuousQueryHandleImpl.cs
@@ -192,11 +192,9 @@ namespace Apache.Ignite.Core.Impl.Cache.Query.Continuous
{
lock (this)
{
- if (_disposed)
+ if (_disposed || _nativeQry == null)
return;
- Debug.Assert(_nativeQry != null);
-
try
{
UU.ContinuousQueryClose(_nativeQry);
http://git-wip-us.apache.org/repos/asf/ignite/blob/a34d7058/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Cache/Query/FieldsQueryCursor.cs
----------------------------------------------------------------------
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Cache/Query/FieldsQueryCursor.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Cache/Query/FieldsQueryCursor.cs
index 6d45ecd..42fa1b9 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Cache/Query/FieldsQueryCursor.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Cache/Query/FieldsQueryCursor.cs
@@ -18,6 +18,7 @@
namespace Apache.Ignite.Core.Impl.Cache.Query
{
using System.Collections;
+ using System.Diagnostics.CodeAnalysis;
using Apache.Ignite.Core.Impl.Binary;
using Apache.Ignite.Core.Impl.Unmanaged;
@@ -39,6 +40,7 @@ namespace Apache.Ignite.Core.Impl.Cache.Query
}
/** <inheritdoc /> */
+ [SuppressMessage("Microsoft.Design", "CA1062:Validate arguments of public methods")]
protected override IList Read(BinaryReader reader)
{
int cnt = reader.ReadInt();
http://git-wip-us.apache.org/repos/asf/ignite/blob/a34d7058/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Cache/Query/QueryCursor.cs
----------------------------------------------------------------------
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Cache/Query/QueryCursor.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Cache/Query/QueryCursor.cs
index 6670ae6..5a46915 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Cache/Query/QueryCursor.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Cache/Query/QueryCursor.cs
@@ -17,6 +17,7 @@
namespace Apache.Ignite.Core.Impl.Cache.Query
{
+ using System.Diagnostics.CodeAnalysis;
using Apache.Ignite.Core.Cache;
using Apache.Ignite.Core.Impl.Binary;
using Apache.Ignite.Core.Impl.Unmanaged;
@@ -39,6 +40,7 @@ namespace Apache.Ignite.Core.Impl.Cache.Query
}
/** <inheritdoc /> */
+ [SuppressMessage("Microsoft.Design", "CA1062:Validate arguments of public methods")]
protected override ICacheEntry<TK, TV> Read(BinaryReader reader)
{
TK key = reader.ReadObject<TK>();
http://git-wip-us.apache.org/repos/asf/ignite/blob/a34d7058/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Common/CancelledTask.cs
----------------------------------------------------------------------
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Common/CancelledTask.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Common/CancelledTask.cs
index 0a84d81..7551d35 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Common/CancelledTask.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Common/CancelledTask.cs
@@ -17,6 +17,7 @@
namespace Apache.Ignite.Core.Impl.Common
{
+ using System.Diagnostics.CodeAnalysis;
using System.Threading.Tasks;
/// <summary>
@@ -30,6 +31,8 @@ namespace Apache.Ignite.Core.Impl.Common
/// <summary>
/// Initializes the <see cref="CancelledTask{T}"/> class.
/// </summary>
+ [SuppressMessage("Microsoft.Performance", "CA1810:InitializeReferenceTypeStaticFieldsInline",
+ Justification = "Readability.")]
static CancelledTask()
{
TaskCompletionSource = new TaskCompletionSource<T>();
http://git-wip-us.apache.org/repos/asf/ignite/blob/a34d7058/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Common/CopyOnWriteConcurrentDictionary.cs
----------------------------------------------------------------------
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Common/CopyOnWriteConcurrentDictionary.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Common/CopyOnWriteConcurrentDictionary.cs
index 918bbd1..01fc8a9 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Common/CopyOnWriteConcurrentDictionary.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Common/CopyOnWriteConcurrentDictionary.cs
@@ -48,6 +48,7 @@ namespace Apache.Ignite.Core.Impl.Common
/// <param name="key">The key.</param>
/// <param name="valueFactory">The function used to generate a value for the key.</param>
/// <returns>The value for the key.</returns>
+ [SuppressMessage("Microsoft.Design", "CA1062:Validate arguments of public methods")]
public TValue GetOrAdd(TKey key, Func<TKey, TValue> valueFactory)
{
lock (this)
http://git-wip-us.apache.org/repos/asf/ignite/blob/a34d7058/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Common/DelegateConverter.cs
----------------------------------------------------------------------
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Common/DelegateConverter.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Common/DelegateConverter.cs
index 5d1a4e2..fa19a9e 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Common/DelegateConverter.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Common/DelegateConverter.cs
@@ -19,6 +19,7 @@ namespace Apache.Ignite.Core.Impl.Common
{
using System;
using System.Diagnostics;
+ using System.Diagnostics.CodeAnalysis;
using System.Linq.Expressions;
using System.Reflection;
using System.Reflection.Emit;
@@ -30,12 +31,13 @@ namespace Apache.Ignite.Core.Impl.Common
{
/** */
private const string DefaultMethodName = "Invoke";
-
+
/// <summary>
/// Compiles a function without arguments.
/// </summary>
/// <param name="targetType">Type of the target.</param>
/// <returns>Compiled function that calls specified method on specified target.</returns>
+ [SuppressMessage("Microsoft.Design", "CA1062:Validate arguments of public methods")]
public static Func<object, object> CompileFunc(Type targetType)
{
var method = targetType.GetMethod(DefaultMethodName);
@@ -62,6 +64,7 @@ namespace Apache.Ignite.Core.Impl.Common
/// <returns>
/// Compiled function that calls specified method on specified target.
/// </returns>
+ [SuppressMessage("Microsoft.Design", "CA1062:Validate arguments of public methods")]
public static T CompileFunc<T>(Type targetType, Type[] argTypes, bool[] convertToObject = null,
string methodName = null)
where T : class
@@ -84,6 +87,7 @@ namespace Apache.Ignite.Core.Impl.Common
/// <returns>
/// Compiled function that calls specified method on specified target.
/// </returns>
+ [SuppressMessage("Microsoft.Design", "CA1062:Validate arguments of public methods")]
public static T CompileFunc<T>(Type targetType, MethodInfo method, Type[] argTypes,
bool[] convertToObject = null)
where T : class
@@ -155,6 +159,7 @@ namespace Apache.Ignite.Core.Impl.Common
/// <returns>
/// Compiled generic constructor.
/// </returns>
+ [SuppressMessage("Microsoft.Design", "CA1062:Validate arguments of public methods")]
public static T CompileCtor<T>(ConstructorInfo ctor, Type[] argTypes, bool convertResultToObject = true)
{
Debug.Assert(ctor != null);
@@ -189,6 +194,7 @@ namespace Apache.Ignite.Core.Impl.Common
/// <returns>
/// Compiled generic constructor.
/// </returns>
+ [SuppressMessage("Microsoft.Design", "CA1062:Validate arguments of public methods")]
public static T CompileCtor<T>(Type type, Type[] argTypes, bool convertResultToObject = true)
{
var ctor = type.GetConstructor(argTypes);
@@ -201,6 +207,7 @@ namespace Apache.Ignite.Core.Impl.Common
/// </summary>
/// <param name="field">The field.</param>
/// <returns>Compiled field setter.</returns>
+ [SuppressMessage("Microsoft.Design", "CA1062:Validate arguments of public methods")]
public static Action<object, object> CompileFieldSetter(FieldInfo field)
{
Debug.Assert(field != null);
@@ -222,6 +229,7 @@ namespace Apache.Ignite.Core.Impl.Common
/// </summary>
/// <param name="prop">The property.</param>
/// <returns>Compiled property setter.</returns>
+ [SuppressMessage("Microsoft.Design", "CA1062:Validate arguments of public methods")]
public static Action<object, object> CompilePropertySetter(PropertyInfo prop)
{
Debug.Assert(prop != null);
@@ -246,6 +254,7 @@ namespace Apache.Ignite.Core.Impl.Common
/// </summary>
/// <param name="field">The field.</param>
/// <returns>Resulting MethodInfo.</returns>
+ [SuppressMessage("Microsoft.Design", "CA1062:Validate arguments of public methods")]
public static DynamicMethod GetWriteFieldMethod(FieldInfo field)
{
Debug.Assert(field != null);
http://git-wip-us.apache.org/repos/asf/ignite/blob/a34d7058/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Common/Future.cs
----------------------------------------------------------------------
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Common/Future.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Common/Future.cs
index 0325b71..7e6f418 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Common/Future.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Common/Future.cs
@@ -69,6 +69,7 @@ namespace Apache.Ignite.Core.Impl.Common
/// <summary>
/// Gets the task.
/// </summary>
+ [SuppressMessage("Microsoft.Naming", "CA1721:PropertyNamesShouldNotMatchGetMethods")]
public Task<T> Task
{
get { return _taskCompletionSource.Task; }
@@ -112,6 +113,7 @@ namespace Apache.Ignite.Core.Impl.Common
}
/** <inheritdoc /> */
+ [SuppressMessage("Microsoft.Design", "CA1031:DoNotCatchGeneralExceptionTypes")]
public void OnNullResult()
{
if (_converter == null)
http://git-wip-us.apache.org/repos/asf/ignite/blob/a34d7058/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Common/LoadedAssembliesResolver.cs
----------------------------------------------------------------------
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Common/LoadedAssembliesResolver.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Common/LoadedAssembliesResolver.cs
index c158d5c..83d4f96 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Common/LoadedAssembliesResolver.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Common/LoadedAssembliesResolver.cs
@@ -25,6 +25,7 @@ namespace Apache.Ignite.Core.Impl.Common
/// <summary>
/// Resolves loaded assemblies by name.
/// </summary>
+ // ReSharper disable once ClassNeverInstantiated.Global
public class LoadedAssembliesResolver
{
// The lazy singleton instance.
http://git-wip-us.apache.org/repos/asf/ignite/blob/a34d7058/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Compute/Closure/ComputeAbstractClosureTask.cs
----------------------------------------------------------------------
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Compute/Closure/ComputeAbstractClosureTask.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Compute/Closure/ComputeAbstractClosureTask.cs
index 286ae3a..220dbf8 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Compute/Closure/ComputeAbstractClosureTask.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Compute/Closure/ComputeAbstractClosureTask.cs
@@ -19,8 +19,10 @@ namespace Apache.Ignite.Core.Impl.Compute.Closure
{
using System;
using System.Collections.Generic;
+ using System.Diagnostics.CodeAnalysis;
using Apache.Ignite.Core.Cluster;
using Apache.Ignite.Core.Compute;
+ using Apache.Ignite.Core.Impl.Common;
/// <summary>
/// Base class for all tasks working with closures.
@@ -60,6 +62,7 @@ namespace Apache.Ignite.Core.Impl.Compute.Closure
/// <returns>
/// Result policy that dictates how to process further upcoming job results.
/// </returns>
+ [SuppressMessage("Microsoft.Design", "CA1062:Validate arguments of public methods")]
public ComputeJobResultPolicy OnResult(IComputeJobResult<T> res, IList<IComputeJobResult<T>> rcvd)
{
Exception err = res.Exception;
http://git-wip-us.apache.org/repos/asf/ignite/blob/a34d7058/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Compute/Closure/ComputeMultiClosureTask.cs
----------------------------------------------------------------------
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Compute/Closure/ComputeMultiClosureTask.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Compute/Closure/ComputeMultiClosureTask.cs
index f26fe93..167ede9 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Compute/Closure/ComputeMultiClosureTask.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Compute/Closure/ComputeMultiClosureTask.cs
@@ -18,6 +18,7 @@
namespace Apache.Ignite.Core.Impl.Compute.Closure
{
using System.Collections.Generic;
+ using System.Diagnostics.CodeAnalysis;
using Apache.Ignite.Core.Compute;
/// <summary>
@@ -40,6 +41,7 @@ namespace Apache.Ignite.Core.Impl.Compute.Closure
}
/** <inheritDoc /> */
+ [SuppressMessage("Microsoft.Design", "CA1062:Validate arguments of public methods")]
protected override ComputeJobResultPolicy Result0(IComputeJobResult<T> res)
{
_res.Add(res.Data);
http://git-wip-us.apache.org/repos/asf/ignite/blob/a34d7058/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Compute/Closure/ComputeReducingClosureTask.cs
----------------------------------------------------------------------
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Compute/Closure/ComputeReducingClosureTask.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Compute/Closure/ComputeReducingClosureTask.cs
index 8e2260e..d1dab05 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Compute/Closure/ComputeReducingClosureTask.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Compute/Closure/ComputeReducingClosureTask.cs
@@ -18,6 +18,7 @@
namespace Apache.Ignite.Core.Impl.Compute.Closure
{
using System.Collections.Generic;
+ using System.Diagnostics.CodeAnalysis;
using Apache.Ignite.Core.Compute;
using Apache.Ignite.Core.Impl.Resource;
@@ -41,6 +42,7 @@ namespace Apache.Ignite.Core.Impl.Compute.Closure
}
/** <inheritDoc /> */
+ [SuppressMessage("Microsoft.Design", "CA1062:Validate arguments of public methods")]
protected override ComputeJobResultPolicy Result0(IComputeJobResult<T> res)
{
return _rdc.Collect(res.Data) ? ComputeJobResultPolicy.Wait : ComputeJobResultPolicy.Reduce;
http://git-wip-us.apache.org/repos/asf/ignite/blob/a34d7058/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Compute/Closure/ComputeSingleClosureTask.cs
----------------------------------------------------------------------
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Compute/Closure/ComputeSingleClosureTask.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Compute/Closure/ComputeSingleClosureTask.cs
index 20da4b6..715c7e2 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Compute/Closure/ComputeSingleClosureTask.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Compute/Closure/ComputeSingleClosureTask.cs
@@ -18,6 +18,7 @@
namespace Apache.Ignite.Core.Impl.Compute.Closure
{
using System.Collections.Generic;
+ using System.Diagnostics.CodeAnalysis;
using Apache.Ignite.Core.Compute;
/// <summary>
@@ -30,6 +31,7 @@ namespace Apache.Ignite.Core.Impl.Compute.Closure
private TR _res;
/** <inheritDoc /> */
+ [SuppressMessage("Microsoft.Design", "CA1062:Validate arguments of public methods")]
protected override ComputeJobResultPolicy Result0(IComputeJobResult<T> res)
{
_res = (TR) res.Data;
http://git-wip-us.apache.org/repos/asf/ignite/blob/a34d7058/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Datastream/DataStreamerBatch.cs
----------------------------------------------------------------------
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Datastream/DataStreamerBatch.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Datastream/DataStreamerBatch.cs
index 29ec642..66ee695 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Datastream/DataStreamerBatch.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Datastream/DataStreamerBatch.cs
@@ -192,6 +192,7 @@ namespace Apache.Ignite.Core.Impl.Datastream
{
curBatch._fut.Get();
}
+ // ReSharper disable once EmptyGeneralCatchClause
catch (Exception)
{
// Ignore.
http://git-wip-us.apache.org/repos/asf/ignite/blob/a34d7058/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Datastream/DataStreamerImpl.cs
----------------------------------------------------------------------
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Datastream/DataStreamerImpl.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Datastream/DataStreamerImpl.cs
index 3686ecb..6066504 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Datastream/DataStreamerImpl.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Datastream/DataStreamerImpl.cs
@@ -537,6 +537,7 @@ namespace Apache.Ignite.Core.Impl.Datastream
if (_batch != null)
_batch.Send(this, PlcCancelClose);
}
+ // ReSharper disable once EmptyGeneralCatchClause
catch (Exception)
{
// Finalizers should never throw
@@ -544,9 +545,9 @@ namespace Apache.Ignite.Core.Impl.Datastream
Marshaller.Ignite.HandleRegistry.Release(_hnd, true);
Marshaller.Ignite.HandleRegistry.Release(_rcvHnd, true);
-
- base.Dispose(false);
}
+
+ base.Dispose(false);
}
/** <inheritDoc /> */
http://git-wip-us.apache.org/repos/asf/ignite/blob/a34d7058/modules/platforms/dotnet/Apache.Ignite.Core/Impl/ExceptionUtils.cs
----------------------------------------------------------------------
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/ExceptionUtils.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/ExceptionUtils.cs
index 665d37e..4d2e458 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/ExceptionUtils.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/ExceptionUtils.cs
@@ -46,7 +46,7 @@ namespace Apache.Ignite.Core.Impl
private const string ClsCachePartialUpdateErr = "org.apache.ignite.internal.processors.platform.cache.PlatformCachePartialUpdateException";
/** Map with predefined exceptions. */
- private static readonly IDictionary<string, ExceptionFactoryDelegate> EXS = new Dictionary<string, ExceptionFactoryDelegate>();
+ private static readonly IDictionary<string, ExceptionFactoryDelegate> Exs = new Dictionary<string, ExceptionFactoryDelegate>();
/** Exception factory delegate. */
private delegate Exception ExceptionFactoryDelegate(string msg);
@@ -59,46 +59,46 @@ namespace Apache.Ignite.Core.Impl
static ExceptionUtils()
{
// Common Java exceptions mapped to common .Net exceptions.
- EXS["java.lang.IllegalArgumentException"] = m => new ArgumentException(m);
- EXS["java.lang.IllegalStateException"] = m => new InvalidOperationException(m);
- EXS["java.lang.UnsupportedOperationException"] = m => new NotImplementedException(m);
- EXS["java.lang.InterruptedException"] = m => new ThreadInterruptedException(m);
+ Exs["java.lang.IllegalArgumentException"] = m => new ArgumentException(m);
+ Exs["java.lang.IllegalStateException"] = m => new InvalidOperationException(m);
+ Exs["java.lang.UnsupportedOperationException"] = m => new NotImplementedException(m);
+ Exs["java.lang.InterruptedException"] = m => new ThreadInterruptedException(m);
// Generic Ignite exceptions.
- EXS["org.apache.ignite.IgniteException"] = m => new IgniteException(m);
- EXS["org.apache.ignite.IgniteCheckedException"] = m => new IgniteException(m);
+ Exs["org.apache.ignite.IgniteException"] = m => new IgniteException(m);
+ Exs["org.apache.ignite.IgniteCheckedException"] = m => new IgniteException(m);
// Cluster exceptions.
- EXS["org.apache.ignite.cluster.ClusterGroupEmptyException"] = m => new ClusterGroupEmptyException(m);
- EXS["org.apache.ignite.cluster.ClusterTopologyException"] = m => new ClusterTopologyException(m);
+ Exs["org.apache.ignite.cluster.ClusterGroupEmptyException"] = m => new ClusterGroupEmptyException(m);
+ Exs["org.apache.ignite.cluster.ClusterTopologyException"] = m => new ClusterTopologyException(m);
// Compute exceptions.
- EXS["org.apache.ignite.compute.ComputeExecutionRejectedException"] = m => new ComputeExecutionRejectedException(m);
- EXS["org.apache.ignite.compute.ComputeJobFailoverException"] = m => new ComputeJobFailoverException(m);
- EXS["org.apache.ignite.compute.ComputeTaskCancelledException"] = m => new ComputeTaskCancelledException(m);
- EXS["org.apache.ignite.compute.ComputeTaskTimeoutException"] = m => new ComputeTaskTimeoutException(m);
- EXS["org.apache.ignite.compute.ComputeUserUndeclaredException"] = m => new ComputeUserUndeclaredException(m);
+ Exs["org.apache.ignite.compute.ComputeExecutionRejectedException"] = m => new ComputeExecutionRejectedException(m);
+ Exs["org.apache.ignite.compute.ComputeJobFailoverException"] = m => new ComputeJobFailoverException(m);
+ Exs["org.apache.ignite.compute.ComputeTaskCancelledException"] = m => new ComputeTaskCancelledException(m);
+ Exs["org.apache.ignite.compute.ComputeTaskTimeoutException"] = m => new ComputeTaskTimeoutException(m);
+ Exs["org.apache.ignite.compute.ComputeUserUndeclaredException"] = m => new ComputeUserUndeclaredException(m);
// Cache exceptions.
- EXS["javax.cache.CacheException"] = m => new CacheException(m);
- EXS["javax.cache.integration.CacheLoaderException"] = m => new CacheStoreException(m);
- EXS["javax.cache.integration.CacheWriterException"] = m => new CacheStoreException(m);
- EXS["javax.cache.processor.EntryProcessorException"] = m => new CacheEntryProcessorException(m);
- EXS["org.apache.ignite.cache.CacheAtomicUpdateTimeoutException"] = m => new CacheAtomicUpdateTimeoutException(m);
+ Exs["javax.cache.CacheException"] = m => new CacheException(m);
+ Exs["javax.cache.integration.CacheLoaderException"] = m => new CacheStoreException(m);
+ Exs["javax.cache.integration.CacheWriterException"] = m => new CacheStoreException(m);
+ Exs["javax.cache.processor.EntryProcessorException"] = m => new CacheEntryProcessorException(m);
+ Exs["org.apache.ignite.cache.CacheAtomicUpdateTimeoutException"] = m => new CacheAtomicUpdateTimeoutException(m);
// Transaction exceptions.
- EXS["org.apache.ignite.transactions.TransactionOptimisticException"] = m => new TransactionOptimisticException(m);
- EXS["org.apache.ignite.transactions.TransactionTimeoutException"] = m => new TransactionTimeoutException(m);
- EXS["org.apache.ignite.transactions.TransactionRollbackException"] = m => new TransactionRollbackException(m);
- EXS["org.apache.ignite.transactions.TransactionHeuristicException"] = m => new TransactionHeuristicException(m);
+ Exs["org.apache.ignite.transactions.TransactionOptimisticException"] = m => new TransactionOptimisticException(m);
+ Exs["org.apache.ignite.transactions.TransactionTimeoutException"] = m => new TransactionTimeoutException(m);
+ Exs["org.apache.ignite.transactions.TransactionRollbackException"] = m => new TransactionRollbackException(m);
+ Exs["org.apache.ignite.transactions.TransactionHeuristicException"] = m => new TransactionHeuristicException(m);
// Security exceptions.
- EXS["org.apache.ignite.IgniteAuthenticationException"] = m => new SecurityException(m);
- EXS["org.apache.ignite.plugin.security.GridSecurityException"] = m => new SecurityException(m);
+ Exs["org.apache.ignite.IgniteAuthenticationException"] = m => new SecurityException(m);
+ Exs["org.apache.ignite.plugin.security.GridSecurityException"] = m => new SecurityException(m);
// Future exceptions
- EXS["org.apache.ignite.lang.IgniteFutureCancelledException"] = m => new IgniteFutureCancelledException(m);
- EXS["org.apache.ignite.internal.IgniteFutureCancelledCheckedException"] = m => new IgniteFutureCancelledException(m);
+ Exs["org.apache.ignite.lang.IgniteFutureCancelledException"] = m => new IgniteFutureCancelledException(m);
+ Exs["org.apache.ignite.internal.IgniteFutureCancelledCheckedException"] = m => new IgniteFutureCancelledException(m);
}
/// <summary>
@@ -111,7 +111,7 @@ namespace Apache.Ignite.Core.Impl
{
ExceptionFactoryDelegate ctor;
- if (EXS.TryGetValue(clsName, out ctor))
+ if (Exs.TryGetValue(clsName, out ctor))
return ctor(msg);
if (ClsNoClsDefFoundErr.Equals(clsName))
http://git-wip-us.apache.org/repos/asf/ignite/blob/a34d7058/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Handle/HandleRegistry.cs
----------------------------------------------------------------------
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Handle/HandleRegistry.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Handle/HandleRegistry.cs
index 1979086..e18970f 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Handle/HandleRegistry.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Handle/HandleRegistry.cs
@@ -211,6 +211,7 @@ namespace Apache.Ignite.Core.Impl.Handle
{
target0.Release();
}
+ // ReSharper disable once EmptyGeneralCatchClause
catch (Exception)
{
// No-op.
http://git-wip-us.apache.org/repos/asf/ignite/blob/a34d7058/modules/platforms/dotnet/Apache.Ignite.Core/Impl/IgniteUtils.cs
----------------------------------------------------------------------
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/IgniteUtils.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/IgniteUtils.cs
index 7929a5d..fe4548c 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/IgniteUtils.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/IgniteUtils.cs
@@ -19,6 +19,7 @@ namespace Apache.Ignite.Core.Impl
{
using System;
using System.Collections.Generic;
+ using System.Diagnostics.CodeAnalysis;
using System.Globalization;
using System.IO;
using System.Linq;
@@ -64,6 +65,8 @@ namespace Apache.Ignite.Core.Impl
/// <summary>
/// Initializes the <see cref="IgniteUtils"/> class.
/// </summary>
+ [SuppressMessage("Microsoft.Performance", "CA1810:InitializeReferenceTypeStaticFieldsInline",
+ Justification = "Readability.")]
static IgniteUtils()
{
TryCleanTempDirectories();
@@ -72,10 +75,10 @@ namespace Apache.Ignite.Core.Impl
/// <summary>
/// Gets thread local random.
/// </summary>
- /// <returns>Thread local random.</returns>
- private static Random ThreadLocalRandom()
+ /// <value>Thread local random.</value>
+ public static Random ThreadLocalRandom
{
- return _rnd ?? (_rnd = new Random());
+ get { return _rnd ?? (_rnd = new Random()); }
}
/// <summary>
@@ -89,7 +92,7 @@ namespace Apache.Ignite.Core.Impl
if (cnt > 1) {
List<T> res = new List<T>(list);
- Random rnd = ThreadLocalRandom();
+ Random rnd = ThreadLocalRandom;
while (cnt > 1)
{
http://git-wip-us.apache.org/repos/asf/ignite/blob/a34d7058/modules/platforms/dotnet/Apache.Ignite.Core/Impl/InteropExceptionHolder.cs
----------------------------------------------------------------------
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/InteropExceptionHolder.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/InteropExceptionHolder.cs
index 42c21f3..9edcb03 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/InteropExceptionHolder.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/InteropExceptionHolder.cs
@@ -18,6 +18,7 @@
namespace Apache.Ignite.Core.Impl
{
using System;
+ using System.Diagnostics.CodeAnalysis;
using System.Runtime.Serialization.Formatters.Binary;
using Apache.Ignite.Core.Binary;
using Apache.Ignite.Core.Impl.Binary;
@@ -29,7 +30,7 @@ namespace Apache.Ignite.Core.Impl
internal class InteropExceptionHolder : IBinarizable
{
/** Initial exception. */
- private Exception _err;
+ private readonly Exception _err;
/// <summary>
/// Constructor.
@@ -57,6 +58,7 @@ namespace Apache.Ignite.Core.Impl
}
/** <inheritDoc /> */
+ [SuppressMessage("Microsoft.Design", "CA1062:Validate arguments of public methods")]
public void WriteBinary(IBinaryWriter writer)
{
var writer0 = (BinaryWriter) writer.GetRawWriter();
@@ -70,9 +72,10 @@ namespace Apache.Ignite.Core.Impl
{
writer0.WriteBoolean(false);
- BinaryFormatter bf = new BinaryFormatter();
-
- bf.Serialize(new BinaryStreamAdapter(writer0.Stream), _err);
+ using (var streamAdapter = new BinaryStreamAdapter(writer0.Stream))
+ {
+ new BinaryFormatter().Serialize(streamAdapter, _err);
+ }
}
}
http://git-wip-us.apache.org/repos/asf/ignite/blob/a34d7058/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Memory/PlatformBigEndianMemoryStream.cs
----------------------------------------------------------------------
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Memory/PlatformBigEndianMemoryStream.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Memory/PlatformBigEndianMemoryStream.cs
index 33a0487..d59d572 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Memory/PlatformBigEndianMemoryStream.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Memory/PlatformBigEndianMemoryStream.cs
@@ -17,6 +17,8 @@
namespace Apache.Ignite.Core.Impl.Memory
{
+ using System.Diagnostics.CodeAnalysis;
+
/// <summary>
/// Platform memory stream for big endian platforms.
/// </summary>
@@ -45,6 +47,7 @@ namespace Apache.Ignite.Core.Impl.Memory
}
/** <inheritDoc /> */
+ [SuppressMessage("Microsoft.Design", "CA1062:Validate arguments of public methods")]
public override unsafe void WriteShortArray(short[] val)
{
byte* curPos = Data + EnsureWriteCapacityAndShift(val.Length << Shift2);
@@ -67,6 +70,7 @@ namespace Apache.Ignite.Core.Impl.Memory
}
/** <inheritDoc /> */
+ [SuppressMessage("Microsoft.Design", "CA1062:Validate arguments of public methods")]
public override unsafe void WriteCharArray(char[] val)
{
byte* curPos = Data + EnsureWriteCapacityAndShift(val.Length << Shift2);
@@ -111,6 +115,7 @@ namespace Apache.Ignite.Core.Impl.Memory
}
/** <inheritDoc /> */
+ [SuppressMessage("Microsoft.Design", "CA1062:Validate arguments of public methods")]
public override unsafe void WriteIntArray(int[] val)
{
byte* curPos = Data + EnsureWriteCapacityAndShift(val.Length << Shift4);
@@ -146,6 +151,7 @@ namespace Apache.Ignite.Core.Impl.Memory
}
/** <inheritDoc /> */
+ [SuppressMessage("Microsoft.Design", "CA1062:Validate arguments of public methods")]
public override unsafe void WriteLongArray(long[] val)
{
byte* curPos = Data + EnsureWriteCapacityAndShift(val.Length << Shift8);
@@ -174,6 +180,7 @@ namespace Apache.Ignite.Core.Impl.Memory
}
/** <inheritDoc /> */
+ [SuppressMessage("Microsoft.Design", "CA1062:Validate arguments of public methods")]
public override unsafe void WriteFloatArray(float[] val)
{
byte* curPos = Data + EnsureWriteCapacityAndShift(val.Length << Shift4);
@@ -198,6 +205,7 @@ namespace Apache.Ignite.Core.Impl.Memory
}
/** <inheritDoc /> */
+ [SuppressMessage("Microsoft.Design", "CA1062:Validate arguments of public methods")]
public override unsafe void WriteDoubleArray(double[] val)
{
byte* curPos = Data + EnsureWriteCapacityAndShift(val.Length << Shift8);
http://git-wip-us.apache.org/repos/asf/ignite/blob/a34d7058/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Memory/PlatformMemory.cs
----------------------------------------------------------------------
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Memory/PlatformMemory.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Memory/PlatformMemory.cs
index 4a905c3..cb30051 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Memory/PlatformMemory.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Memory/PlatformMemory.cs
@@ -18,6 +18,7 @@
namespace Apache.Ignite.Core.Impl.Memory
{
using System;
+ using System.Diagnostics.CodeAnalysis;
/// <summary>
/// Abstract memory chunk.
@@ -38,6 +39,7 @@ namespace Apache.Ignite.Core.Impl.Memory
}
/** <inheritdoc /> */
+ [SuppressMessage("Microsoft.Reliability", "CA2000:Dispose objects before losing scope")]
public virtual PlatformMemoryStream GetStream()
{
return BitConverter.IsLittleEndian ? new PlatformMemoryStream(this) :
http://git-wip-us.apache.org/repos/asf/ignite/blob/a34d7058/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Memory/PlatformMemoryManager.cs
----------------------------------------------------------------------
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Memory/PlatformMemoryManager.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Memory/PlatformMemoryManager.cs
index dccf8ab..f934081 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Memory/PlatformMemoryManager.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Memory/PlatformMemoryManager.cs
@@ -27,6 +27,7 @@ namespace Apache.Ignite.Core.Impl.Memory
[SuppressMessage("Microsoft.Design", "CA1001:TypesThatOwnDisposableFieldsShouldBeDisposable",
Justification = "This class instance usually lives as long as the app runs.")]
[CLSCompliant(false)]
+ // ReSharper disable once ClassWithVirtualMembersNeverInherited.Global
public class PlatformMemoryManager
{
/** Default capacity. */
@@ -80,6 +81,7 @@ namespace Apache.Ignite.Core.Impl.Memory
/// Gets or creates thread-local memory pool.
/// </summary>
/// <returns>Memory pool.</returns>
+ [SuppressMessage("Microsoft.Reliability", "CA2000:Dispose objects before losing scope")]
public PlatformMemoryPool Pool()
{
PlatformMemoryPool pool = _threadLocPool.Value;
http://git-wip-us.apache.org/repos/asf/ignite/blob/a34d7058/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Memory/PlatformMemoryStream.cs
----------------------------------------------------------------------
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Memory/PlatformMemoryStream.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Memory/PlatformMemoryStream.cs
index 374cc4a..ba0da19 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Memory/PlatformMemoryStream.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Memory/PlatformMemoryStream.cs
@@ -71,6 +71,7 @@ namespace Apache.Ignite.Core.Impl.Memory
/// Constructor.
/// </summary>
/// <param name="mem">Memory.</param>
+ [SuppressMessage("Microsoft.Design", "CA1062:Validate arguments of public methods")]
public PlatformMemoryStream(IPlatformMemory mem)
{
_mem = mem;
@@ -242,6 +243,7 @@ namespace Apache.Ignite.Core.Impl.Memory
}
/** <inheritdoc /> */
+ [SuppressMessage("Microsoft.Design", "CA1062:Validate arguments of public methods")]
public int WriteString(char* chars, int charCnt, int byteCnt, Encoding encoding)
{
IgniteArgumentCheck.NotNull(charCnt, "charCnt");
http://git-wip-us.apache.org/repos/asf/ignite/blob/a34d7058/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Memory/PlatformRawMemory.cs
----------------------------------------------------------------------
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Memory/PlatformRawMemory.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Memory/PlatformRawMemory.cs
index 76aa237..851d24f 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Memory/PlatformRawMemory.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Memory/PlatformRawMemory.cs
@@ -18,6 +18,7 @@
namespace Apache.Ignite.Core.Impl.Memory
{
using System;
+ using System.Diagnostics.CodeAnalysis;
/// <summary>
/// Non-resizeable raw memory chunk without metadata header.
@@ -43,6 +44,7 @@ namespace Apache.Ignite.Core.Impl.Memory
}
/** <inheritdoc /> */
+ [SuppressMessage("Microsoft.Reliability", "CA2000:Dispose objects before losing scope")]
public PlatformMemoryStream GetStream()
{
return BitConverter.IsLittleEndian ? new PlatformMemoryStream(this) :
http://git-wip-us.apache.org/repos/asf/ignite/blob/a34d7058/modules/platforms/dotnet/Apache.Ignite.Core/Impl/PlatformTarget.cs
----------------------------------------------------------------------
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/PlatformTarget.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/PlatformTarget.cs
index 0472ce4..c4258bd 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/PlatformTarget.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/PlatformTarget.cs
@@ -22,7 +22,6 @@ namespace Apache.Ignite.Core.Impl
using System.Diagnostics;
using System.Diagnostics.CodeAnalysis;
using System.IO;
- using System.Threading;
using System.Threading.Tasks;
using Apache.Ignite.Core.Impl.Binary;
using Apache.Ignite.Core.Impl.Binary.IO;
@@ -235,7 +234,7 @@ namespace Apache.Ignite.Core.Impl
/// <param name="writeItem">Write action to perform on item when it is not null.</param>
/// <returns>The same writer for chaining.</returns>
protected static BinaryWriter WriteNullable<T>(BinaryWriter writer, T item,
- Func<BinaryWriter, T, BinaryWriter> writeItem)
+ Func<BinaryWriter, T, BinaryWriter> writeItem) where T : class
{
if (item == null)
{
http://git-wip-us.apache.org/repos/asf/ignite/blob/a34d7058/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Resource/ResourceProcessor.cs
----------------------------------------------------------------------
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Resource/ResourceProcessor.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Resource/ResourceProcessor.cs
index 0a41d8c..99023b7 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Resource/ResourceProcessor.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Resource/ResourceProcessor.cs
@@ -25,7 +25,7 @@ namespace Apache.Ignite.Core.Impl.Resource
/// <summary>
/// Resource processor.
/// </summary>
- internal class ResourceProcessor
+ internal static class ResourceProcessor
{
/** Mutex. */
private static readonly object Mux = new object();
http://git-wip-us.apache.org/repos/asf/ignite/blob/a34d7058/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Resource/ResourceTypeDescriptor.cs
----------------------------------------------------------------------
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Resource/ResourceTypeDescriptor.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Resource/ResourceTypeDescriptor.cs
index de5d4c7..6d2b7b0 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Resource/ResourceTypeDescriptor.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Resource/ResourceTypeDescriptor.cs
@@ -46,7 +46,7 @@ namespace Apache.Ignite.Core.Impl.Resource
private static readonly Type TypComputeTaskNoResCache = typeof(ComputeTaskNoResultCacheAttribute);
/** Cached binding flags. */
- private static readonly BindingFlags Flags = BindingFlags.Instance | BindingFlags.Public |
+ private const BindingFlags Flags = BindingFlags.Instance | BindingFlags.Public |
BindingFlags.NonPublic | BindingFlags.DeclaredOnly;
/** Ignite injectors. */
http://git-wip-us.apache.org/repos/asf/ignite/blob/a34d7058/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Services/ServiceProxy.cs
----------------------------------------------------------------------
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Services/ServiceProxy.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Services/ServiceProxy.cs
index ebb4c84..5c108d8 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Services/ServiceProxy.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Services/ServiceProxy.cs
@@ -19,6 +19,7 @@ namespace Apache.Ignite.Core.Impl.Services
{
using System;
using System.Diagnostics;
+ using System.Diagnostics.CodeAnalysis;
using System.Reflection;
using System.Runtime.Remoting.Messaging;
using System.Runtime.Remoting.Proxies;
@@ -45,6 +46,7 @@ namespace Apache.Ignite.Core.Impl.Services
}
/** <inheritdoc /> */
+ [SuppressMessage("Microsoft.Design", "CA1062:Validate arguments of public methods")]
public override IMessage Invoke(IMessage msg)
{
var methodCall = msg as IMethodCallMessage;
http://git-wip-us.apache.org/repos/asf/ignite/blob/a34d7058/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Services/ServiceProxyInvoker.cs
----------------------------------------------------------------------
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Services/ServiceProxyInvoker.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Services/ServiceProxyInvoker.cs
index 9cf173b..dc61a34 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Services/ServiceProxyInvoker.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Services/ServiceProxyInvoker.cs
@@ -88,6 +88,7 @@ namespace Apache.Ignite.Core.Impl.Services
return methods[0];
// 3) 0 or more than 1 matching method - throw.
+ // ReSharper disable once ConditionIsAlwaysTrueOrFalse
var argsString = arguments == null || arguments.Length == 0
? "0"
: "(" +
http://git-wip-us.apache.org/repos/asf/ignite/blob/a34d7058/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Transactions/TransactionsImpl.cs
----------------------------------------------------------------------
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Transactions/TransactionsImpl.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Transactions/TransactionsImpl.cs
index 0bc7172..229ff8c 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Transactions/TransactionsImpl.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Transactions/TransactionsImpl.cs
@@ -18,6 +18,7 @@
namespace Apache.Ignite.Core.Impl.Transactions
{
using System;
+ using System.Diagnostics.CodeAnalysis;
using System.Threading.Tasks;
using Apache.Ignite.Core.Binary;
using Apache.Ignite.Core.Impl.Binary;
@@ -90,6 +91,7 @@ namespace Apache.Ignite.Core.Impl.Transactions
}
/** <inheritDoc /> */
+ [SuppressMessage("Microsoft.Reliability", "CA2000:Dispose objects before losing scope")]
public ITransaction TxStart(TransactionConcurrency concurrency, TransactionIsolation isolation,
TimeSpan timeout, int txSize)
{
http://git-wip-us.apache.org/repos/asf/ignite/blob/a34d7058/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Unmanaged/UnmanagedCallbacks.cs
----------------------------------------------------------------------
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Unmanaged/UnmanagedCallbacks.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Unmanaged/UnmanagedCallbacks.cs
index e554cfc..7778484 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Unmanaged/UnmanagedCallbacks.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Unmanaged/UnmanagedCallbacks.cs
@@ -77,6 +77,7 @@ namespace Apache.Ignite.Core.Impl.Unmanaged
private readonly GCHandle _thisHnd;
/** Callbacks pointer. */
+ [SuppressMessage("Microsoft.Reliability", "CA2006:UseSafeHandleToEncapsulateNativeResources")]
private readonly IntPtr _cbsPtr;
/** Error type: generic. */
@@ -275,7 +276,7 @@ namespace Apache.Ignite.Core.Impl.Unmanaged
if (_ignite != null)
cacheStore.Init(_ignite);
else
- _initActions.Add(g => cacheStore.Init(g));
+ _initActions.Add(cacheStore.Init);
}
}
@@ -283,6 +284,7 @@ namespace Apache.Ignite.Core.Impl.Unmanaged
}, true);
}
+ [SuppressMessage("Microsoft.Reliability", "CA2000:Dispose objects before losing scope")]
private int CacheStoreInvoke(void* target, long objPtr, long memPtr, void* cb)
{
return SafeCall(() =>
@@ -603,6 +605,7 @@ namespace Apache.Ignite.Core.Impl.Unmanaged
});
}
+ [SuppressMessage("Microsoft.Reliability", "CA2000:Dispose objects before losing scope")]
private void DataStreamerStreamReceiverInvoke(void* target, long rcvPtr, void* cache, long memPtr,
byte keepBinary)
{
http://git-wip-us.apache.org/repos/asf/ignite/blob/a34d7058/modules/platforms/dotnet/Apache.Ignite.Core/Services/ServiceInvocationException.cs
----------------------------------------------------------------------
diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Services/ServiceInvocationException.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Services/ServiceInvocationException.cs
index 50365d3..cb0e2ae 100644
--- a/modules/platforms/dotnet/Apache.Ignite.Core/Services/ServiceInvocationException.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.Core/Services/ServiceInvocationException.cs
@@ -18,6 +18,7 @@
namespace Apache.Ignite.Core.Services
{
using System;
+ using System.Diagnostics.CodeAnalysis;
using System.Runtime.Serialization;
using Apache.Ignite.Core.Binary;
using Apache.Ignite.Core.Common;
@@ -91,6 +92,7 @@ namespace Apache.Ignite.Core.Services
}
/** <inheritdoc /> */
+ [SuppressMessage("Microsoft.Design", "CA1062:Validate arguments of public methods")]
public override void GetObjectData(SerializationInfo info, StreamingContext context)
{
info.AddValue(KeyBinaryCause, _binaryCause);
http://git-wip-us.apache.org/repos/asf/ignite/blob/a34d7058/modules/platforms/dotnet/Apache.Ignite.FxCop
----------------------------------------------------------------------
diff --git a/modules/platforms/dotnet/Apache.Ignite.FxCop b/modules/platforms/dotnet/Apache.Ignite.FxCop
index 0df73c5..2c78f41 100644
--- a/modules/platforms/dotnet/Apache.Ignite.FxCop
+++ b/modules/platforms/dotnet/Apache.Ignite.FxCop
@@ -1,8 +1,8 @@
<?xml version="1.0" encoding="utf-8"?>
-<FxCopProject Version="1.36" Name="Apache Ignite.NET">
+<FxCopProject Version="1.36" Name="My FxCop Project">
<ProjectOptions>
<SharedProject>True</SharedProject>
- <Stylesheet Apply="False" />
+ <Stylesheet Apply="False">c:\program files (x86)\microsoft fxcop 1.36\Xml\FxCopReport.xsl</Stylesheet>
<SaveMessages>
<Project Status="Active, Excluded" NewOnly="False" />
<Report Status="Active" NewOnly="False" />
@@ -27,8 +27,8 @@
<RuleFiles>
<RuleFile Name="$(FxCopDir)\Rules\DesignRules.dll" Enabled="True" AllRulesEnabled="False">
<Rule Name="AbstractTypesShouldNotHaveConstructors" Enabled="True" />
+ <Rule Name="AssembliesShouldHaveValidStrongNames" Enabled="True" />
<Rule Name="AvoidEmptyInterfaces" Enabled="True" />
- <Rule Name="AvoidOutParameters" Enabled="True" />
<Rule Name="CollectionsShouldImplementGenericInterface" Enabled="True" />
<Rule Name="ConsiderPassingBaseTypesAsParameters" Enabled="True" />
<Rule Name="DeclareEventHandlersCorrectly" Enabled="True" />
@@ -80,9 +80,17 @@
<Rule Name="UseGenericEventHandlerInstances" Enabled="True" />
<Rule Name="UseGenericsWhereAppropriate" Enabled="True" />
<Rule Name="UseIntegralOrStringArgumentForIndexers" Enabled="True" />
- <Rule Name="UsePropertiesWhereAppropriate" Enabled="True" />
</RuleFile>
- <RuleFile Name="$(FxCopDir)\Rules\GlobalizationRules.dll" Enabled="True" AllRulesEnabled="True" />
+ <RuleFile Name="$(FxCopDir)\Rules\GlobalizationRules.dll" Enabled="True" AllRulesEnabled="False">
+ <Rule Name="AvoidDuplicateAccelerators" Enabled="True" />
+ <Rule Name="DoNotHardcodeLocaleSpecificStrings" Enabled="True" />
+ <Rule Name="NormalizeStringsToUppercase" Enabled="True" />
+ <Rule Name="SetLocaleForDataTypes" Enabled="True" />
+ <Rule Name="SpecifyCultureInfo" Enabled="True" />
+ <Rule Name="SpecifyMarshalingForPInvokeStringArguments" Enabled="True" />
+ <Rule Name="SpecifyMessageBoxOptions" Enabled="True" />
+ <Rule Name="UseOrdinalStringComparison" Enabled="True" />
+ </RuleFile>
<RuleFile Name="$(FxCopDir)\Rules\InteroperabilityRules.dll" Enabled="True" AllRulesEnabled="True" />
<RuleFile Name="$(FxCopDir)\Rules\MobilityRules.dll" Enabled="True" AllRulesEnabled="True" />
<RuleFile Name="$(FxCopDir)\Rules\NamingRules.dll" Enabled="True" AllRulesEnabled="False">
@@ -133,303 +141,49 @@
<Rule Name="TypeLinkDemandsRequireInheritanceDemands" Enabled="True" />
<Rule Name="WrapVulnerableFinallyClausesInOuterTry" Enabled="True" />
</RuleFile>
- <RuleFile Name="$(FxCopDir)\Rules\UsageRules.dll" Enabled="True" AllRulesEnabled="True" />
+ <RuleFile Name="$(FxCopDir)\Rules\UsageRules.dll" Enabled="True" AllRulesEnabled="False">
+ <Rule Name="CallBaseClassMethodsOnISerializableTypes" Enabled="True" />
+ <Rule Name="CallGCSuppressFinalizeCorrectly" Enabled="True" />
+ <Rule Name="CollectionPropertiesShouldBeReadOnly" Enabled="True" />
+ <Rule Name="DisposableFieldsShouldBeDisposed" Enabled="True" />
+ <Rule Name="DisposableTypesShouldDeclareFinalizer" Enabled="True" />
+ <Rule Name="DoNotCallOverridableMethodsInConstructors" Enabled="True" />
+ <Rule Name="DoNotDecreaseInheritedMemberVisibility" Enabled="True" />
+ <Rule Name="DoNotIgnoreMethodResults" Enabled="True" />
+ <Rule Name="DoNotMarkEnumsWithFlags" Enabled="True" />
+ <Rule Name="DoNotMarkServicedComponentsWithWebMethod" Enabled="True" />
+ <Rule Name="DoNotRaiseExceptionsInExceptionClauses" Enabled="True" />
+ <Rule Name="DoNotRaiseReservedExceptionTypes" Enabled="True" />
+ <Rule Name="DoNotShipUnreleasedResourceFormats" Enabled="True" />
+ <Rule Name="FinalizersShouldBeProtected" Enabled="True" />
+ <Rule Name="FinalizersShouldCallBaseClassFinalizer" Enabled="True" />
+ <Rule Name="ImplementISerializableCorrectly" Enabled="True" />
+ <Rule Name="ImplementSerializationConstructors" Enabled="True" />
+ <Rule Name="ImplementSerializationMethodsCorrectly" Enabled="True" />
+ <Rule Name="InitializeValueTypeStaticFieldsInline" Enabled="True" />
+ <Rule Name="InstantiateArgumentExceptionsCorrectly" Enabled="True" />
+ <Rule Name="MarkAllNonSerializableFields" Enabled="True" />
+ <Rule Name="MarkISerializableTypesWithSerializable" Enabled="True" />
+ <Rule Name="MarkWindowsFormsEntryPointsWithStaThread" Enabled="True" />
+ <Rule Name="MembersShouldDifferByMoreThanReturnType" Enabled="True" />
+ <Rule Name="NonConstantFieldsShouldNotBeVisible" Enabled="True" />
+ <Rule Name="OperationsShouldNotOverflow" Enabled="True" />
+ <Rule Name="OperatorOverloadsHaveNamedAlternates" Enabled="True" />
+ <Rule Name="OperatorsShouldHaveSymmetricalOverloads" Enabled="True" />
+ <Rule Name="OverloadOperatorEqualsOnOverridingValueTypeEquals" Enabled="True" />
+ <Rule Name="OverrideEqualsOnOverloadingOperatorEquals" Enabled="True" />
+ <Rule Name="OverrideGetHashCodeOnOverridingEquals" Enabled="True" />
+ <Rule Name="PassSystemUriObjectsInsteadOfStrings" Enabled="True" />
+ <Rule Name="ProvideDeserializationMethodsForOptionalFields" Enabled="True" />
+ <Rule Name="RethrowToPreserveStackDetails" Enabled="True" />
+ <Rule Name="ReviewUnusedParameters" Enabled="True" />
+ <Rule Name="TestForNaNCorrectly" Enabled="True" />
+ <Rule Name="UseManagedEquivalentsOfWin32Api" Enabled="True" />
+ <Rule Name="UseParamsForVariableArguments" Enabled="True" />
+ </RuleFile>
</RuleFiles>
<Groups />
<Settings />
</Rules>
- <FxCopReport Version="1.36">
- <Targets>
- <Target Name="$(ProjectDir)/Apache.Ignite.Core/bin/x64/Debug/Apache.Ignite.Core.dll">
- <Modules>
- <Module Name="apache.ignite.core.dll">
- <Namespaces>
- <Namespace Name="Apache.Ignite.Core.Binary">
- <Types>
- <Type Name="IBinaryReader">
- <Members>
- <Member Name="#GetRawReader()">
- <Messages>
- <Message TypeName="UsePropertiesWhereAppropriate" Category="Microsoft.Design" CheckId="CA1024" Created="2015-11-11 15:43:38Z">
- <Issue Certainty="50">
- <Item>'IBinaryReader.GetRawReader()'</Item>
- </Issue>
- </Message>
- </Messages>
- </Member>
- </Members>
- </Type>
- <Type Name="IBinaryWriter">
- <Members>
- <Member Name="#GetRawWriter()">
- <Messages>
- <Message TypeName="UsePropertiesWhereAppropriate" Category="Microsoft.Design" CheckId="CA1024" Created="2015-11-11 15:43:38Z">
- <Issue Certainty="50">
- <Item>'IBinaryWriter.GetRawWriter()'</Item>
- </Issue>
- </Message>
- </Messages>
- </Member>
- </Members>
- </Type>
- <Type Name="IIgniteBinary">
- <Members>
- <Member Name="#GetBinaryTypes()">
- <Messages>
- <Message TypeName="UsePropertiesWhereAppropriate" Category="Microsoft.Design" CheckId="CA1024" Created="2015-11-11 15:43:38Z">
- <Issue Certainty="50">
- <Item>'IIgniteBinary.GetBinaryTypes()'</Item>
- </Issue>
- </Message>
- </Messages>
- </Member>
- </Members>
- </Type>
- </Types>
- </Namespace>
- <Namespace Name="Apache.Ignite.Core.Cache">
- <Types>
- <Type Name="ICache`2">
- <Members>
- <Member Name="#TryLocalPeek(!0,!1&,Apache.Ignite.Core.Cache.CachePeekMode[])">
- <Messages>
- <Message Id="1#" TypeName="AvoidOutParameters" Category="Microsoft.Design" CheckId="CA1021" Created="2015-11-11 15:43:38Z">
- <Issue>
- <Item>'value'</Item>
- </Issue>
- </Message>
- </Messages>
- </Member>
- </Members>
- </Type>
- </Types>
- </Namespace>
- <Namespace Name="Apache.Ignite.Core.Compute">
- <Types>
- <Type Name="ComputeJobAdapter`1">
- <Members>
- <Member Name="#GetArgument`1(System.Int32)">
- <Messages>
- <Message TypeName="DoNotRaiseReservedExceptionTypes" Category="Microsoft.Usage" CheckId="CA2201" Created="2015-11-11 15:43:38Z">
- <Issue Name="Reserved">
- <Item>'ComputeJobAdapter<T>.GetArgument<TArg>(int)'</Item>
- <Item>'IndexOutOfRangeException'</Item>
- </Issue>
- </Message>
- </Messages>
- </Member>
- </Members>
- </Type>
- </Types>
- </Namespace>
- <Namespace Name="Apache.Ignite.Core.Events">
- <Types>
- <Type Name="IEvents">
- <Members>
- <Member Name="#GetEnabledEvents()">
- <Messages>
- <Message TypeName="UsePropertiesWhereAppropriate" Category="Microsoft.Design" CheckId="CA1024" Created="2015-11-11 15:43:38Z">
- <Issue Certainty="50">
- <Item>'IEvents.GetEnabledEvents()'</Item>
- </Issue>
- </Message>
- </Messages>
- </Member>
- </Members>
- </Type>
- </Types>
- </Namespace>
- <Namespace Name="Apache.Ignite.Core.Impl">
- <Types>
- <Type Name="IgniteUtils">
- <Members>
- <Member Name="#.cctor()">
- <Messages>
- <Message TypeName="InitializeReferenceTypeStaticFieldsInline" Category="Microsoft.Performance" CheckId="CA1810" Created="2015-11-11 15:43:38Z">
- <Issue>
- <Item>'IgniteUtils'</Item>
- </Issue>
- </Message>
- </Messages>
- </Member>
- </Members>
- </Type>
- </Types>
- </Namespace>
- <Namespace Name="Apache.Ignite.Core.Impl.Binary">
- <Types>
- <Type Name="BinaryReader">
- <Members>
- <Member Name="#Deserialize`1()">
- <Messages>
- <Message Id="System.String.Format(System.String,System.Object)" TypeName="SpecifyIFormatProvider" Category="Microsoft.Globalization" CheckId="CA1305" Created="2015-11-11 15:43:38Z">
- <Issue>
- <Item>'string.Format(string, object)'</Item>
- <Item>'BinaryReader.Deserialize<T>()'</Item>
- <Item>'string.Format(IFormatProvider, string, params object[])'</Item>
- </Issue>
- </Message>
- </Messages>
- </Member>
- <Member Name="#IsNotNullHeader(System.Byte)">
- <Messages>
- <Message Id="System.String.Format(System.String,System.Object,System.Object)" TypeName="SpecifyIFormatProvider" Category="Microsoft.Globalization" CheckId="CA1305" Created="2015-11-11 15:43:38Z">
- <Issue>
- <Item>'string.Format(string, object, object)'</Item>
- <Item>'BinaryReader.IsNotNullHeader(byte)'</Item>
- <Item>'string.Format(IFormatProvider, string, params object[])'</Item>
- </Issue>
- </Message>
- </Messages>
- </Member>
- </Members>
- </Type>
- <Type Name="Marshaller">
- <Members>
- <Member Name="#AddType(System.Type,System.Int32,System.String,System.Boolean,System.Boolean,Apache.Ignite.Core.Binary.IBinaryNameMapper,Apache.Ignite.Core.Binary.IBinaryIdMapper,Apache.Ignite.Core.Binary.IBinarySerializer,System.String)">
- <Messages>
- <Message Id="System.String.Format(System.String,System.Object,System.Object,System.Object)" TypeName="SpecifyIFormatProvider" Category="Microsoft.Globalization" CheckId="CA1305" Created="2015-11-11 15:43:38Z">
- <Issue>
- <Item>'string.Format(string, object, object, object)'</Item>
- <Item>'Marshaller.AddType(Type, int, string, bool, bool, IBinaryNameMapper, IBinaryIdMapper, IBinarySerializer, string)'</Item>
- <Item>'string.Format(IFormatProvider, string, params object[])'</Item>
- </Issue>
- </Message>
- </Messages>
- </Member>
- </Members>
- </Type>
- </Types>
- </Namespace>
- <Namespace Name="Apache.Ignite.Core.Impl.Common">
- <Types>
- <Type Name="Classpath">
- <Members>
- <Member Name="#AppendHomeClasspath(System.String,System.Boolean,System.Text.StringBuilder)">
- <Messages>
- <Message Id="System.String.EndsWith(System.String)" TypeName="SpecifyStringComparison" Category="Microsoft.Globalization" CheckId="CA1307" Created="2015-11-11 15:43:38Z">
- <Issue>
- <Item>'Classpath.AppendHomeClasspath(string, bool, StringBuilder)'</Item>
- <Item>'string.EndsWith(string)'</Item>
- <Item>'string.EndsWith(string, StringComparison)'</Item>
- </Issue>
- </Message>
- </Messages>
- </Member>
- <Member Name="#CreateClasspath(System.String,Apache.Ignite.Core.IgniteConfiguration,System.Boolean)">
- <Messages>
- <Message Id="System.String.EndsWith(System.String)" TypeName="SpecifyStringComparison" Category="Microsoft.Globalization" CheckId="CA1307" Created="2015-11-11 15:43:38Z">
- <Issue>
- <Item>'Classpath.CreateClasspath(string, IgniteConfiguration, bool)'</Item>
- <Item>'string.EndsWith(string)'</Item>
- <Item>'string.EndsWith(string, StringComparison)'</Item>
- </Issue>
- </Message>
- </Messages>
- </Member>
- </Members>
- </Type>
- <Type Name="Future`1">
- <Members>
- <Member Name="#OnNullResult()">
- <Messages>
- <Message TypeName="DoNotCatchGeneralExceptionTypes" Category="Microsoft.Design" CheckId="CA1031" Created="2015-11-11 15:43:38Z">
- <Issue>
- <Item>'Future<T>.OnNullResult()'</Item>
- <Item>'Exception'</Item>
- </Issue>
- </Message>
- </Messages>
- </Member>
- </Members>
- </Type>
- <Type Name="IgniteHome">
- <Members>
- <Member Name="#Resolve(Apache.Ignite.Core.IgniteConfiguration)">
- <Messages>
- <Message Id="System.String.Format(System.String,System.Object)" TypeName="SpecifyIFormatProvider" Category="Microsoft.Globalization" CheckId="CA1305" Created="2015-11-11 15:43:38Z">
- <Issue>
- <Item>'string.Format(string, object)'</Item>
- <Item>'IgniteHome.Resolve(IgniteConfiguration)'</Item>
- <Item>'string.Format(IFormatProvider, string, params object[])'</Item>
- </Issue>
- </Message>
- <Message Id="System.String.Format(System.String,System.Object,System.Object)" TypeName="SpecifyIFormatProvider" Category="Microsoft.Globalization" CheckId="CA1305" Created="2015-11-11 15:43:38Z">
- <Issue>
- <Item>'string.Format(string, object, object)'</Item>
- <Item>'IgniteHome.Resolve(IgniteConfiguration)'</Item>
- <Item>'string.Format(IFormatProvider, string, params object[])'</Item>
- </Issue>
- </Message>
- </Messages>
- </Member>
- </Members>
- </Type>
- </Types>
- </Namespace>
- <Namespace Name="Apache.Ignite.Core.Impl.Memory">
- <Types>
- <Type Name="IPlatformMemory">
- <Members>
- <Member Name="#GetStream()">
- <Messages>
- <Message TypeName="UsePropertiesWhereAppropriate" Category="Microsoft.Design" CheckId="CA1024" Created="2015-11-11 15:43:38Z">
- <Issue Certainty="50">
- <Item>'IPlatformMemory.GetStream()'</Item>
- </Issue>
- </Message>
- </Messages>
- </Member>
- </Members>
- </Type>
- </Types>
- </Namespace>
- <Namespace Name="Apache.Ignite.Core.Impl.Unmanaged">
- <Types>
- <Type Name="UnmanagedUtils">
- <Members>
- <Member Name="#.cctor()">
- <Messages>
- <Message Id="System.String.Format(System.String,System.Object,System.Object)" TypeName="SpecifyIFormatProvider" Category="Microsoft.Globalization" CheckId="CA1305" Created="2015-11-11 15:43:38Z">
- <Issue>
- <Item>'string.Format(string, object, object)'</Item>
- <Item>'UnmanagedUtils.UnmanagedUtils()'</Item>
- <Item>'string.Format(IFormatProvider, string, params object[])'</Item>
- </Issue>
- </Message>
- </Messages>
- </Member>
- </Members>
- </Type>
- </Types>
- </Namespace>
- </Namespaces>
- </Module>
- </Modules>
- </Target>
- </Targets>
- <Rules>
- <Rule TypeName="AvoidOutParameters" Category="Microsoft.Design" CheckId="CA1021">
- <Resolution Name="Default">Consider a design that does not require that {0} be an out parameter.</Resolution>
- </Rule>
- <Rule TypeName="DoNotCatchGeneralExceptionTypes" Category="Microsoft.Design" CheckId="CA1031">
- <Resolution Name="Default">Modify {0} to catch a more specific exception than {1} or rethrow the exception.</Resolution>
- </Rule>
- <Rule TypeName="DoNotRaiseReservedExceptionTypes" Category="Microsoft.Usage" CheckId="CA2201">
- <Resolution Name="Reserved">{0} creates an exception of type {1}, an exception type that is reserved by the runtime and should never be raised by managed code. If this exception instance might be thrown, use a different exception type.</Resolution>
- </Rule>
- <Rule TypeName="InitializeReferenceTypeStaticFieldsInline" Category="Microsoft.Performance" CheckId="CA1810">
- <Resolution Name="Default">Initialize all static fields in {0} when those fields are declared and remove the explicit static constructor.</Resolution>
- </Rule>
- <Rule TypeName="SpecifyIFormatProvider" Category="Microsoft.Globalization" CheckId="CA1305">
- <Resolution Name="Default">Because the behavior of {0} could vary based on the current user's locale settings, replace this call in {1} with a call to {2}. If the result of {2} will be displayed to the user, specify 'CultureInfo.CurrentCulture' as the 'IFormatProvider' parameter. Otherwise, if the result will be stored and accessed by software, such as when it is persisted to disk or to a database, specify 'CultureInfo.InvariantCulture'.</Resolution>
- </Rule>
- <Rule TypeName="SpecifyStringComparison" Category="Microsoft.Globalization" CheckId="CA1307">
- <Resolution Name="Default">{0} makes a call to {1} that does not explicitly provide a StringComparison. This should be replaced with a call to {2}.</Resolution>
- </Rule>
- <Rule TypeName="UsePropertiesWhereAppropriate" Category="Microsoft.Design" CheckId="CA1024">
- <Resolution Name="Default">Change {0} to a property if appropriate.</Resolution>
- </Rule>
- </Rules>
- </FxCopReport>
+ <FxCopReport Version="1.36" />
</FxCopProject>
http://git-wip-us.apache.org/repos/asf/ignite/blob/a34d7058/modules/platforms/dotnet/Apache.Ignite.sln
----------------------------------------------------------------------
diff --git a/modules/platforms/dotnet/Apache.Ignite.sln b/modules/platforms/dotnet/Apache.Ignite.sln
index 164f388..a28d714 100644
--- a/modules/platforms/dotnet/Apache.Ignite.sln
+++ b/modules/platforms/dotnet/Apache.Ignite.sln
@@ -1,4 +1,5 @@
-Microsoft Visual Studio Solution File, Format Version 11.00
+
+Microsoft Visual Studio Solution File, Format Version 11.00
# Visual Studio 2010
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Apache.Ignite.Core", "Apache.Ignite.Core\Apache.Ignite.Core.csproj", "{4CD2F726-7E2B-46C4-A5BA-057BB82EECB6}"
EndProject
@@ -24,6 +25,7 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution
Apache.Ignite.dxg = Apache.Ignite.dxg
Apache.Ignite.FxCop = Apache.Ignite.FxCop
Apache.Ignite.sln.DotSettings = Apache.Ignite.sln.DotSettings
+ Apache.Ignite.sln.TeamCity.DotSettings = Apache.Ignite.sln.TeamCity.DotSettings
build.bat = build.bat
DEVNOTES.txt = DEVNOTES.txt
examples\Config\example-cache-query.xml = examples\Config\example-cache-query.xml
http://git-wip-us.apache.org/repos/asf/ignite/blob/a34d7058/modules/platforms/dotnet/Apache.Ignite.sln.TeamCity.DotSettings
----------------------------------------------------------------------
diff --git a/modules/platforms/dotnet/Apache.Ignite.sln.TeamCity.DotSettings b/modules/platforms/dotnet/Apache.Ignite.sln.TeamCity.DotSettings
new file mode 100644
index 0000000..cf9e287
--- /dev/null
+++ b/modules/platforms/dotnet/Apache.Ignite.sln.TeamCity.DotSettings
@@ -0,0 +1,30 @@
+<wpf:ResourceDictionary xml:space="preserve" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns:s="clr-namespace:System;assembly=mscorlib" xmlns:ss="urn:shemas-jetbrains-com:settings-storage-xaml" xmlns:wpf="http://schemas.microsoft.com/winfx/2006/xaml/presentation">
+ <s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=ConvertToLambdaExpression/@EntryIndexedValue">DO_NOT_SHOW</s:String>
+ <s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=DoNotCallOverridableMethodsInConstructor/@EntryIndexedValue">DO_NOT_SHOW</s:String>
+ <s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=EmptyNamespace/@EntryIndexedValue">DO_NOT_SHOW</s:String>
+ <s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=ForCanBeConvertedToForeach/@EntryIndexedValue">DO_NOT_SHOW</s:String>
+ <s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=IntroduceOptionalParameters_002EGlobal/@EntryIndexedValue">DO_NOT_SHOW</s:String>
+ <s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=LoopCanBeConvertedToQuery/@EntryIndexedValue">DO_NOT_SHOW</s:String>
+ <s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=MemberCanBePrivate_002EGlobal/@EntryIndexedValue">DO_NOT_SHOW</s:String>
+ <s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=MemberCanBePrivate_002ELocal/@EntryIndexedValue">DO_NOT_SHOW</s:String>
+ <s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=MemberCanBeProtected_002EGlobal/@EntryIndexedValue">DO_NOT_SHOW</s:String>
+ <s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=ParameterTypeCanBeEnumerable_002EGlobal/@EntryIndexedValue">DO_NOT_SHOW</s:String>
+ <s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=ParameterTypeCanBeEnumerable_002ELocal/@EntryIndexedValue">DO_NOT_SHOW</s:String>
+ <s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=PossiblyMistakenUseOfParamsMethod/@EntryIndexedValue">DO_NOT_SHOW</s:String>
+ <s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=ReturnTypeCanBeEnumerable_002EGlobal/@EntryIndexedValue">DO_NOT_SHOW</s:String>
+ <s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=ReturnTypeCanBeEnumerable_002ELocal/@EntryIndexedValue">DO_NOT_SHOW</s:String>
+ <s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=SuggestVarOrType_005FBuiltInTypes/@EntryIndexedValue">DO_NOT_SHOW</s:String>
+ <s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=SuggestVarOrType_005FElsewhere/@EntryIndexedValue">DO_NOT_SHOW</s:String>
+ <s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=SuggestVarOrType_005FSimpleTypes/@EntryIndexedValue">DO_NOT_SHOW</s:String>
+ <s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=UnusedMemberInSuper_002EGlobal/@EntryIndexedValue">DO_NOT_SHOW</s:String>
+ <s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=UnusedMember_002EGlobal/@EntryIndexedValue">DO_NOT_SHOW</s:String>
+ <s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=UnusedMethodReturnValue_002EGlobal/@EntryIndexedValue">DO_NOT_SHOW</s:String>
+ <s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=UnusedParameter_002EGlobal/@EntryIndexedValue">DO_NOT_SHOW</s:String>
+ <s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=SuggestUseVarKeywordEverywhere/@EntryIndexedValue">DO_NOT_SHOW</s:String>
+ <s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=SuggestUseVarKeywordEvident/@EntryIndexedValue">DO_NOT_SHOW</s:String>
+ <s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=StaticMemberInGenericType/@EntryIndexedValue">DO_NOT_SHOW</s:String>
+ <s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=StaticFieldInGenericType/@EntryIndexedValue">DO_NOT_SHOW</s:String>
+ <s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=VirtualMemberNeverOverriden_002EGlobal/@EntryIndexedValue">DO_NOT_SHOW</s:String>
+
+ <s:Boolean x:Key="/Default/CodeStyle/CSharpUsing/AddImportsToDeepestScope/@EntryValue">True</s:Boolean>
+ <s:Boolean x:Key="/Default/CodeStyle/CSharpUsing/QualifiedUsingAtNestedScope/@EntryValue">True</s:Boolean></wpf:ResourceDictionary>
\ No newline at end of file
http://git-wip-us.apache.org/repos/asf/ignite/blob/a34d7058/modules/platforms/dotnet/Apache.Ignite/Apache.Ignite.csproj
----------------------------------------------------------------------
diff --git a/modules/platforms/dotnet/Apache.Ignite/Apache.Ignite.csproj b/modules/platforms/dotnet/Apache.Ignite/Apache.Ignite.csproj
index fa7d6cf..e2dae25 100644
--- a/modules/platforms/dotnet/Apache.Ignite/Apache.Ignite.csproj
+++ b/modules/platforms/dotnet/Apache.Ignite/Apache.Ignite.csproj
@@ -1,9 +1,9 @@
<?xml version="1.0" encoding="utf-8"?>
-<Project ToolsVersion="12.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
+<Project ToolsVersion="4.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" />
<PropertyGroup>
<Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
- <Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
+ <Platform Condition=" '$(Platform)' == '' ">x64</Platform>
<ProjectGuid>{27F7F3C6-BDDE-43A9-B565-856F8395A04B}</ProjectGuid>
<OutputType>Exe</OutputType>
<AppDesignerFolder>Properties</AppDesignerFolder>
@@ -15,6 +15,7 @@
<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Debug|x64'">
<PlatformTarget>x64</PlatformTarget>
<OutputPath>bin\x64\Debug\</OutputPath>
+ <RunCodeAnalysis>false</RunCodeAnalysis>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Release|x64'">
<PlatformTarget>x64</PlatformTarget>
http://git-wip-us.apache.org/repos/asf/ignite/blob/a34d7058/modules/platforms/dotnet/examples/Apache.Ignite.Examples/Apache.Ignite.Examples.csproj
----------------------------------------------------------------------
diff --git a/modules/platforms/dotnet/examples/Apache.Ignite.Examples/Apache.Ignite.Examples.csproj b/modules/platforms/dotnet/examples/Apache.Ignite.Examples/Apache.Ignite.Examples.csproj
index abe4b14..d72eaa3 100644
--- a/modules/platforms/dotnet/examples/Apache.Ignite.Examples/Apache.Ignite.Examples.csproj
+++ b/modules/platforms/dotnet/examples/Apache.Ignite.Examples/Apache.Ignite.Examples.csproj
@@ -1,9 +1,9 @@
<?xml version="1.0" encoding="utf-8"?>
-<Project ToolsVersion="12.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
+<Project ToolsVersion="4.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" />
<PropertyGroup>
<Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
- <Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
+ <Platform Condition=" '$(Platform)' == '' ">x64</Platform>
<ProjectGuid>{069FA680-3C4D-43A9-B84F-E67513B87827}</ProjectGuid>
<OutputType>Exe</OutputType>
<AppDesignerFolder>Properties</AppDesignerFolder>
http://git-wip-us.apache.org/repos/asf/ignite/blob/a34d7058/modules/platforms/dotnet/examples/Apache.Ignite.ExamplesDll/Apache.Ignite.ExamplesDll.csproj
----------------------------------------------------------------------
diff --git a/modules/platforms/dotnet/examples/Apache.Ignite.ExamplesDll/Apache.Ignite.ExamplesDll.csproj b/modules/platforms/dotnet/examples/Apache.Ignite.ExamplesDll/Apache.Ignite.ExamplesDll.csproj
index df19d2e..ccbdf4b 100644
--- a/modules/platforms/dotnet/examples/Apache.Ignite.ExamplesDll/Apache.Ignite.ExamplesDll.csproj
+++ b/modules/platforms/dotnet/examples/Apache.Ignite.ExamplesDll/Apache.Ignite.ExamplesDll.csproj
@@ -1,9 +1,9 @@
<?xml version="1.0" encoding="utf-8"?>
-<Project ToolsVersion="12.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
+<Project ToolsVersion="4.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" />
<PropertyGroup>
<Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
- <Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
+ <Platform Condition=" '$(Platform)' == '' ">x64</Platform>
<ProjectGuid>{DFB08363-202E-412D-8812-349EF10A8702}</ProjectGuid>
<OutputType>Library</OutputType>
<AppDesignerFolder>Properties</AppDesignerFolder>
http://git-wip-us.apache.org/repos/asf/ignite/blob/a34d7058/parent/pom.xml
----------------------------------------------------------------------
diff --git a/parent/pom.xml b/parent/pom.xml
index 4497d01..8f02fec 100644
--- a/parent/pom.xml
+++ b/parent/pom.xml
@@ -885,7 +885,7 @@
<exclude>**/*.sln</exclude>
<exclude>**/*.snk</exclude>
<exclude>**/*.slnrel</exclude>
- <exclude>**/*.sln.DotSettings</exclude>
+ <exclude>**/*.DotSettings</exclude>
<exclude>**/*.FxCop</exclude>
<exclude>**/*.csproj</exclude>
<exclude>**/*.csprojrel</exclude>
@@ -895,6 +895,7 @@
<exclude>**/mkbuild.cmd</exclude>
<exclude>**/module.def</exclude>
<exclude>**/*.fxcop</exclude>
+ <exclude>**/*.ruleset</exclude>
<exclude>**/*.metaproj</exclude>
<exclude>**/*.metaproj.tmp</exclude>
<exclude>**/*.nunit</exclude>