You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "shalk (via GitHub)" <gi...@apache.org> on 2024/04/30 08:24:52 UTC

[PR] Update guide-using-toolchains.apt [maven-site]

shalk opened a new pull request, #517:
URL: https://github.com/apache/maven-site/pull/517

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update guide-using-toolchains.apt [maven-site]

Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on code in PR #517:
URL: https://github.com/apache/maven-site/pull/517#discussion_r1597136406


##########
content/apt/guides/mini/guide-using-toolchains.apt:
##########
@@ -69,7 +71,7 @@ Guide to Using Toolchains
 *-----------------*----------------------------------------------------------------------------------------------+---------------------+----------------+
 | jdk             | <<<{{{https://www.mojohaus.org/keytool/keytool-maven-plugin/}keytool-maven-plugin}}>>>       | 1.4                 | MojoHaus
 *-----------------*----------------------------------------------------------------------------------------------+---------------------+----------------+
-| protobuf        | <<<{{{http://sergei-ivanov.github.io/maven-protoc-plugin/examples/protobuf-toolchain.html}maven-protoc-plugin}}>>> | 0.3.2 | github
+| protobuf        | <<<{{{https://www.xolstice.org/protobuf-maven-plugin/examples/protobuf-toolchain.html}protobuf-maven-plugin}}>>> | 0.3.2 | github

Review Comment:
   does the version need to be updated here too?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update guide-using-toolchains.apt [maven-site]

Posted by "shalk (via GitHub)" <gi...@apache.org>.
shalk commented on code in PR #517:
URL: https://github.com/apache/maven-site/pull/517#discussion_r1597333195


##########
content/apt/guides/mini/guide-using-toolchains.apt:
##########
@@ -69,7 +71,7 @@ Guide to Using Toolchains
 *-----------------*----------------------------------------------------------------------------------------------+---------------------+----------------+
 | jdk             | <<<{{{https://www.mojohaus.org/keytool/keytool-maven-plugin/}keytool-maven-plugin}}>>>       | 1.4                 | MojoHaus
 *-----------------*----------------------------------------------------------------------------------------------+---------------------+----------------+
-| protobuf        | <<<{{{http://sergei-ivanov.github.io/maven-protoc-plugin/examples/protobuf-toolchain.html}maven-protoc-plugin}}>>> | 0.3.2 | github
+| protobuf        | <<<{{{https://www.xolstice.org/protobuf-maven-plugin/examples/protobuf-toolchain.html}protobuf-maven-plugin}}>>> | 0.3.2 | github

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org