You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <bb...@apache.org> on 2019/06/20 13:30:16 UTC
Review Request 70906: Fixed pid checkpointing for `TestContainerizer`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70906/
-----------------------------------------------------------
Review request for mesos, Gilbert Song, Greg Mann, and Joseph Wu.
Repository: mesos
Description
-------
In order for a `MockExecutor` to be able to reregister after agent
restart a persisted pid is required. This patch adds checkpointing of
the pid.
Diffs
-----
src/tests/containerizer.cpp fab7e81339f3b7b3fec2a4f6cb7e3a52df2607ed
Diff: https://reviews.apache.org/r/70906/diff/1/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 70906: Fixed pid checkpointing for
`TestContainerizer`.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70906/#review216355
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On June 21, 2019, 2:59 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70906/
> -----------------------------------------------------------
>
> (Updated June 21, 2019, 2:59 a.m.)
>
>
> Review request for mesos, Gilbert Song, Greg Mann, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In order for a `MockExecutor` to be able to reregister after agent
> restart a persisted pid is required. This patch adds checkpointing of
> the pid.
>
>
> Diffs
> -----
>
> src/tests/containerizer.cpp fab7e81339f3b7b3fec2a4f6cb7e3a52df2607ed
>
>
> Diff: https://reviews.apache.org/r/70906/diff/3/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 70906: Fixed pid checkpointing for
`TestContainerizer`.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70906/#review216426
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On July 8, 2019, 2:20 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70906/
> -----------------------------------------------------------
>
> (Updated July 8, 2019, 2:20 p.m.)
>
>
> Review request for mesos, Gilbert Song, Greg Mann, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In order for a `MockExecutor` to be able to reregister after agent
> restart a persisted pid is required. This patch adds checkpointing of
> the pid.
>
>
> Diffs
> -----
>
> src/tests/containerizer.cpp fab7e81339f3b7b3fec2a4f6cb7e3a52df2607ed
>
>
> Diff: https://reviews.apache.org/r/70906/diff/3/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 70906: Fixed pid checkpointing for
`TestContainerizer`.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70906/
-----------------------------------------------------------
(Updated July 8, 2019, 9:20 p.m.)
Review request for mesos, Gilbert Song, Greg Mann, and Joseph Wu.
Repository: mesos
Description
-------
In order for a `MockExecutor` to be able to reregister after agent
restart a persisted pid is required. This patch adds checkpointing of
the pid.
Diffs
-----
src/tests/containerizer.cpp fab7e81339f3b7b3fec2a4f6cb7e3a52df2607ed
Diff: https://reviews.apache.org/r/70906/diff/3/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 70906: Fixed pid checkpointing for
`TestContainerizer`.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70906/
-----------------------------------------------------------
(Updated June 21, 2019, 11:59 a.m.)
Review request for mesos, Gilbert Song, Greg Mann, and Joseph Wu.
Repository: mesos
Description
-------
In order for a `MockExecutor` to be able to reregister after agent
restart a persisted pid is required. This patch adds checkpointing of
the pid.
Diffs (updated)
-----
src/tests/containerizer.cpp fab7e81339f3b7b3fec2a4f6cb7e3a52df2607ed
Diff: https://reviews.apache.org/r/70906/diff/2/
Changes: https://reviews.apache.org/r/70906/diff/1-2/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 70906: Fixed pid checkpointing for
`TestContainerizer`.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70906/#review216002
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/containerizer.cpp
Lines 166-176 (patched)
<https://reviews.apache.org/r/70906/#comment302938>
Not indented far enough.
src/tests/containerizer.cpp
Line 166 (original), 176-179 (patched)
<https://reviews.apache.org/r/70906/#comment302939>
Extra newline
- Greg Mann
On June 20, 2019, 1:30 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70906/
> -----------------------------------------------------------
>
> (Updated June 20, 2019, 1:30 p.m.)
>
>
> Review request for mesos, Gilbert Song, Greg Mann, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In order for a `MockExecutor` to be able to reregister after agent
> restart a persisted pid is required. This patch adds checkpointing of
> the pid.
>
>
> Diffs
> -----
>
> src/tests/containerizer.cpp fab7e81339f3b7b3fec2a4f6cb7e3a52df2607ed
>
>
> Diff: https://reviews.apache.org/r/70906/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>