[GitHub] [tvm] areusch commented on a change in pull request #8941: [microTVM] Zephyr: implement 'west_cmd' server option

[GitBox <gi...@apache.org>]

areusch commented on a change in pull request #8941:
URL: https://github.com/apache/tvm/pull/8941#discussion_r704712000



##########
File path: apps/microtvm/zephyr/template_project/microtvm_api_server.py
##########
@@ -451,6 +451,11 @@ def flash(self, options):
             recover_args.extend(_get_nrf_device_args(options))
             check_call(recover_args, cwd=API_SERVER_DIR / "build")
 
+        if "west_cmd" in options:
+            west_cmd = options["west_cmd"]
+            cmake_args = ["cmake", "..", f"-DWEST={west_cmd}"]

Review comment:
       i wonder if we should add this option to the original cmake invocation on line 395? i think it makes sense to have `west_cmd`, but thinking it's better to place there just in case this triggers a rebuild.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org